Skip to content

fix: unregister goosed child process's listener#7956

Merged
jh-block merged 1 commit intomainfrom
micn/goose-v8-error-patch
Mar 17, 2026
Merged

fix: unregister goosed child process's listener#7956
jh-block merged 1 commit intomainfrom
micn/goose-v8-error-patch

Conversation

@michaelneale
Copy link
Copy Markdown
Collaborator

@michaelneale michaelneale commented Mar 17, 2026

this may stop crashes after very long sessions (to do with v8)

shows up after many hours, days as this:

image

Copy link
Copy Markdown
Collaborator

@jh-block jh-block left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DOsinga maybe this was the culprit?

@jh-block jh-block added this pull request to the merge queue Mar 17, 2026
Merged via the queue into main with commit 8db67c1 Mar 17, 2026
20 checks passed
@jh-block jh-block deleted the micn/goose-v8-error-patch branch March 17, 2026 10:17
@DOsinga
Copy link
Copy Markdown
Collaborator

DOsinga commented Mar 17, 2026

I don't think so. We don't print on stdout I think other than the fingerprint - the logging goes to stderr and I disconnected that last week (should probably do this the same way)

and even so, if I look at goosed's logs overnight there's almost nothing there. the LLMs keep going on about memory pressure (97Mb!). it can't hurt of course

jh-block added a commit that referenced this pull request Mar 17, 2026
…ct-ui

* origin/main:
  Improve the formatting of tool calls, show thinking, treat Reasoning and Thinking as the same thing (sorry Kant) (#7626)
  don't imply running builds all the time in AGENTS.md (#7865)
  fix: unregister goosed child process's  listener (#7956)

# Conflicts:
#	ui/desktop/src/api/index.ts
@michaelneale
Copy link
Copy Markdown
Collaborator Author

yeah 97 is nothing really ... but thought was worth a try

jh-block added a commit to rabi/goose that referenced this pull request Mar 18, 2026
* main: (32 commits)
  Revert message flush & test (block#7966)
  docs: add Remote Access section with Telegram Gateway documentation (block#7955)
  fix: update webmcp blog post metadata image URL (block#7967)
  fix: clean up OAuth token cache on provider deletion (block#7908)
  fix: hard-coded tool call id in code mode callback (block#7939)
  Fix SSE parsers to accept optional space after data: prefix (block#7929)
  docs: add GOOSE_INPUT_LIMIT to config-files.md (block#7961)
  Add WebMCP for Beginners blog post (block#7957)
  Fix download manager (block#7933)
  Improve the formatting of tool calls, show thinking, treat Reasoning and Thinking as the same thing (sorry Kant) (block#7626)
  don't imply running builds all the time in AGENTS.md (block#7865)
  fix: unregister goosed child process's  listener (block#7956)
  feat: adversarial agent for preventing leaking of info and more  (block#7948)
  Update contributing.md (block#7927)
  docs: add credit balance monitoring section (block#7952)
  docs: add Cerebras provider to supported providers list (block#7953)
  docs: add TUI client documentation to ACP clients guide (block#7950)
  fix: removed double dash in pnpm command (block#7951)
  docs: polish ACP docs (block#7946)
  claude adaptive thinking (block#7944)
  ...
elijahsgh pushed a commit to elijahsgh/goose that referenced this pull request Mar 21, 2026
elijahsgh pushed a commit to elijahsgh/goose that referenced this pull request Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants