docs: add Claude Code approve mode permission routing documentation#7949
docs: add Claude Code approve mode permission routing documentation#7949angiejones merged 4 commits intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 02f3a3e60e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| | `chat` | (none) | Default Claude Code behavior | | ||
|
|
||
| :::tip Approve Mode Integration | ||
| When using `approve` or `smart-approve` mode with Claude Code, goose routes Claude Code's permission prompts through goose's confirmation interface. This means: |
There was a problem hiding this comment.
smart_approve mode name in Claude Code docs
This new guidance uses smart-approve, but GOOSE_MODE is deserialized from GooseMode with snake_case values (smart_approve) in crates/goose/src/config/goose_mode.rs; if users copy smart-approve, mode parsing fails and claude_code::apply_permission_flags falls back to GooseMode::Auto (unwrap_or(GooseMode::Auto)), which enables --dangerously-skip-permissions instead of approval prompts. That can silently disable the safety behavior this section is describing.
Useful? React with 👍 / 👎.
|
DOsinga
left a comment
DOsinga
left a comment
There was a problem hiding this comment.
Docs look good! One fix pushed directly to the branch: changed smart-approve to smart_approve in the tip box prose — the enum is deserialized as snake_case so the hyphenated form would silently fall back to auto mode (which skips all permissions), which is the opposite of what this section is documenting. Everything else is accurate and clear.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 345c8f9502
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Document the new feature that routes Claude Code permission prompts through goose's confirmation interface when using approve or smart-approve mode. Updates: - cli-providers.md: Added tip box explaining approve mode integration with example command - goose-permissions.md: Added CLI Provider Permission Integration section explaining how goose integrates with CLI providers' native permission systems Related to: #7420 Signed-off-by: Rizel Scarlett <[email protected]> Signed-off-by: Angie Jones <[email protected]>
Signed-off-by: Douwe Osinga <[email protected]> Signed-off-by: Angie Jones <[email protected]>
Co-authored-by: Angie Jones <[email protected]> Signed-off-by: Angie Jones <[email protected]>
angiejones
force-pushed
the
docs/claude-code-approve-mode
branch
from
345c8f9 to
5ad79d5
Compare
Signed-off-by: Angie Jones <[email protected]>
…lock#7949) Signed-off-by: Rizel Scarlett <[email protected]> Signed-off-by: Angie Jones <[email protected]> Signed-off-by: Douwe Osinga <[email protected]> Co-authored-by: Douwe Osinga <[email protected]> Co-authored-by: Angie Jones <[email protected]> Co-authored-by: Angie Jones <[email protected]> Signed-off-by: esnyder <[email protected]>
…lock#7949) Signed-off-by: Rizel Scarlett <[email protected]> Signed-off-by: Angie Jones <[email protected]> Signed-off-by: Douwe Osinga <[email protected]> Co-authored-by: Douwe Osinga <[email protected]> Co-authored-by: Angie Jones <[email protected]> Co-authored-by: Angie Jones <[email protected]> Signed-off-by: esnyder <[email protected]>
* origin/main: (62 commits) Tweak the release process: no more merge to main (#7994) fix: gemini models via databricks (#8042) feat(apps): Pass toolInfo to MCP Apps via hostContext (#7506) fix: remove configured marker when deleting oauth provider configuration (#7887) docs: add vmware-aiops MCP extension documentation (#8055) Show setup instructions for ACP providers in settings modal (#8065) deps: replace sigstore-verification with sigstore-verify to kill vulns (#8064) feat(acp): add session/set_config and stabilize list, delete and close (#7984) docs: Correct `gosoe` typo to `goose` (#8062) fix: use default provider and model when provider in session no longer exists (#8035) feat: add GOOSE_SHELL env var to configure preferred shell (#7909) fix(desktop): fullscreen header bar + always-visible close controls (#8033) docs: add Claude Code approve mode permission routing documentation (#7949) chatgpt_codex: Support reasoning and gpt-5.4 (#7941) refactor(anthropic): fix N+1 thinking message storage issue (#7958) fix: handle mid-stream error events in OpenAI SSE streaming (#8031) Fix apps extension: coerce string arguments from inner LLM responses (#8030) feat: ability to expand sidebar to see chats names (#7816) Fix config for GOOSE_MAX_BACKGROUND_TASKS (#7940) set MACOSX_DEPLOYMENT_TARGET=12.0 (#7947) ...
…pstream * wpfleger/socket-support: (62 commits) Tweak the release process: no more merge to main (#7994) fix: gemini models via databricks (#8042) feat(apps): Pass toolInfo to MCP Apps via hostContext (#7506) fix: remove configured marker when deleting oauth provider configuration (#7887) docs: add vmware-aiops MCP extension documentation (#8055) Show setup instructions for ACP providers in settings modal (#8065) deps: replace sigstore-verification with sigstore-verify to kill vulns (#8064) feat(acp): add session/set_config and stabilize list, delete and close (#7984) docs: Correct `gosoe` typo to `goose` (#8062) fix: use default provider and model when provider in session no longer exists (#8035) feat: add GOOSE_SHELL env var to configure preferred shell (#7909) fix(desktop): fullscreen header bar + always-visible close controls (#8033) docs: add Claude Code approve mode permission routing documentation (#7949) chatgpt_codex: Support reasoning and gpt-5.4 (#7941) refactor(anthropic): fix N+1 thinking message storage issue (#7958) fix: handle mid-stream error events in OpenAI SSE streaming (#8031) Fix apps extension: coerce string arguments from inner LLM responses (#8030) feat: ability to expand sidebar to see chats names (#7816) Fix config for GOOSE_MAX_BACKGROUND_TASKS (#7940) set MACOSX_DEPLOYMENT_TARGET=12.0 (#7947) ...
3 participants
Summary
Document the new feature that routes Claude Code permission prompts through goose's confirmation interface when using approve or smart-approve mode.
What's Documented
cli-providers.md
Added a tip box after the Claude Code permission modes table explaining:
goose-permissions.md
Added a new "CLI Provider Permission Integration" section that:
Related
Documents the feature from #7420