feat: add GOOSE_SHOW_FULL_OUTPUT config to disable tool output truncation#7919
Merged
DOsinga merged 2 commits intoblock:mainfrom Mar 26, 2026
Merged
Conversation
…tion The SHOW_FULL_TOOL_OUTPUT flag existed but was hardcoded to false with no way to enable it. This wires it up to be configurable via: - Environment variable: GOOSE_SHOW_FULL_OUTPUT=true - Config parameter: GOOSE_SHOW_FULL_OUTPUT (boolean) When enabled, tool call arguments and results are displayed in full instead of being truncated. Useful for debugging tool calls with large arguments (e.g. execute tool with multi-line code blocks). Co-Authored-By: Claude Opus 4.6 <[email protected]> Signed-off-by: Dale Lakes <[email protected]>
DOsinga
reviewed
Mar 17, 2026
| .unwrap_or_else(|| | ||
| Config::global().get_param::<bool>("GOOSE_SHOW_FULL_OUTPUT").unwrap_or(false) | ||
| ) | ||
| ); |
Collaborator
There was a problem hiding this comment.
get param already checks the environment variables
Co-Authored-By: Claude Opus 4.6 <[email protected]> Signed-off-by: Dale Lakes <[email protected]>
DOsinga
approved these changes
Mar 23, 2026
Collaborator
DOsinga
left a comment
DOsinga
left a comment
There was a problem hiding this comment.
LGTM — clean minimal change that wires up the existing SHOW_FULL_TOOL_OUTPUT thread-local to Config::global().get_param, which already handles env var lookup. Nice simplification after the follow-up commit.
michaelneale
added a commit
that referenced
this pull request
Mar 26, 2026
* main: (337 commits) fix: replace panics with user-friendly errors in CLI session builder (#7901) fix: read GOOSE_CONTEXT_LIMIT from config.yaml, not just env vars (#7900) fix: deliver truncation notice as separate content block (#7899) fix: use platform-appropriate commands in developer extension instructions (#7898) fix: replace any with proper SVG types in icon components (#7873) chore: remove debug console.log statements, stale comments, and dead code (#8142) feat: Gemini OAuth provider (#8129) chore(deps): bump picomatch from 2.3.1 to 2.3.2 in /documentation (#8123) feat: show installed skills in UI (#7910) fix(deps): gate keyring platform features behind target-specific deps (#8039) chore(deps): bump yaml from 2.8.2 to 2.8.3 in /evals/open-model-gym/suite (#8124) fix: strip message wrapper in CLI session title generation (#7996) fix(providers): fall back to configured models when models endpoint fetch fails (#7530) chore(deps): bump brace-expansion from 5.0.3 to 5.0.5 in /evals/open-model-gym/suite (#8139) fix: prevent Ollama provider from hanging on tool-calling requests (#7723) fix: VMware Tanzu Platform provider - bug fixes, streaming, UI improvements (#8126) feat: allow GOOSE_CLI_SHOW_THINKING to be set in config.yaml (#8097) fix: GitHub Copilot auth fails to open browser in Desktop app (#6957) (#8019) fix(ci): produce .tar.gz archives for Zed ACP registry compatibility (#8054) feat: add GOOSE_SHOW_FULL_OUTPUT config to disable tool output truncation (#7919) ... # Conflicts: # crates/goose/src/providers/formats/openai.rs
hydrosquall
pushed a commit
to hydrosquall/goose
that referenced
this pull request
Mar 31, 2026
…tion (block#7919) Signed-off-by: Dale Lakes <[email protected]> Co-authored-by: Claude Opus 4.6 <[email protected]> Signed-off-by: Cameron Yick <[email protected]>
blackgirlbytes
pushed a commit
that referenced
this pull request
Apr 2, 2026
* main: (337 commits) fix: replace panics with user-friendly errors in CLI session builder (#7901) fix: read GOOSE_CONTEXT_LIMIT from config.yaml, not just env vars (#7900) fix: deliver truncation notice as separate content block (#7899) fix: use platform-appropriate commands in developer extension instructions (#7898) fix: replace any with proper SVG types in icon components (#7873) chore: remove debug console.log statements, stale comments, and dead code (#8142) feat: Gemini OAuth provider (#8129) chore(deps): bump picomatch from 2.3.1 to 2.3.2 in /documentation (#8123) feat: show installed skills in UI (#7910) fix(deps): gate keyring platform features behind target-specific deps (#8039) chore(deps): bump yaml from 2.8.2 to 2.8.3 in /evals/open-model-gym/suite (#8124) fix: strip message wrapper in CLI session title generation (#7996) fix(providers): fall back to configured models when models endpoint fetch fails (#7530) chore(deps): bump brace-expansion from 5.0.3 to 5.0.5 in /evals/open-model-gym/suite (#8139) fix: prevent Ollama provider from hanging on tool-calling requests (#7723) fix: VMware Tanzu Platform provider - bug fixes, streaming, UI improvements (#8126) feat: allow GOOSE_CLI_SHOW_THINKING to be set in config.yaml (#8097) fix: GitHub Copilot auth fails to open browser in Desktop app (#6957) (#8019) fix(ci): produce .tar.gz archives for Zed ACP registry compatibility (#8054) feat: add GOOSE_SHOW_FULL_OUTPUT config to disable tool output truncation (#7919) ... # Conflicts: # crates/goose/src/providers/formats/openai.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SHOW_FULL_TOOL_OUTPUTflag to be user-configurablefalsewith no way to enable it (toggle_full_tool_output()was dead code)Configuration
Enable via either:
GOOSE_SHOW_FULL_OUTPUT=true(or1)GOOSE_SHOW_FULL_OUTPUT(boolean)Use case
When using the
executetool or other tools with large arguments (e.g. multi-line code blocks), the CLI truncates the display, making it hard to see what code was actually sent. With this config enabled, tool call arguments and results are shown in full.Test plan
GOOSE_SHOW_FULL_OUTPUT=true goose sessionshows full tool argumentsgoose configure🤖 Generated with Claude Code