chore(ui): remove debug console.log from core components, fix 2 log levels#7882
Closed
jeffa-block wants to merge 2 commits intoblock:mainfrom
Closed
chore(ui): remove debug console.log from core components, fix 2 log levels#7882jeffa-block wants to merge 2 commits intoblock:mainfrom
jeffa-block wants to merge 2 commits intoblock:mainfrom
Conversation
Remove debug logging from 7 core UI files: - ConfigContext.tsx: upgrade misclassified console.log to console.error for extension list fetch errors - AnnouncementModal.tsx: upgrade console.log to console.warn for expected announcement load failures - ModelAndProviderContext.tsx: remove fallback check trace - ChatInput.tsx: remove 'No model or provider found' trace - useCostTracking.ts: remove model change tracking trace - McpAppRenderer.tsx: remove MCP app notification forwarding trace - recipe/index.ts: remove deeplink decode trace Two log level corrections (log→error, log→warn) improve signal quality. All other console.error/warn calls preserved.
Collaborator
|
Squashed into #8142 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Core UI components contain debug
console.logstatements that trace internal state to DevTools. Two of these are misclassified — errors logged asconsole.loginstead ofconsole.error/console.warn.What
Changes across 7 files:
ConfigContext.tsxconsole.log→console.errorAnnouncementModal.tsxconsole.log→console.warnModelAndProviderContext.tsxChatInput.tsxuseCostTracking.tsMcpAppRenderer.tsxrecipe/index.tsHow to review
7 files, 4 insertions (log level fixes), 16 deletions. The two log level corrections improve signal quality — actual errors now surface at the correct severity.
Testing
npm run buildinui/desktop— no compile errors