chore(ui): remove debug console.log from settings and extension components#7881
Closed
jeffa-block wants to merge 3 commits intoblock:mainfrom
Closed
chore(ui): remove debug console.log from settings and extension components#7881jeffa-block wants to merge 3 commits intoblock:mainfrom
jeffa-block wants to merge 3 commits intoblock:mainfrom
Conversation
…nents Remove 16 debug console.log statements across 6 settings-related files: - UpdateSection.tsx: update state and updater event traces - ExtensionItem.tsx: toggle failure revert trace - deeplink.ts: env var redirect and direct activation traces - PermissionModal.tsx: success confirmation trace - ExtensionModal.tsx: form validation trace - ExtensionInstallModal.tsx: full install flow traces (7 statements) All console.error calls for actual error handling are preserved.
Collaborator
|
Squashed into #8142 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Settings and extension-related components contain 16 debug
console.logstatements that trace internal state (update checks, toggle events, deeplink routing, form validation, install flow) to DevTools in production builds.What
Remove debug
console.logfrom 6 files:UpdateSection.tsxExtensionItem.tsxdeeplink.tsPermissionModal.tsxExtensionModal.tsxExtensionInstallModal.tsxAll
console.errorcalls for actual error handling are preserved.How to review
6 files, 16 deletions. Each removal is a standalone
console.log— no logic changes.Testing
npm run buildinui/desktop— no compile errors