chore(ui): remove debug console.log from SessionSharingSection#7880
Closed
jeffa-block wants to merge 1 commit intoblock:mainfrom
Closed
chore(ui): remove debug console.log from SessionSharingSection#7880jeffa-block wants to merge 1 commit intoblock:mainfrom
jeffa-block wants to merge 1 commit intoblock:mainfrom
Conversation
Remove log that leaked GOOSE_BASE_URL_SHARE env config value to DevTools.
Collaborator
|
Squashed into #8142 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SessionSharingSection.tsxlogs theGOOSE_BASE_URL_SHAREenvironment variable value to the browser DevTools console on every render. This leaks configuration to anyone with DevTools open.What
Remove 1
console.logstatement fromui/desktop/src/components/settings/sessions/SessionSharingSection.tsx.How to review
Single file, 1 line deleted. The
envBaseUrlSharevariable is still read and used — only the debug log is removed.Testing
No runtime impact. Session sharing settings continue to work as before.