fix: upgrade extensions config save failure log from debug to warn#7876
Closed
jeffa-block wants to merge 1 commit intoblock:mainfrom
Closed
fix: upgrade extensions config save failure log from debug to warn#7876jeffa-block wants to merge 1 commit intoblock:mainfrom
jeffa-block wants to merge 1 commit intoblock:mainfrom
Conversation
Failing to save extensions config is a meaningful error that should be visible in logs. The previous debug-level log (with a TODO asking why it was debug) meant this failure was silently swallowed in production. tracing::warn is already imported and used in this file.
Collaborator
|
Squashed into #8142 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
save_extensions_map()inextensions.rscatches config save failures but logs them atdebuglevel — effectively swallowing them in production. There's even a TODO from a maintainer asking why:Failing to persist extension configuration is a meaningful error that users and developers should see in logs.
What
tracing::debug!→tracing::warn!for the config save failuretracing::warnis already imported and used elsewhere in this file.How to review
2 lines changed in 1 file. Confirm
warnis the right level (noterror) — the app can continue functioning even if config save fails, but users should know their changes may not have persisted.Testing
cargo check -p goose— compiles cleanly