chore(ui): remove debug console.log statements from App.tsx#7874
Closed
jeffa-block wants to merge 1 commit intoblock:mainfrom
Closed
chore(ui): remove debug console.log statements from App.tsx#7874jeffa-block wants to merge 1 commit intoblock:mainfrom
jeffa-block wants to merge 1 commit intoblock:mainfrom
Conversation
Remove 7 console.log statements used for development-time debugging of IPC events and lifecycle signals. All console.error calls for actual error handling are preserved. Removed logs: - reactReady signal notification - Keyboard shortcut setup trace - View change request logging - New-chat event trace - Initial message IPC event logging (received/processing/duplicate) No behavioural changes — these logs were only visible in DevTools and provided no value in production.
Collaborator
|
Squashed into #8142 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
App.tsx contains 7
console.logstatements used for development-time debugging of IPC events and lifecycle signals. These appear in DevTools in production builds and provide no value to end users.What
Remove all
console.logcalls fromui/desktop/src/App.tsx:All
console.errorcalls for actual error handling are preserved.Also removes a now-empty
else ifbranch that only contained a removed log statement.How to review
Single file, 15 lines deleted. Verify each removal was a
console.log(notconsole.error), and that no logic was affected.Testing
npm run buildinui/desktop— no compile errors