Skip to content

fix: replace any with proper SVG types in icon components#7873

Merged
DOsinga merged 3 commits intoblock:mainfrom
jeffa-block:jeffa/svg-icon-type-safety
Mar 26, 2026
Merged

fix: replace any with proper SVG types in icon components#7873
DOsinga merged 3 commits intoblock:mainfrom
jeffa-block:jeffa/svg-icon-type-safety

Conversation

@jeffa-block
Copy link
Copy Markdown
Contributor

@jeffa-block jeffa-block commented Mar 14, 2026

Why

The ChevronRight and Geese icon components use [key: string]: any to pass through SVG props. This bypasses TypeScript's type checking entirely. Using React.SVGProps<SVGSVGElement> provides the same pass-through behaviour with full type safety.

What

Replace [key: string]: any with React.SVGProps<SVGSVGElement> in 2 icon component interfaces:

  • ui/desktop/src/components/icons/ChevronRight.tsx
  • ui/desktop/src/components/icons/Geese.tsx

Also removes the eslint-disable-next-line comments that were suppressing the any type warnings.

How to review

2 files, ~1 line change each. Type-only change — no runtime behaviour change. The extends React.SVGProps<SVGSVGElement> pattern is standard React for SVG wrapper components.

Testing

  • npm run build — compiles without errors (type-only change)
  • Existing usage of these components is unchanged

@jeffa-block
fix: replace any with proper SVG types in icon components
b7e7e8c 
Replace `[key: string]: any` with `React.SVGProps<SVGSVGElement>`
in ChevronRight and Geese icon components. This provides the same
SVG prop pass-through behaviour with full TypeScript type safety.

Also removes the eslint-disable-next-line comments that were
suppressing the any type warnings.
@jeffa-block
fix: use ComponentPropsWithoutRef to avoid SVGSVGElement lint error
86c8253
@jeffa-block
fix: use type alias instead of empty interface for Geese props
5e7bef0
@DOsinga DOsinga marked this pull request as ready for review March 26, 2026 21:22
DOsinga
DOsinga approved these changes Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@DOsinga DOsinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DOsinga DOsinga added this pull request to the merge queue Mar 26, 2026
Merged via the queue into block:main with commit b1c2512 Mar 26, 2026
20 checks passed
michaelneale added a commit that referenced this pull request Mar 26, 2026
@michaelneale
Merge branch 'main' into goose/issue-7449
a8ec573 
* main: (337 commits)
  fix: replace panics with user-friendly errors in CLI session builder (#7901)
  fix: read GOOSE_CONTEXT_LIMIT from config.yaml, not just env vars (#7900)
  fix: deliver truncation notice as separate content block (#7899)
  fix: use platform-appropriate commands in developer extension instructions (#7898)
  fix: replace any with proper SVG types in icon components (#7873)
  chore: remove debug console.log statements, stale comments, and dead code (#8142)
  feat: Gemini OAuth provider (#8129)
  chore(deps): bump picomatch from 2.3.1 to 2.3.2 in /documentation (#8123)
  feat: show installed skills in UI (#7910)
  fix(deps): gate keyring platform features behind target-specific deps (#8039)
  chore(deps): bump yaml from 2.8.2 to 2.8.3 in /evals/open-model-gym/suite (#8124)
  fix: strip message wrapper in CLI session title generation (#7996)
  fix(providers): fall back to configured models when models endpoint fetch fails (#7530)
  chore(deps): bump brace-expansion from 5.0.3 to 5.0.5 in /evals/open-model-gym/suite (#8139)
  fix: prevent Ollama provider from hanging on tool-calling requests (#7723)
  fix: VMware Tanzu Platform provider - bug fixes, streaming, UI improvements (#8126)
  feat: allow GOOSE_CLI_SHOW_THINKING to be set in config.yaml (#8097)
  fix: GitHub Copilot auth fails to open browser in Desktop app (#6957) (#8019)
  fix(ci): produce .tar.gz archives for Zed ACP registry compatibility (#8054)
  feat: add GOOSE_SHOW_FULL_OUTPUT config to disable tool output truncation (#7919)
  ...

# Conflicts:
#	crates/goose/src/providers/formats/openai.rs
michaelneale added a commit that referenced this pull request Mar 30, 2026
@michaelneale
Merge remote-tracking branch 'origin/main' into micn/mesh-llm
4811814 
* origin/main: (63 commits)
  remove name from blog post (#8157)
  fix: use `overflow: clip` to not disrupt sticky ToC (#8158)
  chore(deps): bump path-to-regexp from 0.1.12 to 0.1.13 in /documentation (#8161)
  chore(deps): bump node-forge from 1.3.2 to 1.4.0 in /documentation (#8145)
  refactor: goose-acp-server -> goose binary for TUI (#8155)
  fix "View as Markdown" feature not working (#8160)
  feat(tui): UI improvements for messages, tool calls, text entry, etc (#8156)
  feat(desktop): add i18n infrastructure with react-intl (#8105)
  fix(tui): ordering of messages (#8144)
  fix: extension command with quotes in  cli (#8150)
  chore(aaif): Use Azure Artifact Signing for Windows (#8116)
  chore(aaif): Switch macOS code signing (#8076)
  Remove unused tool call json in logs (#8147)
  feat(tui): tab expand tool calls cleanly (#8136)
  fix: replace panics with user-friendly errors in CLI session builder (#7901)
  fix: read GOOSE_CONTEXT_LIMIT from config.yaml, not just env vars (#7900)
  fix: deliver truncation notice as separate content block (#7899)
  fix: use platform-appropriate commands in developer extension instructions (#7898)
  fix: replace any with proper SVG types in icon components (#7873)
  chore: remove debug console.log statements, stale comments, and dead code (#8142)
  ...
hydrosquall pushed a commit to hydrosquall/goose that referenced this pull request Mar 31, 2026
@jeffa-block @hydrosquall
fix: replace any with proper SVG types in icon components (block#7873)
2422245 
Signed-off-by: Cameron Yick <[email protected]>
blackgirlbytes pushed a commit that referenced this pull request Apr 2, 2026
@michaelneale
Merge branch 'main' into goose/issue-7449
60ae4d2 
* main: (337 commits)
  fix: replace panics with user-friendly errors in CLI session builder (#7901)
  fix: read GOOSE_CONTEXT_LIMIT from config.yaml, not just env vars (#7900)
  fix: deliver truncation notice as separate content block (#7899)
  fix: use platform-appropriate commands in developer extension instructions (#7898)
  fix: replace any with proper SVG types in icon components (#7873)
  chore: remove debug console.log statements, stale comments, and dead code (#8142)
  feat: Gemini OAuth provider (#8129)
  chore(deps): bump picomatch from 2.3.1 to 2.3.2 in /documentation (#8123)
  feat: show installed skills in UI (#7910)
  fix(deps): gate keyring platform features behind target-specific deps (#8039)
  chore(deps): bump yaml from 2.8.2 to 2.8.3 in /evals/open-model-gym/suite (#8124)
  fix: strip message wrapper in CLI session title generation (#7996)
  fix(providers): fall back to configured models when models endpoint fetch fails (#7530)
  chore(deps): bump brace-expansion from 5.0.3 to 5.0.5 in /evals/open-model-gym/suite (#8139)
  fix: prevent Ollama provider from hanging on tool-calling requests (#7723)
  fix: VMware Tanzu Platform provider - bug fixes, streaming, UI improvements (#8126)
  feat: allow GOOSE_CLI_SHOW_THINKING to be set in config.yaml (#8097)
  fix: GitHub Copilot auth fails to open browser in Desktop app (#6957) (#8019)
  fix(ci): produce .tar.gz archives for Zed ACP registry compatibility (#8054)
  feat: add GOOSE_SHOW_FULL_OUTPUT config to disable tool output truncation (#7919)
  ...

# Conflicts:
#	crates/goose/src/providers/formats/openai.rs
@github-actions github-actions bot mentioned this pull request Apr 2, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DOsinga DOsinga DOsinga approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeffa-block @DOsinga