fix: write to real file if config.yaml is symlink by lsytj0413 · Pull Request #7669 · block/goose

lsytj0413 · 2026-03-05T06:26:19Z

Summary

If config.yaml is a symlink, rename to the real file

Type of Change

AI Assistance

This PR was created or reviewed with AI assistance

Testing

Related Issues

Relates to #ISSUE_ID
Discussion: LINK (if any)

Fix: #6847

Screenshots/Demos (for UX changes)

Before:

After:

Signed-off-by: lsytj0413 <[email protected]>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b2a58ce465

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-05T06:30:26Z

crates/goose/src/config/base.rs

+        let mut path = self.config_path.clone();
+
+        // Follow symlinks so we update the target file without replacing the link itself.
+        const MAX_SYMLINK_HOPS: usize = 1;


Resolve full symlink chains before writing config

Limiting symlink resolution to a single hop causes save_values to fail for valid, non-cyclic setups where config.yaml points to another symlink (for example, when dotfile managers or environment overlays create a 2+ link chain). In that case set_param now returns "Too many symlink levels" instead of updating the real file, which is a functional regression for those users; this should follow the chain until a real file (or a detected cycle) rather than hard-capping at one hop.

Useful? React with 👍 / 👎.

jamadeo · 2026-03-06T14:41:58Z

crates/goose/src/config/base.rs

        load_init_config_from_workspace()
    }

+    fn config_write_target_path(&self) -> Result<PathBuf, ConfigError> {


The goal makes sense to me, but why not use fs::canonicalize?

Since the config_path may not exist, we should return it as the target_path in this scenario.

That makes sense. It just seems like symlink resolution is something we should let the OS do, not on our own in a loop. But I'm not sure there's a better way if we also want to preserve the creating of parent directories.

jamadeo · 2026-03-09T14:53:05Z

crates/goose/src/config/base.rs

        load_init_config_from_workspace()
    }

+    fn config_write_target_path(&self) -> Result<PathBuf, ConfigError> {


That makes sense. It just seems like symlink resolution is something we should let the OS do, not on our own in a loop. But I'm not sure there's a better way if we also want to preserve the creating of parent directories.

@angiejones

* origin/main: (21 commits) fix(ui-desktop): unify path resolution around GOOSE_PATH_ROOT (#7335) fix: pass OAuth scopes to DCR and extract granted_scopes from token response (#7571) fix: write to real file if config.yaml is symlink (#7669) fix: preserve pairings when stopping gateway (#7733) fix: reduce server log verbosity — skip session in instrument, defaul… (#7729) fix: provider test infrastructure (#7738) fix: sanitize streamable HTTP extension names derived from URLs (#7740) refactor: derive GooseMode string conversions with strum (#7706) docs: Add Spraay Batch Payments MCP Extension Tutorial (#7525) fix: flake.nix (#7224) delete goose web (#7696) Add @angiejones as CODEOWNER for documentation (#7711) Add MLflow integration guide (#7563) docs: LM Studio availability (#7698) feat: add Avian as an LLM provider (#7561) Adds `linux-mcp-server` to the goose registry (#6979) fix: add #[serde(default)] to description field on 4 ExtensionConfig variants (#7708) feat: combine TUI UX from alexhancock/tui-goodness with publishing config from jackamadeo/package-tui (#7683) chore: cleanup old sandbox (#7700) Correct windows artifact (#7699) ...

@angiejones

* origin/main: (21 commits) fix(ui-desktop): unify path resolution around GOOSE_PATH_ROOT (#7335) fix: pass OAuth scopes to DCR and extract granted_scopes from token response (#7571) fix: write to real file if config.yaml is symlink (#7669) fix: preserve pairings when stopping gateway (#7733) fix: reduce server log verbosity — skip session in instrument, defaul… (#7729) fix: provider test infrastructure (#7738) fix: sanitize streamable HTTP extension names derived from URLs (#7740) refactor: derive GooseMode string conversions with strum (#7706) docs: Add Spraay Batch Payments MCP Extension Tutorial (#7525) fix: flake.nix (#7224) delete goose web (#7696) Add @angiejones as CODEOWNER for documentation (#7711) Add MLflow integration guide (#7563) docs: LM Studio availability (#7698) feat: add Avian as an LLM provider (#7561) Adds `linux-mcp-server` to the goose registry (#6979) fix: add #[serde(default)] to description field on 4 ExtensionConfig variants (#7708) feat: combine TUI UX from alexhancock/tui-goodness with publishing config from jackamadeo/package-tui (#7683) chore: cleanup old sandbox (#7700) Correct windows artifact (#7699) ...

@angiejones

…e-issue * origin/main: fix(ui-desktop): unify path resolution around GOOSE_PATH_ROOT (#7335) fix: pass OAuth scopes to DCR and extract granted_scopes from token response (#7571) fix: write to real file if config.yaml is symlink (#7669) fix: preserve pairings when stopping gateway (#7733) fix: reduce server log verbosity — skip session in instrument, defaul… (#7729) fix: provider test infrastructure (#7738) fix: sanitize streamable HTTP extension names derived from URLs (#7740) refactor: derive GooseMode string conversions with strum (#7706) docs: Add Spraay Batch Payments MCP Extension Tutorial (#7525) fix: flake.nix (#7224) delete goose web (#7696) Add @angiejones as CODEOWNER for documentation (#7711) Add MLflow integration guide (#7563) docs: LM Studio availability (#7698) feat: add Avian as an LLM provider (#7561) Adds `linux-mcp-server` to the goose registry (#6979) fix: add #[serde(default)] to description field on 4 ExtensionConfig variants (#7708)

@DOsinga

* main: (45 commits) fix: resolve {{ recipe_dir }} in nested sub-recipe paths during secret discovery (#7797) Add @DOsinga as CODEOWNER for documentation (#7799) feat: Add summarize tool for deterministic reads (#7054) fix(api): use camelCase in CallToolResponse and add type discriminators to ContentBlock (#7487) feat: ACP providers for claude code and codex (#6605) chore(deps): bump express-rate-limit from 8.2.1 to 8.3.0 in /evals/open-model-gym/mcp-harness (#7703) feat(openai): capture reasoning summaries from responses API (#7375) Fix some dependencies (#7794) fix: improve keyring availability error detection (#7766) feat: add MiniMax provider with Anthropic-compatible API (#7640) feat: add Tensorix as a declarative provider (#7712) fix(security): remove insecure default secret from GOOSE_EXTERNAL_BACKEND (#7783) refactor: Convert Tanzu provider to declarative JSON config (#7124) replaces https://github.com/block/goose/pull/7340/changes (#7786) feat(summon): make skill supporting files individually loadable via load() (#7583) Keep toast open on failed extension (#7771) fix(ui-desktop): unify path resolution around GOOSE_PATH_ROOT (#7335) fix: pass OAuth scopes to DCR and extract granted_scopes from token response (#7571) fix: write to real file if config.yaml is symlink (#7669) fix: preserve pairings when stopping gateway (#7733) ...

@DOsinga

* main: (69 commits) fix: resolve {{ recipe_dir }} in nested sub-recipe paths during secret discovery (#7797) Add @DOsinga as CODEOWNER for documentation (#7799) feat: Add summarize tool for deterministic reads (#7054) fix(api): use camelCase in CallToolResponse and add type discriminators to ContentBlock (#7487) feat: ACP providers for claude code and codex (#6605) chore(deps): bump express-rate-limit from 8.2.1 to 8.3.0 in /evals/open-model-gym/mcp-harness (#7703) feat(openai): capture reasoning summaries from responses API (#7375) Fix some dependencies (#7794) fix: improve keyring availability error detection (#7766) feat: add MiniMax provider with Anthropic-compatible API (#7640) feat: add Tensorix as a declarative provider (#7712) fix(security): remove insecure default secret from GOOSE_EXTERNAL_BACKEND (#7783) refactor: Convert Tanzu provider to declarative JSON config (#7124) replaces https://github.com/block/goose/pull/7340/changes (#7786) feat(summon): make skill supporting files individually loadable via load() (#7583) Keep toast open on failed extension (#7771) fix(ui-desktop): unify path resolution around GOOSE_PATH_ROOT (#7335) fix: pass OAuth scopes to DCR and extract granted_scopes from token response (#7571) fix: write to real file if config.yaml is symlink (#7669) fix: preserve pairings when stopping gateway (#7733) ...

fix: write to real file if config.yaml is symlink

b2a58ce

Signed-off-by: lsytj0413 <[email protected]>

chatgpt-codex-connector bot reviewed Mar 5, 2026

View reviewed changes

jamadeo self-assigned this Mar 5, 2026

jamadeo reviewed Mar 6, 2026

View reviewed changes

jamadeo approved these changes Mar 9, 2026

View reviewed changes

jamadeo enabled auto-merge March 9, 2026 14:54

jamadeo added this pull request to the merge queue Mar 9, 2026

Merged via the queue into block:main with commit 7030645 Mar 9, 2026
19 checks passed

github-actions bot mentioned this pull request Mar 10, 2026

chore(release): release version 1.28.0 (minor) #7780

Open

lsytj0413 deleted the fix-6847 branch March 10, 2026 01:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: write to real file if config.yaml is symlink#7669

fix: write to real file if config.yaml is symlink#7669
jamadeo merged 1 commit intoblock:mainfrom
lsytj0413:fix-6847

lsytj0413 commented Mar 5, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 5, 2026

Uh oh!

jamadeo Mar 6, 2026

Uh oh!

lsytj0413 Mar 7, 2026

Uh oh!

jamadeo Mar 9, 2026

Uh oh!

jamadeo Mar 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

lsytj0413 commented Mar 5, 2026

Summary

Type of Change

AI Assistance

Testing

Related Issues

Screenshots/Demos (for UX changes)

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

jamadeo Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

lsytj0413 Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

jamadeo Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

jamadeo Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants