Conversation
DOsinga
approved these changes
Mar 11, 2026
Collaborator
DOsinga
left a comment
There was a problem hiding this comment.
this feels like it might break things but it also is strictly better. so let's get it in
8db09a9 to
485ca97
Compare
…reasoning/thinking display
Change MessageContent::reasoning() to produce Thinking instead of Reasoning, so the Reasoning variant never enters conversations. The OpenAI format's format_messages now also maps Thinking content back to reasoning_content for the API. On the UI side, rename getReasoningContent to getThinkingContent and only handle the 'thinking' content type since 'reasoning' will no longer appear in messages from the server.
The Reasoning variant is no longer needed since reasoning() now produces Thinking content. Old sessions with serialized Reasoning content are handled by the custom deserializer which maps 'reasoning' type to 'thinking' during deserialization. Removes ReasoningContent struct, Reasoning enum variant, as_reasoning(), and all Reasoning match arms across provider formats, agent, context management, CLI output, and OpenAPI schema.
All call sites now use MessageContent::thinking(text, "") and as_thinking() directly, completing the Reasoning→Thinking unification. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
…back - Add thinking/redacted_thinking support to Anthropic streaming handler: thinking deltas are streamed incrementally for real-time UI display, with the complete block (including signature) yielded at content_block_stop - UI pushMessage merges thinking chunks in-place, replacing with the final signed block when it arrives - Drop test_parse_thinking_response test per review feedback - Remove redundant Array.isArray branch in ToolCallArguments Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
905e463 to
c033cc9
Compare
Co-Authored-By: Claude Opus 4.6 <[email protected]>
jh-block
added a commit
that referenced
this pull request
Mar 17, 2026
…ct-ui * origin/main: Improve the formatting of tool calls, show thinking, treat Reasoning and Thinking as the same thing (sorry Kant) (#7626) don't imply running builds all the time in AGENTS.md (#7865) fix: unregister goosed child process's listener (#7956) # Conflicts: # ui/desktop/src/api/index.ts
rabi
added a commit
to rabi/goose
that referenced
this pull request
Mar 18, 2026
The thinking delta handling was proposed in this PR initially, but block#7626 merged first. This adds certain optimizations proposed earlier in this PR. As thinking_delta is yielded and stored individually, then the complete block re-emitted at content_block_stop — N+1 entries per thinking block end up in both database and session memory. Streaming partial thinking deltas serves no purpose: without a signature they cannot be sent back to the API (format_messages drops them), and the UI renders thinking as a complete block rather than incrementally. Emit once at content_block_stop. Replace JSON delta comparisons with typed ContentDelta enum. Add streaming tests. Change-Id: Id42262e30f1eea8d24f1ddb87381395714a91821 Signed-off-by: Rabi Mishra <[email protected]>
rabi
added a commit
to rabi/goose
that referenced
this pull request
Mar 18, 2026
The thinking delta handling was proposed in this PR initially, but block#7626 merged first. This adds certain optimizations proposed earlier in this PR. As thinking_delta is yielded and stored individually, then the complete block re-emitted at content_block_stop — N+1 entries per thinking block end up in both database and session memory. Streaming partial thinking deltas serves no purpose: without a signature they cannot be sent back to the API (format_messages drops them), and the UI renders thinking as a complete block rather than incrementally. Emit once at content_block_stop. Replace JSON delta comparisons with typed ContentDelta enum. Add streaming tests. Change-Id: Id42262e30f1eea8d24f1ddb87381395714a91821 Signed-off-by: Rabi Mishra <[email protected]>
jh-block
added a commit
to rabi/goose
that referenced
this pull request
Mar 18, 2026
* main: (32 commits) Revert message flush & test (block#7966) docs: add Remote Access section with Telegram Gateway documentation (block#7955) fix: update webmcp blog post metadata image URL (block#7967) fix: clean up OAuth token cache on provider deletion (block#7908) fix: hard-coded tool call id in code mode callback (block#7939) Fix SSE parsers to accept optional space after data: prefix (block#7929) docs: add GOOSE_INPUT_LIMIT to config-files.md (block#7961) Add WebMCP for Beginners blog post (block#7957) Fix download manager (block#7933) Improve the formatting of tool calls, show thinking, treat Reasoning and Thinking as the same thing (sorry Kant) (block#7626) don't imply running builds all the time in AGENTS.md (block#7865) fix: unregister goosed child process's listener (block#7956) feat: adversarial agent for preventing leaking of info and more (block#7948) Update contributing.md (block#7927) docs: add credit balance monitoring section (block#7952) docs: add Cerebras provider to supported providers list (block#7953) docs: add TUI client documentation to ACP clients guide (block#7950) fix: removed double dash in pnpm command (block#7951) docs: polish ACP docs (block#7946) claude adaptive thinking (block#7944) ...
lifeizhou-ap
added a commit
that referenced
this pull request
Mar 20, 2026
* main: (22 commits) feat: add gemini-acp provider, update docs on subscription models + improvements to codex (#8000) fix(openai): use Responses API for gpt-5.4 (#7982) Remove lead/worker provider (#7989) chore(release): release version 1.28.0 (#7991) Fix empty tool results from resource content (e.g. auto visualiser) (#7866) Separate SSE streaming from POST work submission (#7834) fix: include token usage in Databricks streaming responses (#7959) Optimize tool summarization (#7938) fix: overwrite the deprecated googledrive extension config (#7974) refactor: remove unnecessary Arc<Mutex> from tool execution pipeline (#7979) Revert message flush & test (#7966) docs: add Remote Access section with Telegram Gateway documentation (#7955) fix: update webmcp blog post metadata image URL (#7967) fix: clean up OAuth token cache on provider deletion (#7908) fix: hard-coded tool call id in code mode callback (#7939) Fix SSE parsers to accept optional space after data: prefix (#7929) docs: add GOOSE_INPUT_LIMIT to config-files.md (#7961) Add WebMCP for Beginners blog post (#7957) Fix download manager (#7933) Improve the formatting of tool calls, show thinking, treat Reasoning and Thinking as the same thing (sorry Kant) (#7626) ...
elijahsgh
pushed a commit
to elijahsgh/goose
that referenced
this pull request
Mar 21, 2026
…and Thinking as the same thing (sorry Kant) (block#7626) Co-authored-by: Claude Opus 4.6 <[email protected]> Signed-off-by: esnyder <[email protected]>
elijahsgh
pushed a commit
to elijahsgh/goose
that referenced
this pull request
Mar 21, 2026
…and Thinking as the same thing (sorry Kant) (block#7626) Co-authored-by: Claude Opus 4.6 <[email protected]> Signed-off-by: esnyder <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
formatValuehelper, render expanded values as<pre>instead of MarkdownContent<details>to inline italic textMessageContent::Reasoningvariant —MessageContent::reasoning()now producesThinkingcontent, so the UI only ever seesthinkingtypereasoningcontent are migrated tothinkingduring deserializationReasoningContentstruct,as_reasoning(), and allReasoningmatch arms across provider formats, agent, context management, CLI output, and OpenAPI schemagetReasoningContent→getThinkingContent, only handlesthinkingcontent type