fix: add checksum verification and harden archive extraction in CLI self-update by fresh3nough · Pull Request #7575 · block/goose

fresh3nough · 2026-02-27T18:01:46Z

Summary

Replace the shell-out-to-curl-and-bash self-update mechanism with a native Rust implementation that adds SHA-256 checksum verification and hardens archive extraction against path traversal attacks (zip-slip/tar-slip).

Checksum verification:

After downloading the release archive, the update command now computes its SHA-256 digest and attempts to download a corresponding <asset>.sha256 file from the same release
If the checksum file exists, the digest is verified and the update aborts on mismatch
If no checksum file is published yet (current state), a warning is printed and the update proceeds gracefully
The CI pipeline (build-cli.yml) now generates .sha256 files alongside each archive, and release.yml/canary.yml upload them as release assets

Extraction hardening:

Tar extraction (tar.bz2, tar.gz) now iterates entries individually, validating each path rejects absolute paths and .. components before unpacking
Zip extraction uses enclosed_name() for path sanitization and iterates entries individually instead of using bulk extract()

Format flexibility:

Added flate2 dependency and extract_tar_gz() to support .tar.gz/.tgz archives alongside the existing .tar.bz2 and .zip formats
The extract_archive() dispatcher selects the correct extractor based on file extension

Type of Change

Security fix
Bug fix
Tests
Build / Release

AI Assistance

This PR was created or reviewed with AI assistance

Testing

15 unit tests added covering:
- SHA-256 digest computation
- Path traversal rejection (absolute paths, .. components)
- Safe path acceptance
- tar.gz extraction round-trip
- tar.bz2 path traversal rejection with raw crafted malicious archive
- Archive format dispatch (unsupported format error)
- Binary location in various archive layouts
- Binary replacement
All tests pass: cargo test -p goose-cli -- update (15/15)
cargo clippy --all-targets -- -D warnings passes clean
cargo fmt applied

Steps to reproduce the fix:

source bin/activate-hermit
cargo build -p goose-cli
cargo test -p goose-cli -- update
cargo clippy -p goose-cli --all-targets -- -D warnings

Related Issues

Closes #7552

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cfd1604ba5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

crates/goose-cli/src/commands/update.rs

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b79c0f8473

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

crates/goose-cli/src/commands/update.rs

…elf-update Addresses block#7552: CLI self-update lacked signature/checksum verification and archive extraction was vulnerable to path traversal. Changes: - Replace shell-out update with native Rust implementation - Add SHA-256 checksum verification against <asset>.sha256 files (graceful fallback when no checksum file is published) - Harden tar extraction: iterate entries individually with path validation to prevent zip-slip/tar-slip attacks - Harden zip extraction: use enclosed_name() for path sanitization - Add tar.gz/tgz support via flate2 for format flexibility - Generate SHA-256 checksum files in CI build pipeline - Upload checksum files alongside release archives - Add comprehensive tests for all new functionality Signed-off-by: fresh3nough <[email protected]>

jamadeo · 2026-03-11T17:46:22Z

hey @fresh3nough, thanks for this. #7148 moved the update to a rust implementation, but the digest proposal from your PR is still relevant. #7097 adds what we need on the build side, so we should probably go with those signatures. I'll close this PR, but the goal here is good and if you're interested, maybe you could look into verifying these using the https://github.com/sigstore/sigstore-rs crate?

fresh3nough · 2026-03-11T17:47:43Z

@jamadeo thanks, yes sir, i will take a look fs

fresh3nough · 2026-03-11T21:33:43Z

Hey @tlongwell-block (and thanks for the thoughtful close!),

Opened a new PR with the exact direction you suggested: #7818

Kept the hardened archive extraction (zip-slip/tar-slip protection) from this PR.
Switched from custom SHA-256 + .sha256 files to full Sigstore provenance verification using the sigstore-verification crate (wraps sigstore-rs).
Leverages the SLSA attestations that Add SLSA build provenance attestations to release workflows #7097 added to release/canary/nightly workflows.
Uses the Rust update foundation from fix(cli): replace shell-based update with native Rust implementation #7148.

Happy to iterate!

chatgpt-codex-connector bot reviewed Feb 27, 2026

View reviewed changes

crates/goose-cli/src/commands/update.rs Outdated Show resolved Hide resolved

crates/goose-cli/src/commands/update.rs Outdated Show resolved Hide resolved

fresh3nough force-pushed the fix/update-checksum-verification-7552 branch from cfd1604 to b79c0f8 Compare February 27, 2026 18:10

chatgpt-codex-connector bot reviewed Feb 27, 2026

View reviewed changes

crates/goose-cli/src/commands/update.rs Show resolved Hide resolved

fresh3nough force-pushed the fix/update-checksum-verification-7552 branch from b79c0f8 to 43705cf Compare February 27, 2026 19:59

DOsinga assigned jamadeo Mar 9, 2026

jamadeo closed this Mar 11, 2026

alexhancock mentioned this pull request Mar 11, 2026

CLI self-update lacks signature/checksum verification; archive extraction should be hardened #7552

Closed

fresh3nough mentioned this pull request Mar 11, 2026

feat(cli): add Sigstore/SLSA provenance verification to Rust self-update #7818

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: add checksum verification and harden archive extraction in CLI self-update#7575

fix: add checksum verification and harden archive extraction in CLI self-update#7575
fresh3nough wants to merge 1 commit intoblock:mainfrom
fresh3nough:fix/update-checksum-verification-7552

fresh3nough commented Feb 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

jamadeo commented Mar 11, 2026

Uh oh!

fresh3nough commented Mar 11, 2026

Uh oh!

fresh3nough commented Mar 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

fresh3nough commented Feb 27, 2026

Summary

Type of Change

AI Assistance

Testing

Related Issues

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

jamadeo commented Mar 11, 2026

Uh oh!

fresh3nough commented Mar 11, 2026

Uh oh!

fresh3nough commented Mar 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants