gpt 5-3-Codex model support in databricks#7516
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 406428bb9b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| fn is_responses_model(model_name: &str) -> bool { | ||
| let normalized = model_name.to_ascii_lowercase(); | ||
| normalized.contains("codex") |
There was a problem hiding this comment.
Switching to the Responses endpoint based on normalized.contains("codex") causes incorrect routing for Databricks because this provider treats model_name as a serving endpoint name (see fetch_supported_models returning endpoint.name), not a guaranteed model-family identifier. Any endpoint whose name happens to include codex will now be forced to serving-endpoints/responses, and codex-backed endpoints without that substring will still use /invocations, so requests can be sent to the wrong API path despite valid endpoint configuration.
Useful? React with 👍 / 👎.
2 participants
Codex models only support the new responses API.
Still using a simple check based on if the model contains codex, but should be good as an initial unblocker. 5-2-codex wasn't working either.