docs: update Claude Code approve behavior and model list in cli-providers guide#7448
Merged
codefromthecrypt merged 2 commits intomainfrom Mar 4, 2026
Merged
docs: update Claude Code approve behavior and model list in cli-providers guide#7448codefromthecrypt merged 2 commits intomainfrom
codefromthecrypt merged 2 commits intomainfrom
Conversation
3 tasks
Contributor
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13d21d2d37
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| | `auto` | `--dangerously-skip-permissions` | Bypasses all permission prompts | | ||
| | `smart-approve` | `--permission-mode acceptEdits` | Auto-accepts edits, prompts for other actions | | ||
| | `approve` | Not supported | Returns an error | | ||
| | `approve` | `--permission-prompt-tool stdio` | Routes permission checks through the control protocol | |
There was a problem hiding this comment.
This row documents approve as supported via --permission-prompt-tool stdio, but in the same commit tree the Claude Code provider still rejects GooseMode::Approve with a ProviderError in crates/goose/src/providers/claude_code.rs (apply_permission_flags, lines 296-303). Users who follow this guide and set GOOSE_MODE=approve will hit an immediate runtime error, so the docs now describe behavior that the implementation does not provide.
Useful? React with 👍 / 👎.
jamadeo
approved these changes
Feb 26, 2026
| | `auto` | `--dangerously-skip-permissions` | Bypasses all permission prompts | | ||
| | `smart-approve` | `--permission-mode acceptEdits` | Auto-accepts edits, prompts for other actions | | ||
| | `approve` | Not supported | Returns an error | | ||
| | `approve` | `--permission-prompt-tool stdio` | Routes permission checks through the control protocol | |
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
force-pushed
the
adrian/claude-perms-docs
branch
from
13d21d2 to
9b4133d
Compare
Collaborator
Author
|
@jamadeo good catch, I forgot to update smart-approve which is effectively the same as approve now. While at it I corrected the model list as that wasn't updated prior, to save a PR |
codefromthecrypt
changed the title
blackgirlbytes
approved these changes
Mar 4, 2026
lifeizhou-ap
added a commit
that referenced
this pull request
Mar 4, 2026
* main: docs: add GOOSE_INPUT_LIMIT environment variable documentation (#7299) Merge platform/builtin extensions (#7630) Clean up stale references to removed components (#7644) fix: scope empty session reuse to current window to prevent session mixing (#7602) fix: prevent abort in local inference (#7633) Revert git patch for llama-cpp-2 (#7642) docs: update recipe usage step to reflect auto-submit behavior (#7639) docs: add guide for customizing the sidebar (#7638) docs: update Claude Code approve behavior and model list in cli-providers guide (#7448) fix: restore provider and extensions for LRU-evicted sessions (#7616) Restore goosed logging (#7622)
craigwalkeruk
pushed a commit
to craigwalkeruk/custom-goose
that referenced
this pull request
Mar 5, 2026
…ders guide (block#7448) Signed-off-by: Adrian Cole <[email protected]>
tlongwell-block
added a commit
that referenced
this pull request
Mar 5, 2026
* origin/main: (107 commits) Merge platform/builtin extensions (#7630) Clean up stale references to removed components (#7644) fix: scope empty session reuse to current window to prevent session mixing (#7602) fix: prevent abort in local inference (#7633) Revert git patch for llama-cpp-2 (#7642) docs: update recipe usage step to reflect auto-submit behavior (#7639) docs: add guide for customizing the sidebar (#7638) docs: update Claude Code approve behavior and model list in cli-providers guide (#7448) fix: restore provider and extensions for LRU-evicted sessions (#7616) Restore goosed logging (#7622) feat: return structured {stdout, stderr} from shell tool with output schema (#7604) Improve custom provider creation experience (#7541) fix(scheduler): schedules added via CLI showing up in UI (#7594) chore: openai reasoning model cleanup (#7529) chore(deps): bump hono from 4.12.1 to 4.12.3 in /evals/open-model-gym/mcp-harness (#7585) chore(deps): bump minimatch from 10.1.1 to 10.2.3 in /evals/open-model-gym/suite (#7498) chore(deps): bump swiper from 11.2.10 to 12.1.2 in /documentation (#7368) Better network failure error & antrhopic retry (#7595) feat: make the text bar persistent and add a queue for messages (#7560) fix: outdated clippy command in goosehints (#7590) ... # Conflicts: # Cargo.lock # Cargo.toml # crates/goose-server/src/commands/agent.rs # crates/goose-server/src/main.rs # crates/goose-server/src/routes/reply.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates cli-providers documentation to reflect that Claude Code now supports approve/smart-approve mode via
--permission-prompt-tool stdio. It also corrects model name driftType of Change
AI Assistance
Related Issues
Docs from #7420