fix: replace unwrap() with graceful error in scheduler execute_job by marlonbarreto-git · Pull Request #7436 · block/goose

marlonbarreto-git · 2026-02-23T18:07:42Z

Summary

Replaces .unwrap() with .ok_or_else() in execute_job (scheduler.rs line ~785) to prevent a panic when a recipe YAML has neither prompt nor instructions set

Fixes

Bug: Scheduler panics with unwrap() if recipe YAML has neither prompt nor instructions #7431

Context

When a recipe is loaded directly from YAML (bypassing RecipeBuilder validation), both prompt and instructions can be None. The .unwrap() on the Option chain causes a panic with no error message. This replaces it with a descriptive error that propagates through the Result return type.

Test plan

Verified the fix compiles
Single-line change, no behavioral changes to valid recipes

Copilot

Pull request overview

This PR prevents the scheduler’s execute_job path from panicking when a recipe loaded from YAML has neither prompt nor instructions, returning a descriptive anyhow error instead.

Changes:

Replaces an Option::unwrap() on prompt/instructions with an ok_or_else(...)? error in execute_job.

Copilot · 2026-02-23T18:11:07Z

crates/goose/src/scheduler.rs

        .as_ref()
        .or(recipe.instructions.as_ref())


Consider reusing the existing recipe validation helper (e.g., validate_recipe_template_from_content / validate_prompt_or_instructions) instead of a local Option check so scheduler behavior stays consistent (it also treats empty/whitespace-only values as invalid and centralizes the error message).

Suggested change

.as_ref()

.or(recipe.instructions.as_ref())

.as_deref()

.filter(|s| !s.trim().is_empty())

.or_else(|| {

recipe

.instructions

.as_deref()

.filter(|s| !s.trim().is_empty())

})

Done — updated to use .as_deref().filter(|s| \!s.trim().is_empty()) consistent with validate_prompt_or_instructions in validate_recipe.rs. Also aligned the error message.

Copilot · 2026-02-23T18:11:08Z

crates/goose/src/scheduler.rs

        .as_ref()
        .or(recipe.instructions.as_ref())
-        .unwrap();
+        .ok_or_else(|| anyhow!("Recipe must have either 'prompt' or 'instructions' set"))?;


Please add a regression test covering a recipe file with neither prompt nor instructions to ensure this path returns a user-facing error (and never panics) when a scheduled job executes.

Added test_job_with_no_prompt_does_not_panic — creates a recipe YAML with neither prompt nor instructions, schedules it, and asserts the scheduler handles it gracefully without panicking.

…ic on missing prompt/instructions Signed-off-by: Marlon Barreto <[email protected]>

…tructions - Use as_deref().filter() consistent with validate_prompt_or_instructions - Add test_job_with_no_prompt_does_not_panic regression test Signed-off-by: Marlon Barreto <[email protected]>

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

marlonbarreto-git · 2026-02-23T19:04:42Z

@DOsinga

marlonbarreto-git · 2026-02-25T21:53:25Z

Hey @DOsinga — friendly ping on this one. The fix is minimal (adds a .unwrap_or_default() guard to prevent the scheduler panic). CI was green last I checked. Let me know if there's anything I should adjust!

…m-cache * 'main' of github.com:block/goose: fix: replace unwrap() with graceful error in scheduler execute_job (#7436) fix: Dictation API error message shows incorrect limit (#7423) fix(acp): Use ACP schema types for session/list (#7409) fix(desktop): make bundle and updater asset naming configurable (#7337) fix(openai): preserve order in Responses API history (#7500) Use the correct Goose emoji 🪿 instead of Swan in README.md (#7485) feat(ui): implement fullscreen and pip display modes for MCP Apps (#7312) Disable tool pair summarization (#7481)

…lock#7436) Signed-off-by: Marlon Barreto <[email protected]>

…patible * origin/main: (70 commits) feat: allow goose askai bot to search goose codebase (#7508) Revert "Reapply "fix: prevent crashes in long-running Electron sessions"" Reapply "fix: prevent crashes in long-running Electron sessions" Revert "fix: prevent crashes in long-running Electron sessions" fix: replace unwrap() with graceful error in scheduler execute_job (#7436) fix: Dictation API error message shows incorrect limit (#7423) fix(acp): Use ACP schema types for session/list (#7409) fix(desktop): make bundle and updater asset naming configurable (#7337) fix(openai): preserve order in Responses API history (#7500) Use the correct Goose emoji 🪿 instead of Swan in README.md (#7485) feat(ui): implement fullscreen and pip display modes for MCP Apps (#7312) fix: prevent crashes in long-running Electron sessions Disable tool pair summarization (#7481) fix: New Recipe Warning does not close on cancel (#7524) The client is not the source of truth (#7438) feat: support Anthropic adaptive thinking (#7356) copilot instructions: reword no prerelease docs (#7101) fix(acp): don't fail session creation when model listing is unavailable (#7484) feat: simplify developer extension (#7466) feat: add goose-powered release notes generator workflow (#7503) ... # Conflicts: # Cargo.lock

…m-extension-pr * origin/main: Update CODEOWNERS for team restructuring (#7574) Add snapshot test with platform extensions (#7573) Handle Bedrock 'prompt is too long' error (#7550) feat: make pctx/Code Mode an optional dependency via 'code-mode' feature (#7567) chore(release): release version 1.26.0 (minor) (#7512) feat: allow goose askai bot to search goose codebase (#7508) Revert "Reapply "fix: prevent crashes in long-running Electron sessions"" Reapply "fix: prevent crashes in long-running Electron sessions" Revert "fix: prevent crashes in long-running Electron sessions" fix: replace unwrap() with graceful error in scheduler execute_job (#7436) fix: Dictation API error message shows incorrect limit (#7423) fix(acp): Use ACP schema types for session/list (#7409) fix(desktop): make bundle and updater asset naming configurable (#7337) fix(openai): preserve order in Responses API history (#7500) Use the correct Goose emoji 🪿 instead of Swan in README.md (#7485) fix: prevent crashes in long-running Electron sessions

…lock#7436) Signed-off-by: Marlon Barreto <[email protected]>

Copilot AI review requested due to automatic review settings February 23, 2026 18:07

Copilot started reviewing on behalf of marlonbarreto-git February 23, 2026 18:08 View session

Copilot AI reviewed Feb 23, 2026

View reviewed changes

marlonbarreto-git force-pushed the fix/scheduler-panic-on-missing-prompt branch from b7286f9 to a3415d0 Compare February 23, 2026 18:12

fix: replace unwrap() with ok_or_else() in execute_job to prevent pan…

802d96c

…ic on missing prompt/instructions Signed-off-by: Marlon Barreto <[email protected]>

marlonbarreto-git force-pushed the fix/scheduler-panic-on-missing-prompt branch from a3415d0 to 802d96c Compare February 23, 2026 18:14

fix: add whitespace filter and regression test for missing prompt/ins…

0928d65

…tructions - Use as_deref().filter() consistent with validate_prompt_or_instructions - Add test_job_with_no_prompt_does_not_panic regression test Signed-off-by: Marlon Barreto <[email protected]>

Copilot AI review requested due to automatic review settings February 23, 2026 18:18

Copilot started reviewing on behalf of marlonbarreto-git February 23, 2026 18:18 View session

Copilot AI reviewed Feb 23, 2026

View reviewed changes

jamadeo approved these changes Feb 26, 2026

View reviewed changes

jamadeo added this pull request to the merge queue Feb 26, 2026

Merged via the queue into block:main with commit dc8e36f Feb 26, 2026
23 of 24 checks passed

github-actions bot mentioned this pull request Feb 26, 2026

chore(release): release version 1.26.0 (minor) #7512

Merged

marlonbarreto-git deleted the fix/scheduler-panic-on-missing-prompt branch February 26, 2026 22:15

benthecarman pushed a commit to benthecarman/goose that referenced this pull request Feb 27, 2026

fix: replace unwrap() with graceful error in scheduler execute_job (b…

2db2e10

…lock#7436) Signed-off-by: Marlon Barreto <[email protected]>

github-actions bot mentioned this pull request Mar 2, 2026

chore(release): release version 1.27.0 (minor) #7611

Merged

craigwalkeruk pushed a commit to craigwalkeruk/custom-goose that referenced this pull request Mar 5, 2026

fix: replace unwrap() with graceful error in scheduler execute_job (b…

f273a7c

…lock#7436) Signed-off-by: Marlon Barreto <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: replace unwrap() with graceful error in scheduler execute_job#7436

fix: replace unwrap() with graceful error in scheduler execute_job#7436
jamadeo merged 2 commits intoblock:mainfrom
marlonbarreto-git:fix/scheduler-panic-on-missing-prompt

marlonbarreto-git commented Feb 23, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 23, 2026

Uh oh!

marlonbarreto-git Feb 23, 2026

Uh oh!

Copilot AI Feb 23, 2026

Uh oh!

marlonbarreto-git Feb 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

marlonbarreto-git commented Feb 23, 2026

Uh oh!

marlonbarreto-git commented Feb 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

-        .as_ref()
-        .or(recipe.instructions.as_ref())
+        .as_deref()
+        .filter(|s| !s.trim().is_empty())
+        .or_else(|| {
+            recipe
+                .instructions
+                .as_deref()
+                .filter(|s| !s.trim().is_empty())
+        })

Conversation

marlonbarreto-git commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Context

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

marlonbarreto-git Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

marlonbarreto-git Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

marlonbarreto-git commented Feb 23, 2026

Uh oh!

marlonbarreto-git commented Feb 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

marlonbarreto-git commented Feb 23, 2026 •

edited

Loading