Skip to content

Option to add changeable defaults in goose-releases#7373

Merged
dorien-koelemeijer merged 8 commits intomainfrom
feat/load-defaults-from-goose-releases
Feb 25, 2026
Merged

Option to add changeable defaults in goose-releases#7373
dorien-koelemeijer merged 8 commits intomainfrom
feat/load-defaults-from-goose-releases

Conversation

@dorien-koelemeijer
Copy link
Copy Markdown
Collaborator

@dorien-koelemeijer dorien-koelemeijer commented Feb 20, 2026 •
edited
Loading

Summary

Add option to add changeable defaults in goose-releases. Currently, there's an option to add defaults in init-config and bundles.py - the former will only add defaults when there is no config file, and the latter will override everything (even the user's config). This PR adds defaults that will be added if the user hasn't set certain variables in their local config file, but will never override the user's config.

A PR will be made in goose-releases to add the defaults.yaml file and add some initial variables.

Type of Change

  • Feature
  • Bug fix
  • Refactor / Code quality
  • Performance improvement
  • Documentation
  • Tests
  • Security fix
  • Build / Release
  • Other (specify below)

AI Assistance

  • This PR was created or reviewed with AI assistance

Testing

Local/manual testing using just run-ui

Copilot AI review requested due to automatic review settings February 20, 2026 02:13
@dorien-koelemeijer dorien-koelemeijer marked this pull request as draft February 20, 2026 02:13
Copilot AI reviewed Feb 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for “changeable defaults” by introducing an optional defaults.yaml source that fills in missing config keys without overriding user-provided values, intended for goose-releases bundling.

Changes:

  • Added defaults_path to Config and logic to load/merge defaults.yaml when keys are missing.
  • Updated get_param documentation and adjusted all_values implementation.
  • Added unit tests validating precedence: env > config > defaults, plus no-defaults behavior.

@dorien-koelemeijer dorien-koelemeijer changed the title Add option to add changeable defaults in goose-releases Opption to add changeable defaults in goose-releases Feb 20, 2026
@dorien-koelemeijer dorien-koelemeijer changed the title Opption to add changeable defaults in goose-releases Option to add changeable defaults in goose-releases Feb 20, 2026
@dorien-koelemeijer dorien-koelemeijer marked this pull request as ready for review February 20, 2026 02:51
Copilot AI review requested due to automatic review settings February 20, 2026 02:51
Copilot AI reviewed Feb 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@michaelneale
Copy link
Copy Markdown
Collaborator

michaelneale commented Feb 23, 2026

yep I think this is ok - did you test it with the app packaged via just make-ui - as behavior of file finding can vary, but I think this makes sense. May want to document it too for people packaging things up. Do you think this could also possibly retire the old .py script which hard codes in variables?

michaelneale
michaelneale approved these changes Feb 23, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@michaelneale michaelneale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trigger a re-run and should build next time

@dorien-koelemeijer
Copy link
Copy Markdown
Collaborator Author

dorien-koelemeijer commented Feb 23, 2026 •
edited
Loading

yep I think this is ok - did you test it with the app packaged via just make-ui - as behavior of file finding can vary, but I think this makes sense. May want to document it too for people packaging things up. Do you think this could also possibly retire the old .py script which hard codes in variables?

I will test again to make sure. I don't think we can retire the old bundles.py script, because it has its own purpose (hardcoding env vars that the user should not be able to change). I will confirm this though to make 100% sure that this is the case.

@dorien-koelemeijer dorien-koelemeijer force-pushed the feat/load-defaults-from-goose-releases branch from 588c103 to 7192f3a Compare February 24, 2026 01:59
@dorien-koelemeijer dorien-koelemeijer added this pull request to the merge queue Feb 25, 2026
Merged via the queue into main with commit d1f4dc9 Feb 25, 2026
22 checks passed
@dorien-koelemeijer dorien-koelemeijer deleted the feat/load-defaults-from-goose-releases branch February 25, 2026 01:42
@github-actions github-actions bot mentioned this pull request Feb 25, 2026
Merged
zanesq added a commit that referenced this pull request Feb 25, 2026
@zanesq
Merge branch 'main' of github.com:block/goose into evict-sessions-fro…
7663afc 
…m-cache

* 'main' of github.com:block/goose:
  chore(release): release version 1.25.0 (minor) (#7263)
  Docs: Community all-stars and page update (#7483)
  fix: searchbar zindex modal overlay (#7502)
  blog: Order Lunch Without Leaving Your AI Agent (#7505)
  feat: gateway to chat to goose - telegram etc (#7199)
  Option to add changeable defaults in goose-releases (#7373)
  Fix out of order messages (#7472)
  fix: ensure latest session always displays in sidebar (#7489)
  docs: rename TLDR to Quick Install in MCP tutorials (#7493)
  docs: update Neighborhood extension page with video embed and layout improvements (#7473)
  feat: let AskAI Discord bot see channels in the server (#7480)
  Apps token limit (#7474)
  fix(apps): declare color-scheme to allow transparent MCP App iframes (#7479)
u35tpus pushed a commit to u35tpus/goose that referenced this pull request Feb 26, 2026
@dorien-koelemeijer
Option to add changeable defaults in goose-releases (block#7373)
d28015e 
Signed-off-by: Oleg Levchenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@michaelneale michaelneale michaelneale approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dorien-koelemeijer @michaelneale