fix(desktop): make bundle and updater asset naming configurable#7337
Merged
jamadeo merged 4 commits intoblock:mainfrom Feb 26, 2026
Merged
fix(desktop): make bundle and updater asset naming configurable#7337jamadeo merged 4 commits intoblock:mainfrom
jamadeo merged 4 commits intoblock:mainfrom
Conversation
Signed-off-by: Vadim Polulyakh <[email protected]> (cherry picked from commit dfe6d12)
Signed-off-by: Vadim Polulyakh <[email protected]> (cherry picked from commit 31902a7)
Signed-off-by: Vadim Polulyakh <[email protected]> (cherry picked from commit 815e30b)
Signed-off-by: Vadim Polulyakh <[email protected]> (cherry picked from commit 9491fc3)
bavadim
force-pushed
the
fix/desktop-bundle-naming-env
branch
from
ca0ba4b to
f40b27a
Compare
jamadeo
approved these changes
Feb 26, 2026
zanesq
added a commit
that referenced
this pull request
Feb 26, 2026
…m-cache * 'main' of github.com:block/goose: fix: replace unwrap() with graceful error in scheduler execute_job (#7436) fix: Dictation API error message shows incorrect limit (#7423) fix(acp): Use ACP schema types for session/list (#7409) fix(desktop): make bundle and updater asset naming configurable (#7337) fix(openai): preserve order in Responses API history (#7500) Use the correct Goose emoji 🪿 instead of Swan in README.md (#7485) feat(ui): implement fullscreen and pip display modes for MCP Apps (#7312) Disable tool pair summarization (#7481)
benthecarman
pushed a commit
to benthecarman/goose
that referenced
this pull request
Feb 27, 2026
…k#7337) Signed-off-by: Vadim Polulyakh <[email protected]>
tlongwell-block
added a commit
that referenced
this pull request
Feb 27, 2026
…patible * origin/main: (70 commits) feat: allow goose askai bot to search goose codebase (#7508) Revert "Reapply "fix: prevent crashes in long-running Electron sessions"" Reapply "fix: prevent crashes in long-running Electron sessions" Revert "fix: prevent crashes in long-running Electron sessions" fix: replace unwrap() with graceful error in scheduler execute_job (#7436) fix: Dictation API error message shows incorrect limit (#7423) fix(acp): Use ACP schema types for session/list (#7409) fix(desktop): make bundle and updater asset naming configurable (#7337) fix(openai): preserve order in Responses API history (#7500) Use the correct Goose emoji 🪿 instead of Swan in README.md (#7485) feat(ui): implement fullscreen and pip display modes for MCP Apps (#7312) fix: prevent crashes in long-running Electron sessions Disable tool pair summarization (#7481) fix: New Recipe Warning does not close on cancel (#7524) The client is not the source of truth (#7438) feat: support Anthropic adaptive thinking (#7356) copilot instructions: reword no prerelease docs (#7101) fix(acp): don't fail session creation when model listing is unavailable (#7484) feat: simplify developer extension (#7466) feat: add goose-powered release notes generator workflow (#7503) ... # Conflicts: # Cargo.lock
tlongwell-block
added a commit
that referenced
this pull request
Feb 27, 2026
…m-extension-pr * origin/main: Update CODEOWNERS for team restructuring (#7574) Add snapshot test with platform extensions (#7573) Handle Bedrock 'prompt is too long' error (#7550) feat: make pctx/Code Mode an optional dependency via 'code-mode' feature (#7567) chore(release): release version 1.26.0 (minor) (#7512) feat: allow goose askai bot to search goose codebase (#7508) Revert "Reapply "fix: prevent crashes in long-running Electron sessions"" Reapply "fix: prevent crashes in long-running Electron sessions" Revert "fix: prevent crashes in long-running Electron sessions" fix: replace unwrap() with graceful error in scheduler execute_job (#7436) fix: Dictation API error message shows incorrect limit (#7423) fix(acp): Use ACP schema types for session/list (#7409) fix(desktop): make bundle and updater asset naming configurable (#7337) fix(openai): preserve order in Responses API history (#7500) Use the correct Goose emoji 🪿 instead of Swan in README.md (#7485) fix: prevent crashes in long-running Electron sessions
craigwalkeruk
pushed a commit
to craigwalkeruk/custom-goose
that referenced
this pull request
Mar 5, 2026
…k#7337) Signed-off-by: Vadim Polulyakh <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes hard-coded desktop bundle/asset names from macOS bundle scripts and GitHub updater asset lookup by introducing a configurable bundle name via env.
Problem
Desktop customization and rebranding often change app bundle/archive names, but several places still assumed
Goose:ui/desktop/package.jsonui/desktop/src/utils/githubUpdater.tsThat mismatch causes friction and failures in branded distributions (scripts look for
Goose.app/ updater looks forGoose*.zipwhile release assets use a custom name).What changed
GOOSE_BUNDLE_NAMEbuild-time define inui/desktop/vite.main.config.mts(default:Goose).ui/desktop/src/utils/githubUpdater.tsto useGOOSE_BUNDLE_NAMEfor release asset matching and downloaded file naming.ui/desktop/package.json(bundle:default,bundle:alpha,bundle:intel,debug) to useGOOSE_BUNDLE_NAMEinstead of hard-codedGoose.Why this approach
This follows the same configurable-by-env pattern already used for updater/publisher repository settings (
GITHUB_OWNER/GITHUB_REPO) and keeps the fix minimally invasive.Related issues
Validation
cd ui/desktop && npm run lint:checkcd ui/desktop && npm run test:runBoth passed.
AI usage
AI assistance was used to draft and apply code edits; validation was performed by running the checks above.