fix(ui-desktop): unify path resolution around GOOSE_PATH_ROOT by bavadim · Pull Request #7335 · block/goose

bavadim · 2026-02-19T00:13:53Z

Summary

This PR keeps path resolution consistent in Desktop by using GOOSE_PATH_ROOT as the path-root contract, with a minimal surface area.

What changed

Desktop main.ts: expose/pass GOOSE_PATH_ROOT for Desktop runtime and renderer config.
Desktop MCP shim scripts (jbang, uvx, node-setup-common.sh): resolve mcp-hermit under GOOSE_PATH_ROOT/config (or platform default when unset).
Desktop recipe storage picker: use GOOSE_PATH_ROOT/config/recipes for global recipe browsing in isolated runs.

Why

In branded/isolated Desktop runs, backend paths and UI/shim paths can diverge (GOOSE_PATH_ROOT/... vs ~/.config/goose/...).
That mismatch can cause extension bootstrap and recipe UX inconsistencies.

Related issues

Related to Failed to perform one time cleanup of mcp-hermit #5944 (mcp-hermit cleanup/path robustness in desktop flows)
Related to File picker for scheduling recipes should default to recipe dir #3431 (desktop recipe picker default path)
Related to any MCP server extensions I add to the goose config fail to start when running goose UI #5048 and Bug: Unable to add extension on linux #2351 (desktop MCP setup inconsistencies vs CLI on Linux)

Validation

cd ui/desktop && npm run lint:check
cd ui/desktop && npm run test:run

Both passed.

AI usage

AI assistance was used to draft and apply code edits; validation was performed by running the checks above.

Signed-off-by: Vadim Polulyakh <[email protected]> (cherry picked from commit ce19b4c)

Signed-off-by: Vadim Polulyakh <[email protected]> (cherry picked from commit 7f789c8)

Copilot

Pull request overview

This PR unifies path resolution in the Desktop app around the GOOSE_PATH_ROOT environment variable. Previously, MCP shim scripts (jbang, uvx, npx/node) and the recipe storage picker used hardcoded ~/.config/goose paths, causing divergence in branded/isolated desktop runs where the path root differs from the default. The PR fixes root causes of issues like mcp-hermit not being found and the "touch: cannot touch" cleanup error (issue #5944).

Changes:

main.ts: Adds resolveGoosePathRoot() to expand/expose GOOSE_PATH_ROOT in appConfig and passes it through to the goosed subprocess environment.
Shell shims (jbang, uvx, node-setup-common.sh): Replace hardcoded ~/.config/goose paths with MCP_HERMIT_DIR derived from GOOSE_PATH_ROOT (with a deprecated GOOSE_CONFIG_DIR fallback and a standard platform default).
recipe_management.ts: Updates getStorageDirectory to prefer GOOSE_PATH_ROOT/config/recipes for global recipe browsing.

Reviewed changes

Copilot reviewed 2 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`ui/desktop/src/main.ts`	Adds `resolveGoosePathRoot()` helper, exposes `GOOSE_PATH_ROOT` in `appConfig`, and passes it to the goosed subprocess env
`ui/desktop/src/recipe/recipe_management.ts`	Updates `getStorageDirectory` to use `GOOSE_PATH_ROOT/config/recipes` for global recipe directory
`ui/desktop/src/bin/uvx`	Replaces hardcoded `~/.config/goose` with `MCP_HERMIT_DIR` derived from `GOOSE_PATH_ROOT`
`ui/desktop/src/bin/node-setup-common.sh`	Same path unification plus fixes the cleanup marker path for the mcp-hermit one-time cleanup
`ui/desktop/src/bin/jbang`	Same path unification as `uvx`

Copilot · 2026-03-06T03:31:17Z

ui/desktop/src/recipe/recipe_management.ts

+    const configDir = window.appConfig.get('GOOSE_CONFIG_DIR') as string | undefined;
+    if (configDir) {
+      return `${configDir}/recipes`;
+    }


GOOSE_CONFIG_DIR is never added to appConfig in main.ts, so window.appConfig.get('GOOSE_CONFIG_DIR') will always return undefined and the fallback block on lines 49-52 is unreachable dead code. Either add GOOSE_CONFIG_DIR to appConfig in main.ts, or remove this dead fallback branch since the PR's stated intent is to unify around GOOSE_PATH_ROOT.

Suggested change

const configDir = window.appConfig.get('GOOSE_CONFIG_DIR') as string | undefined;

if (configDir) {

return `${configDir}/recipes`;

}

@angiejones

* origin/main: (21 commits) fix(ui-desktop): unify path resolution around GOOSE_PATH_ROOT (#7335) fix: pass OAuth scopes to DCR and extract granted_scopes from token response (#7571) fix: write to real file if config.yaml is symlink (#7669) fix: preserve pairings when stopping gateway (#7733) fix: reduce server log verbosity — skip session in instrument, defaul… (#7729) fix: provider test infrastructure (#7738) fix: sanitize streamable HTTP extension names derived from URLs (#7740) refactor: derive GooseMode string conversions with strum (#7706) docs: Add Spraay Batch Payments MCP Extension Tutorial (#7525) fix: flake.nix (#7224) delete goose web (#7696) Add @angiejones as CODEOWNER for documentation (#7711) Add MLflow integration guide (#7563) docs: LM Studio availability (#7698) feat: add Avian as an LLM provider (#7561) Adds `linux-mcp-server` to the goose registry (#6979) fix: add #[serde(default)] to description field on 4 ExtensionConfig variants (#7708) feat: combine TUI UX from alexhancock/tui-goodness with publishing config from jackamadeo/package-tui (#7683) chore: cleanup old sandbox (#7700) Correct windows artifact (#7699) ...

@angiejones

* origin/main: (21 commits) fix(ui-desktop): unify path resolution around GOOSE_PATH_ROOT (#7335) fix: pass OAuth scopes to DCR and extract granted_scopes from token response (#7571) fix: write to real file if config.yaml is symlink (#7669) fix: preserve pairings when stopping gateway (#7733) fix: reduce server log verbosity — skip session in instrument, defaul… (#7729) fix: provider test infrastructure (#7738) fix: sanitize streamable HTTP extension names derived from URLs (#7740) refactor: derive GooseMode string conversions with strum (#7706) docs: Add Spraay Batch Payments MCP Extension Tutorial (#7525) fix: flake.nix (#7224) delete goose web (#7696) Add @angiejones as CODEOWNER for documentation (#7711) Add MLflow integration guide (#7563) docs: LM Studio availability (#7698) feat: add Avian as an LLM provider (#7561) Adds `linux-mcp-server` to the goose registry (#6979) fix: add #[serde(default)] to description field on 4 ExtensionConfig variants (#7708) feat: combine TUI UX from alexhancock/tui-goodness with publishing config from jackamadeo/package-tui (#7683) chore: cleanup old sandbox (#7700) Correct windows artifact (#7699) ...

@angiejones

…e-issue * origin/main: fix(ui-desktop): unify path resolution around GOOSE_PATH_ROOT (#7335) fix: pass OAuth scopes to DCR and extract granted_scopes from token response (#7571) fix: write to real file if config.yaml is symlink (#7669) fix: preserve pairings when stopping gateway (#7733) fix: reduce server log verbosity — skip session in instrument, defaul… (#7729) fix: provider test infrastructure (#7738) fix: sanitize streamable HTTP extension names derived from URLs (#7740) refactor: derive GooseMode string conversions with strum (#7706) docs: Add Spraay Batch Payments MCP Extension Tutorial (#7525) fix: flake.nix (#7224) delete goose web (#7696) Add @angiejones as CODEOWNER for documentation (#7711) Add MLflow integration guide (#7563) docs: LM Studio availability (#7698) feat: add Avian as an LLM provider (#7561) Adds `linux-mcp-server` to the goose registry (#6979) fix: add #[serde(default)] to description field on 4 ExtensionConfig variants (#7708)

@DOsinga

* main: (45 commits) fix: resolve {{ recipe_dir }} in nested sub-recipe paths during secret discovery (#7797) Add @DOsinga as CODEOWNER for documentation (#7799) feat: Add summarize tool for deterministic reads (#7054) fix(api): use camelCase in CallToolResponse and add type discriminators to ContentBlock (#7487) feat: ACP providers for claude code and codex (#6605) chore(deps): bump express-rate-limit from 8.2.1 to 8.3.0 in /evals/open-model-gym/mcp-harness (#7703) feat(openai): capture reasoning summaries from responses API (#7375) Fix some dependencies (#7794) fix: improve keyring availability error detection (#7766) feat: add MiniMax provider with Anthropic-compatible API (#7640) feat: add Tensorix as a declarative provider (#7712) fix(security): remove insecure default secret from GOOSE_EXTERNAL_BACKEND (#7783) refactor: Convert Tanzu provider to declarative JSON config (#7124) replaces https://github.com/block/goose/pull/7340/changes (#7786) feat(summon): make skill supporting files individually loadable via load() (#7583) Keep toast open on failed extension (#7771) fix(ui-desktop): unify path resolution around GOOSE_PATH_ROOT (#7335) fix: pass OAuth scopes to DCR and extract granted_scopes from token response (#7571) fix: write to real file if config.yaml is symlink (#7669) fix: preserve pairings when stopping gateway (#7733) ...

@DOsinga

* main: (69 commits) fix: resolve {{ recipe_dir }} in nested sub-recipe paths during secret discovery (#7797) Add @DOsinga as CODEOWNER for documentation (#7799) feat: Add summarize tool for deterministic reads (#7054) fix(api): use camelCase in CallToolResponse and add type discriminators to ContentBlock (#7487) feat: ACP providers for claude code and codex (#6605) chore(deps): bump express-rate-limit from 8.2.1 to 8.3.0 in /evals/open-model-gym/mcp-harness (#7703) feat(openai): capture reasoning summaries from responses API (#7375) Fix some dependencies (#7794) fix: improve keyring availability error detection (#7766) feat: add MiniMax provider with Anthropic-compatible API (#7640) feat: add Tensorix as a declarative provider (#7712) fix(security): remove insecure default secret from GOOSE_EXTERNAL_BACKEND (#7783) refactor: Convert Tanzu provider to declarative JSON config (#7124) replaces https://github.com/block/goose/pull/7340/changes (#7786) feat(summon): make skill supporting files individually loadable via load() (#7583) Keep toast open on failed extension (#7771) fix(ui-desktop): unify path resolution around GOOSE_PATH_ROOT (#7335) fix: pass OAuth scopes to DCR and extract granted_scopes from token response (#7571) fix: write to real file if config.yaml is symlink (#7669) fix: preserve pairings when stopping gateway (#7733) ...

bavadim added 2 commits February 20, 2026 11:43

fix(ui-desktop): align config/runtime paths with GOOSE_PATH_ROOT

b046416

Signed-off-by: Vadim Polulyakh <[email protected]> (cherry picked from commit ce19b4c)

refactor(ui-desktop): prefer GOOSE_PATH_ROOT for path resolution

09edb58

Signed-off-by: Vadim Polulyakh <[email protected]> (cherry picked from commit 7f789c8)

bavadim force-pushed the fix/goose-path-root-configdir branch from 35d0a4a to 09edb58 Compare February 20, 2026 11:43

jamadeo requested a review from Copilot March 6, 2026 03:25

jamadeo self-assigned this Mar 6, 2026

Copilot started reviewing on behalf of jamadeo March 6, 2026 03:25 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

jamadeo approved these changes Mar 9, 2026

View reviewed changes

Merge branch 'main' into fix/goose-path-root-configdir

5b66860

jamadeo enabled auto-merge March 9, 2026 16:01

jamadeo added this pull request to the merge queue Mar 9, 2026

Merged via the queue into block:main with commit 12eac72 Mar 9, 2026
20 checks passed

github-actions bot mentioned this pull request Mar 10, 2026

chore(release): release version 1.28.0 (minor) #7780

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ui-desktop): unify path resolution around GOOSE_PATH_ROOT#7335

fix(ui-desktop): unify path resolution around GOOSE_PATH_ROOT#7335
jamadeo merged 3 commits intoblock:mainfrom
redsquad-tech:fix/goose-path-root-configdir

bavadim commented Feb 19, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

bavadim commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What changed

Why

Related issues

Validation

AI usage

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bavadim commented Feb 19, 2026 •

edited

Loading