fix: prevent SageMaker TGI from being marked configured when only Bedrock keys are set#7284
Merged
lifeizhou-ap merged 2 commits intoblock:mainfrom Mar 12, 2026
Merged
Conversation
ibaaaaal
force-pushed
the
fix/sagemaker-tgi-config-collision
branch
3 times, most recently
from
c374dbb to
218824d
Compare
- SageMaker TGI: mark SAGEMAKER_ENDPOINT_NAME as required, AWS_REGION/AWS_PROFILE as optional - Bedrock: mark AWS_REGION as required with default to fix is_configured always returning false Signed-off-by: ibaaaaal [email protected]
ibaaaaal
force-pushed
the
fix/sagemaker-tgi-config-collision
branch
from
218824d to
8a13da5
Compare
* main: (270 commits) test(acp): align provider and server test parity (block#7822) fix(acp): register MCP extensions when resuming a session (block#7806) fix(goose): load .gitignore in prompt_manager for hint file filtering (block#7795) fix: remap max_completion_tokens to max_tokens for OpenAI-compatible providers (block#7765) fix(openai): preserve Responses API tool call/output linkage (block#7759) chore(deps): bump @hono/node-server from 1.19.9 to 1.19.11 in /evals/open-model-gym/mcp-harness (block#7687) fix: return ContextLengthExceeded when prompt exceeds effective KV cache size (block#7815) feat: MCP Roots support (block#7790) fix(google): use `includeThoughts/part.thought` for thinking handling (block#7593) refactor: simplify tokenizer initialization — remove unnecessary Result wrapper (block#7744) Fix model selector showing wrong model in tabs (block#7784) Stop collecting goosed stderr after startup (block#7814) fix: avoid word splitting by space for windows shell commands (block#7781) (block#7810) Simplify and make it not break on linux (block#7813) Add preferred microphone selection (block#7805) Remove dependency on posthog-rs (block#7811) feat: load hints in nested subdirs (block#7772) feat(acp): add read tool and delegate filesystem I/O to ACP clients (block#7668) Support secret interpolation in streamable HTTP extension URLs (block#7782) More logging for command injection classifier model training (block#7779) ...
lifeizhou-ap
approved these changes
Mar 12, 2026
Collaborator
lifeizhou-ap
left a comment
lifeizhou-ap
left a comment
There was a problem hiding this comment.
Thanks for fixing it!
michaelneale
added a commit
that referenced
this pull request
Mar 15, 2026
* origin/main: Remove include from Cargo.toml in goose-mcp (#7838) Exit agent loop when tool call JSON fails to parse (#7840) chore: remove redundant husky prepare script (#7829) Add github actions workflow for unused deps (#7681) fix: prevent SSE connection drops from silently truncating responses (#7831) doc: Added notes in contribution guide for pnpm (#7833) add prefer-offline to pnpm config to skip unnecessary registry lookups (#7828) fix: remove dead read handler from DeveloperClient (#7821) fix: prevent SageMaker TGI from being marked configured when only Bedrock keys are set (#7284) fix: disable some computercontroller functionality when no $DISPLAY detected (#7824) test(acp): align provider and server test parity (#7822) fix(acp): register MCP extensions when resuming a session (#7806) # Conflicts: # ui/desktop/src/hooks/useChatStream.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7268 — Configuring Amazon Bedrock causes Amazon SageMaker TGI to appear as configured.
This PR also fixes a related issue: Amazon Bedrock itself was not appearing in the provider selection dropdown because all its config keys were optional.
Root Cause
Issue 1: SageMaker TGI incorrectly marked as configured
SAGEMAKER_ENDPOINT_NAMEwas declared asrequired=falsein the provider metadata, whileAWS_REGIONandAWS_PROFILEwererequired=truewith defaults. When a user configures Bedrock, the sharedAWS_REGION/AWS_PROFILEkeys get stored globally. Thecheck_provider_configured()logic then sees SageMaker TGI's required keys are satisfied and marks it as configured, even though no SageMaker endpoint was actually set up.Issue 2: Bedrock not appearing in provider dropdown
Amazon Bedrock had all config keys marked as
required=false. Thecheck_provider_configured()function returnsfalsefor providers with zero required keys, causing Bedrock to never appear as "configured" in the provider selection dropdown.Fix
SageMaker TGI fix (
sagemaker_tgi.rs):SAGEMAKER_ENDPOINT_NAMEasrequired=true— it is already required at runtimeAWS_REGIONandAWS_PROFILEasrequired=false— consistent with BedrockBedrock fix (
bedrock.rs):AWS_REGIONasrequired=truewith default"us-east-1"— this ensures Bedrock is properly marked as configured when the region is setValidation
cargo fmt --check— passcargo clippy -D warnings— passcargo test --release -p goose— 687 tests pass (4 unrelated failures in prompt_manager are pre-existing)