Skip to content

Mcp apps styling#7147

Closed
DOsinga wants to merge 6 commits intomainfrom
mcp-apps-styling
Closed

Mcp apps styling#7147
DOsinga wants to merge 6 commits intomainfrom
mcp-apps-styling

Conversation

@DOsinga
Copy link
Copy Markdown
Collaborator

@DOsinga DOsinga commented Feb 11, 2026

Summary

Adapt to MCP colors fully - demonstrate it works by having changeable theme colors:

image

Copilot AI review requested due to automatic review settings February 11, 2026 12:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 145 out of 146 changed files in this pull request and generated 2 comments.

mod openapi;
mod routes;
mod state;
mod theme_css;
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module declaration mod theme_css; is added but the actual theme_css.rs file is not included in this PR. This will cause a compilation error as the module cannot be found.

Suggested change
mod theme_css;

Copilot uses AI. Check for mistakes.
Comment on lines +847 to +850
Json(ThemeVariablesResponse { variables })
}

#[derive(Deserialize, ToSchema)]
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The theme_css module is referenced but not included in this PR. The function generate_mcp_theme_variables() is called but its implementation is missing from the changeset. This will cause a compilation error.

Copilot uses AI. Check for mistakes.
Douwe Osinga added 2 commits February 12, 2026 19:22
# Conflicts:
#	ui/desktop/src/api/index.ts
#	ui/desktop/src/components/ChatInput.tsx
#	ui/desktop/src/components/McpApps/McpAppRenderer.tsx
#	ui/desktop/src/components/McpApps/types.ts
#	ui/desktop/src/components/McpApps/useSandboxBridge.ts
#	ui/desktop/src/components/ToolCallArguments.tsx
#	ui/desktop/src/components/ToolCallWithResponse.tsx
#	ui/desktop/src/components/recipes/shared/RecipeFormFields.tsx
#	ui/desktop/src/components/settings/chat/GoosehintsModal.tsx
#	ui/desktop/src/styles/main.css
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 144 out of 145 changed files in this pull request and generated no new comments.

@aharvard
Copy link
Copy Markdown
Collaborator

Closing in favor of a cleaner two-part PR strategy that incorporates this work:

#7275 — theme-tokens — theme token infrastructure + CSS class rename (~130 TSX files)
#7276 — theme-builder — preset gallery & custom color editor

The CSS variable rename and main.css restructuring are included in #7275. The Rust CSS parser (theme_css.rs) and server-side theme endpoints were replaced by a TypeScript-first approach, so those pieces didn't carry over. Thanks for kicking this off!

@aharvard aharvard closed this Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants