Skip to content

Always sync bundled extensions#7057

Merged
zanesq merged 1 commit intomainfrom
zane/fix-bundled-extensions-on-update
Feb 9, 2026
Merged

Always sync bundled extensions#7057
zanesq merged 1 commit intomainfrom
zane/fix-bundled-extensions-on-update

Conversation

@zanesq
Copy link
Copy Markdown
Contributor

@zanesq zanesq commented Feb 6, 2026

Summary

After #6568 we stopped getting new bundled extensions after updating. This changes it so new bundled extensions are always applied.

PR #6568 (f3c2f8e) added a conditional check that only synced bundled extensions when no bundled extensions existed (i.e., fresh installs only):

// BROKEN CODE (before fix)
const hasBundledExtensions = extensions.some(
  (ext) => ext.type === 'builtin' && 'bundled' in ext && ext.bundled
);

if (!hasBundledExtensions) {
  await syncBundledExtensions(extensions, addExtensionForSync);
}

This broke the ability for existing users to receive new bundled extensions added to bundled-extensions.json in subsequent releases.

The fix removes this gate so syncBundledExtensions always runs, and the function itself correctly skips extensions that already exist with bundled: true while adding any new ones.

@michaelneale
Copy link
Copy Markdown
Collaborator

michaelneale commented Feb 9, 2026

I think this is ok - slightly worried about a distant memory of a bug that was caused here recently

@zanesq zanesq added this pull request to the merge queue Feb 9, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 9, 2026
@zanesq zanesq added this pull request to the merge queue Feb 9, 2026
Merged via the queue into main with commit 320f22b Feb 9, 2026
17 checks passed
@zanesq zanesq deleted the zane/fix-bundled-extensions-on-update branch February 9, 2026 17:27
tlongwell-block added a commit that referenced this pull request Feb 9, 2026
@tlongwell-block
Merge remote-tracking branch 'origin/main' into summon_extension
01cad15 
* origin/main:
  Docs: require auth optional for custom providers (#7098)
  fix: improve text-muted contrast for better readability (#7095)
  Always sync bundled extensions (#7057)
  feat: Add tom (Top Of Mind) platform extension (#7073)
  chore(docs): update GOOSE_SESSION_ID -> AGENT_SESSION_ID (#6669)
  fix(ci): switch from cargo-audit to cargo-deny for advisory scanning (#7032)
  chore(deps): bump @isaacs/brace-expansion from 5.0.0 to 5.0.1 in /evals/open-model-gym/suite (#7085)
  chore(deps): bump @modelcontextprotocol/sdk from 1.25.3 to 1.26.0 in /evals/open-model-gym/mcp-harness (#7086)
  fix: switch to windows msvc (#7080)
  fix: allow unlisted models for CLI providers (#7090)
  Use goose port (#7089)
  chore: strip posthog for sessions/models/daily only (#7079)
  tidy: clean up old benchmark and add gym (#7081)
  fix: use command.process_group(0) for CLI providers, not just MCP (#7083)
  added build notify (#6891)
@github-actions github-actions bot mentioned this pull request Feb 10, 2026
Closed
michaelneale added a commit that referenced this pull request Feb 10, 2026
@michaelneale
Merge branch 'main' into manik/whitelabel
476328e 
* main: (125 commits)
  chore: add a new scenario (#7107)
  fix: Goose Desktop missing Calendar and Reminders entitlements (#7100)
  Fix 'Edit In Place' and 'Fork Session' features (#6970)
  Fix: Only send command content to command injection classifier (excluding part of tool call dict) (#7082)
  Docs: require auth optional for custom providers (#7098)
  fix: improve text-muted contrast for better readability (#7095)
  Always sync bundled extensions (#7057)
  feat: Add tom (Top Of Mind) platform extension (#7073)
  chore(docs): update GOOSE_SESSION_ID -> AGENT_SESSION_ID (#6669)
  fix(ci): switch from cargo-audit to cargo-deny for advisory scanning (#7032)
  chore(deps): bump @isaacs/brace-expansion from 5.0.0 to 5.0.1 in /evals/open-model-gym/suite (#7085)
  chore(deps): bump @modelcontextprotocol/sdk from 1.25.3 to 1.26.0 in /evals/open-model-gym/mcp-harness (#7086)
  fix: switch to windows msvc (#7080)
  fix: allow unlisted models for CLI providers (#7090)
  Use goose port (#7089)
  chore: strip posthog for sessions/models/daily only (#7079)
  tidy: clean up old benchmark and add gym (#7081)
  fix: use command.process_group(0) for CLI providers, not just MCP (#7083)
  added build notify (#6891)
  test(mcp): add image tool test and consolidate MCP test fixtures (#7019)
  ...
zanesq added a commit that referenced this pull request Feb 10, 2026
@zanesq
Merge branch 'main' of github.com:block/goose into zane/fix-recipe-ex…
e8ec6cf 
…tensions-deeplinks

* 'main' of github.com:block/goose:
  [docs] update authors.yaml file (#7114)
  Implement manpage generation for goose-cli (#6980)
  docs: tool output optimization (#7109)
  Fix duplicated output in Code Mode by filtering content by audience (#7117)
  Enable tom (Top Of Mind) platform extension by default (#7111)
  chore: added notification for canary build failure (#7106)
  fix: fix windows bundle random failure and optimise canary build (#7105)
  feat(acp): add model selection support for session/new and session/set_model (#7112)
  fix: isolate claude-code sessions via stream-json session_id (#7108)
  ci: enable agentic provider live tests (claude-code, codex, gemini-cli) (#7088)
  docs: codex subscription support (#7104)
  chore: add a new scenario (#7107)
  fix: Goose Desktop missing Calendar and Reminders entitlements (#7100)
  Fix 'Edit In Place' and 'Fork Session' features (#6970)
  Fix: Only send command content to command injection classifier (excluding part of tool call dict) (#7082)
  Docs: require auth optional for custom providers (#7098)
  fix: improve text-muted contrast for better readability (#7095)
  Always sync bundled extensions (#7057)
lifeizhou-ap added a commit that referenced this pull request Feb 11, 2026
@lifeizhou-ap
Merge branch 'main' into lifei/ai-edit-toggle-recipe
be30d5d 
* main: (85 commits)
  Fix 'Edit In Place' and 'Fork Session' features (#6970)
  Fix: Only send command content to command injection classifier (excluding part of tool call dict) (#7082)
  Docs: require auth optional for custom providers (#7098)
  fix: improve text-muted contrast for better readability (#7095)
  Always sync bundled extensions (#7057)
  feat: Add tom (Top Of Mind) platform extension (#7073)
  chore(docs): update GOOSE_SESSION_ID -> AGENT_SESSION_ID (#6669)
  fix(ci): switch from cargo-audit to cargo-deny for advisory scanning (#7032)
  chore(deps): bump @isaacs/brace-expansion from 5.0.0 to 5.0.1 in /evals/open-model-gym/suite (#7085)
  chore(deps): bump @modelcontextprotocol/sdk from 1.25.3 to 1.26.0 in /evals/open-model-gym/mcp-harness (#7086)
  fix: switch to windows msvc (#7080)
  fix: allow unlisted models for CLI providers (#7090)
  Use goose port (#7089)
  chore: strip posthog for sessions/models/daily only (#7079)
  tidy: clean up old benchmark and add gym (#7081)
  fix: use command.process_group(0) for CLI providers, not just MCP (#7083)
  added build notify (#6891)
  test(mcp): add image tool test and consolidate MCP test fixtures (#7019)
  fix: remove Option from model listing return types, propagate errors (#7074)
  fix: lazy provider creation for goose acp (#7026) (#7066)
  ...
Tyler-Hardin pushed a commit to Tyler-Hardin/goose that referenced this pull request Feb 11, 2026
@zanesq @Tyler-Hardin
Always sync bundled extensions (block#7057)
abdea47
Tyler-Hardin pushed a commit to Tyler-Hardin/goose that referenced this pull request Feb 11, 2026
@zanesq @Tyler-Hardin
Always sync bundled extensions (block#7057)
32087ce
@BrewTestBot BrewTestBot mentioned this pull request Feb 12, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexhancock alexhancock alexhancock approved these changes

@The-Best-Codes The-Best-Codes The-Best-Codes approved these changes

@michaelneale michaelneale Awaiting requested review from michaelneale

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zanesq @michaelneale @alexhancock @The-Best-Codes