Add preferred microphone selection with dropdown z-index and settings propagation fixes#6735
Closed
lpetrov wants to merge 1 commit intoblock:mainfrom
Closed
Add preferred microphone selection with dropdown z-index and settings propagation fixes#6735lpetrov wants to merge 1 commit intoblock:mainfrom
lpetrov wants to merge 1 commit intoblock:mainfrom
Conversation
… propagation fixes - Add MicrophoneSelector component for choosing audio input device - Fix titlebar drag region z-index (50→40) so dropdown renders above it - Dispatch custom event on settings save so chat view picks up new mic immediately - Update useDictationSettings hook to listen for dictation-settings-changed event - Refactor ProviderSelector to accept props for reuse Signed-off-by: lpetrov <[email protected]>
lpetrov
force-pushed
the
feature/preferred-microphone-selection
branch
from
60d7c80 to
38406cc
Compare
DOsinga
approved these changes
Feb 17, 2026
Collaborator
DOsinga
left a comment
DOsinga
left a comment
There was a problem hiding this comment.
thanks for doing this and sorry for the long delay. we rather refactored how this all works right now, so hopefully you can merge in main and get it to work again?
| const parsed = JSON.parse(savedSettings); | ||
| loadedSettings = parsed; | ||
| // Ensure backward compatibility: add preferredDeviceId if missing | ||
| loadedSettings = { preferredDeviceId: null, ...parsed }; |
Collaborator
There was a problem hiding this comment.
can we move this to the acutal settings of the app rather than adhoc localStorage? that never really seems to work
Collaborator
|
closing as needs updating - please re-open when time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a microphone input source selector to the voice dictation settings panel, allowing users to choose their preferred audio input device (e.g., AirPods, MacBook microphone, external mic). Also fixes two bugs: a z-index conflict causing the dropdown to render behind the titlebar, and settings changes not propagating immediately to the active chat session.
Type of Change
AI Assistance
Testing
Manual testing performed:
Related Issues
N/A
Screenshots/Demos (for UX changes)
Before:
That section was not available.
After:
Detailed Changes
New Feature: Microphone Selector (
MicrophoneSelector.tsx)navigator.mediaDevices.enumerateDevices()Bug Fix: Dropdown z-index (
main.css).titlebar-drag-regionz-index from50to40z-50) render above the fixed titlebarz-40) < dropdowns/modals (z-50)Bug Fix: Settings propagation (
VoiceDictationToggle.tsx,useDictationSettings.ts)dictation-settings-changedCustomEvent when settings are saveduseDictationSettingshook listens for this event to immediately pick up changeswindow.storageevents only fire cross-tab, not within the same window