Update cleanup marker logic for Fedora users.#5868
Merged
The-Best-Codes merged 5 commits intoblock:mainfrom Nov 26, 2025
Merged
Update cleanup marker logic for Fedora users.#5868The-Best-Codes merged 5 commits intoblock:mainfrom
The-Best-Codes merged 5 commits intoblock:mainfrom
Conversation
Collaborator
|
weird - what is adding double quotes? If that is an issue - could probably remove it for all, this can't just be fedora? (could try single quotes too). |
Collaborator
|
@sudocarlos if you can do the DCO thing as well, would be appreciated, and can get it in (still very strange! but I have seen weirder things and clearly this worked for you when packaged up). |
The-Best-Codes
requested changes
Nov 25, 2025
Update cleanup marker logic for Fedora users. Signed-off-by: Carlos <[email protected]>
Remove extra lines Signed-off-by: Carlos <[email protected]>
Signed-off-by: Carlos <[email protected]>
…xpansion Signed-off-by: Carlos <[email protected]>
The-Best-Codes
requested changes
Nov 26, 2025
|
|
||
| # One-time cleanup for existing Linux users to fix locking issues | ||
| CLEANUP_MARKER="~/.config/goose/.mcp-hermit-cleanup-v1" | ||
| CLEANUP_MARKER="${HOME}/.config/goose/.mcp-hermit-cleanup-v1" |
Collaborator
There was a problem hiding this comment.
Remove the quotes, it should work fine with them but better without them for consistency.
Signed-off-by: Carlos <[email protected]>
The-Best-Codes
approved these changes
Nov 26, 2025
Collaborator
The-Best-Codes
left a comment
The-Best-Codes
left a comment
There was a problem hiding this comment.
Looks good, @michaelneale do you mind reviewing this as well?
michaelneale
approved these changes
Nov 26, 2025
Collaborator
michaelneale
left a comment
michaelneale
left a comment
There was a problem hiding this comment.
I think should be great. thanks all
Collaborator
|
Merged @sudocarlos, thank you! |
angiejones
pushed a commit
that referenced
this pull request
Nov 26, 2025
Signed-off-by: Carlos <[email protected]>
BlairAllan
pushed a commit
to BlairAllan/goose
that referenced
this pull request
Nov 29, 2025
Signed-off-by: Carlos <[email protected]> Signed-off-by: Blair Allan <[email protected]>
katzdave
added a commit
that referenced
this pull request
Dec 1, 2025
…nses-streaming * 'main' of github.com:block/goose: Feat/automatic update installation (#5345) fix: Added "Merged consecutive assistant messages" to the acceptable issues for moim injection check (#5933) fix: anthropic provider model fetching (#5932) [MCP-UI] add CSP for images to proxy HTML (#5931) fix: correct typo in blog post (AIMDOEL -> AIMODEL) (#5902) feat: @goose in terminal (native terminal support) (#5887) docs: adding AI-friendly features (#5918) Blog/advent of ai announcement (#5917) Extension selector behind ALPHA flag (#5892) blog: typo fixes (#5896) blog: fixing img url (#5895) blog: MCPs for Developers (#5884) docs: Extension Manager MCP (#5883) Update cleanup marker logic for Fedora users. (#5868) Improve AWS credential loading and configuration handling in BedrockProvider (#5699)
10 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update cleanup marker logic for Fedora users.
Summary
Removes the double quotes from
CLEANUP_MARKERfor Fedora systems experiencing an errortouch: cannot access '~/.config/goose/.mcp-hermit-cleanup-v1': No such file or directorywhen trying to add extensions.Type of Change
AI Assistance
Testing
Manual testing. I made this change in my system to resolve the issue when I encountered it. I verified the same in a fresh Fedora Workstation 43 VM, too.
Related Issues
Relates to #ISSUE_ID
Discussion: LINK (if any)
Screenshots/Demos (for UX changes)
Before:
After:
Submitting a Recipe?
Email: