Bug: prevent multiple file picker dialogs on double-click by Lymah123 · Pull Request #5640 · block/goose

Lymah123 · 2025-11-08T12:22:05Z

Summary

Add fileDialogOpen guard flag to select-file-or-directory IPC handler to prevent
race condition where rapid double-clicks would spawn multiple overlapping
file picker dialogs. Uses try-finally to ensure flag is always reset.

Also add .cargo/ to .gitignore to exclude local cargo config.

Type of Change

AI Assistance

This PR was created or reviewed with AI assistance

Testing

Related Issues

Relates to #5527
Discussion: LINK (if any)

Screenshots/Demos (for UX changes)

Before:

After:

Submitting a Recipe?

Email:

Signed-off-by: Lymah123 <[email protected]>

Copilot

Pull Request Overview

This pull request includes improvements to file dialog handling in the desktop application, adds a new community content submission, and updates the .gitignore file.

Prevents multiple simultaneous file dialogs using a flag with try-finally cleanup
Adds a community blog post submission about managing goose configurations
Ignores the .cargo/ directory in version control

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File	Description
ui/desktop/src/main.ts	Adds protection against multiple simultaneous file dialogs with proper cleanup using try-finally pattern
documentation/src/pages/community/data/community-content.json	Adds a community blog post entry about managing goose configurations
.gitignore	Adds .cargo/ directory to ignored paths

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-08T12:23:51Z

documentation/src/pages/community/data/community-content.json

+      "title": "Managing goose Configurations Across Multiple Projects",
+      "author": {
+        "name": "Halimah",
+        "handle": "lymah123"
+      },
+      "type": "blog",
+      "url": "https://dev.to/lymah/managing-goose-configurations-across-multiple-projects-58i3",
+      "thumbnail": "https://i.imgur.com/VvM8sMR.png",
+      "submittedDate": "2025-10-30",
+      "tags": ["hacktoberfest"],


This entry appears to be a duplicate of the existing entry at lines 273-286. Both entries have the same title, author, URL, thumbnail, and submitted date. This duplicate should be removed to avoid redundant content in the community submissions list.

Suggested change

"title": "Managing goose Configurations Across Multiple Projects",

"author": {

"name": "Halimah",

"handle": "lymah123"

},

"type": "blog",

"url": "https://dev.to/lymah/managing-goose-configurations-across-multiple-projects-58i3",

"thumbnail": "https://i.imgur.com/VvM8sMR.png",

"submittedDate": "2025-10-30",

"tags": ["hacktoberfest"],

"title": "Managing Goose Configurations Across Multiple Projects: A Practical Guide",

"author": {

"name": "Viet Bui",

"handle": "vietbui1999ru"

},

"type": "blog",

"url": "https://dev.to/vietbui1999ru/managing-goose-configurations-across-multiple-projects-a-practical-guide-48ei",

"thumbnail": "https://imgur.com/a/ubyYbVJ",

"submittedDate": "2025-10-31",

"tags": [

"hacktoberfest"

],

Lymah123 · 2025-11-08T12:24:15Z

Hi @DOsinga! I will be waiting for your review.

DOsinga

Thanks for jumping on this. I think we need to solve this at the caller level though

if we add functonality to the selectFileOrDirectory calls (there's two, but we only really care about the one in ChatInput.tsx) we can just dissable the button while the modal is open.

that would be a better experience since with the current proposed fix, if we have two goose windows and you select files from both, as soon as the first one closes, the second one would allow you to open an extra window, but also, disabling a button is better than just doing nothing because that other window is already open

Lymah123 · 2025-11-11T13:41:50Z

Hi!
Just to confirm: would you prefer we handle this by disabling the select button in ChatInput.tsx while the dialog is open, instead of managing it in the Electron main process? Want to make sure I'm taking the right approach, thanks! @DOsinga

DOsinga · 2025-11-11T13:59:12Z

Hi! Just to confirm: would you prefer we handle this by disabling the select button in ChatInput.tsx while the dialog is open, instead of managing it in the Electron main process? Want to make sure I'm taking the right approach, thanks! @DOsinga

yes, I think that would work better - thanks

Lymah123 · 2025-11-11T14:10:06Z

Hi! Just to confirm: would you prefer we handle this by disabling the select button in ChatInput.tsx while the dialog is open, instead of managing it in the Electron main process? Want to make sure I'm taking the right approach, thanks! @DOsinga

yes, I think that would work better - thanks

Alright. I will work on the requested changes. Thanks

alexhancock · 2025-11-12T16:07:49Z

documentation/src/pages/community/data/community-content.json

        "hacktoberfest"
      ],
      "hacktoberfest": true
+    },


These changes don't seem relevant to the intended scope of the PR. Are they left in unintentionally?

I will remove those files once I am done making the requested changes. They were from my past PRs.

Abhijay007 · 2025-11-14T16:05:45Z

documentation/src/pages/community/data/community-content.json

This file shouldn't be deleted; just your changes need to be reverted

Fixed. Thanks

Abhijay007

commented above

blackgirlbytes · 2025-11-14T18:58:22Z

ui/desktop/src/components/ChatInput.tsx

  const [displayValue, setDisplayValue] = useState(initialValue); // For immediate visual feedback
  const [isFocused, setIsFocused] = useState(false);
  const [pastedImages, setPastedImages] = useState<PastedImage[]>([]);
+  const [isFileDialogOpen, setIsFileDialogOpen] = useState(false); // NEW: Track file dialog state


just removing extra comments that we may not need

Suggested change

const [isFileDialogOpen, setIsFileDialogOpen] = useState(false); // NEW: Track file dialog state

const [isFileDialogOpen, setIsFileDialogOpen] = useState(false);

blackgirlbytes · 2025-11-14T18:58:52Z

ui/desktop/src/components/ChatInput.tsx

        <DirSwitcher className="mr-0" />
        <div className="w-px h-4 bg-border-default mx-2" />

+        {/* Attach button now disables when dialog is open */}


i think we may not need this comment either

Suggested change

{/* Attach button now disables when dialog is open */}

Abhijay007 · 2025-11-14T19:06:17Z

.gitignore


 # Goose self-test artifacts
 gooseselftest/
+.cargo/


You can remove this change

Signed-off-by: Lymah123 <[email protected]>

Abhijay007 · 2025-11-20T14:38:44Z

ui/desktop/src/components/ChatInput.tsx

          </TooltipTrigger>
-          <TooltipContent>Attach file or directory</TooltipContent>
+          <TooltipContent>
+            {isFileDialogOpen ? 'Dialog open...' : 'Attach file or directory'}


This here isn’t working, when a button is disabled, radix UI tooltips don’t show on hover by default, so you might need to add an alternate fix for showing dialog is open or maybe just disable grey button is fine or you can show a disabled point there.

Also, when I’m in different tabs, I’m not able to open multiple dialogs, but that might be because we’re only fixing it for the chat input, so maybe we can ignore that for now

Ok, I will look into it.

DOsinga · 2025-12-04T16:19:53Z

I merged the other one since that didn't have a conflict, but I believe the approach is the same, so thanks!

Lymah123 added 3 commits November 7, 2025 04:41

docs: add blog post on configuring goose for team environments

5a780a9

Signed-off-by: Lymah123 <[email protected]>

docs: Managing goose Configurations Across Multiple Projects

225194d

Signed-off-by: Lymah123 <[email protected]>

fix: prevent multiple file picker dialogs on double-click

81a5478

Signed-off-by: Lymah123 <[email protected]>

Copilot AI review requested due to automatic review settings November 8, 2025 12:22

Lymah123 requested a review from a team as a code owner November 8, 2025 12:22

Copilot AI reviewed Nov 8, 2025

View reviewed changes

DOsinga requested changes Nov 10, 2025

View reviewed changes

alexhancock reviewed Nov 12, 2025

View reviewed changes

Lymah123 force-pushed the bug branch 2 times, most recently from f8fed0c to a5434b9 Compare November 13, 2025 02:55

Lymah123 requested a review from DOsinga November 13, 2025 02:56

Abhijay007 reviewed Nov 14, 2025

View reviewed changes

Abhijay007 requested changes Nov 14, 2025

View reviewed changes

Lymah123 force-pushed the bug branch 2 times, most recently from 419d128 to 3691122 Compare November 14, 2025 16:22

Lymah123 requested review from Abhijay007 and alexhancock November 14, 2025 16:25

blackgirlbytes reviewed Nov 14, 2025

View reviewed changes

Abhijay007 reviewed Nov 14, 2025

View reviewed changes

.gitignore Outdated

# Goose self-test artifacts

gooseselftest/

.cargo/

Copy link
Copy Markdown

Collaborator

Abhijay007 Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this change

docs: Managing goose Configurations Across Multiple Projects

0d52b7c

Signed-off-by: Lymah123 <[email protected]>

Lymah123 force-pushed the bug branch from 3691122 to 0d52b7c Compare November 14, 2025 19:45

Lymah123 requested review from Abhijay007 and blackgirlbytes November 14, 2025 19:46

Abhijay007 requested changes Nov 20, 2025

View reviewed changes

The-Best-Codes mentioned this pull request Nov 28, 2025

5527 multiple file popups #5905

Merged

10 tasks

DOsinga closed this Dec 4, 2025

	const [isFileDialogOpen, setIsFileDialogOpen] = useState(false); // NEW: Track file dialog state
	const [isFileDialogOpen, setIsFileDialogOpen] = useState(false);

Conversation

Lymah123 commented Nov 8, 2025

Summary

Type of Change

AI Assistance

Testing

Related Issues

Screenshots/Demos (for UX changes)

Submitting a Recipe?

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

Lymah123 commented Nov 8, 2025

Uh oh!

DOsinga left a comment

Choose a reason for hiding this comment

Uh oh!

Lymah123 commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DOsinga commented Nov 11, 2025

Uh oh!

Lymah123 commented Nov 11, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Abhijay007 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DOsinga commented Dec 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Lymah123 commented Nov 11, 2025 •

edited

Loading

Abhijay007 left a comment •

edited

Loading