Rewrite extension management tools by angelahning · Pull Request #5057 · block/goose

angelahning · 2025-10-07T18:52:59Z

Summary

This PR refactors extension management tools from being hardcoded in the Agent into a proper platform extension (ExtensionManagerClient), allowing it to be enabled/disabled like any other extension.

Type of Change

Testing

Manually tested on UI and CLI

Related Issues

Addesses #2331

Screenshots/Demos (for UX changes)

Before:

After:
Agent should not have access to the extension management tools when the extension_manager extension is disabled

Re-enabled the extension, agent can now autonomously discover and enable/disable tools.

DOsinga · 2025-10-08T18:29:11Z

closes #5068

DOsinga

Three things spring out;

We need to update the system prompt so that we no longer refer to this
the router stuff seems intimately related to this, so shouldn't that be part of the platform-tool-ification too?
how do we test this?

DOsinga · 2025-10-11T15:06:24Z

clippy-baselines/too_many_lines.txt

 crates/goose/src/agents/agent.rs::create_recipe
 crates/goose/src/agents/agent.rs::reply_internal
 crates/goose/src/agents/extension_manager.rs::add_extension
+crates/goose/src/agents/extension_manager_extension.rs::manage_extensions_impl


hmm, this seems a bit suspicious; this is a new file, no? these exceptions are only supposed to be for pre-existing things

DOsinga · 2025-10-11T15:08:50Z

crates/goose-cli/src/commands/configure.rs

        .filter(|tool| {
-            tool.name != PLATFORM_LIST_RESOURCES_TOOL_NAME
-                && tool.name != PLATFORM_READ_RESOURCE_TOOL_NAME
+            tool.name != LIST_RESOURCES_TOOL_NAME && tool.name != READ_RESOURCE_TOOL_NAME


I think we no longer want this. was always odd

DOsinga · 2025-10-11T15:13:20Z

crates/goose/src/agents/extension.rs

        /// The name used to identify this extension
        name: String,
        description: String,
+        display_name: Option<String>, // needed for the UI


why do we need this for the UI?

DOsinga · 2025-10-11T15:14:36Z

crates/goose/src/agents/extension_manager_extension.rs

+use tracing::error;
+
+pub static EXTENSION_NAME: &str = "extensionmanager";
+pub static DISPLAY_NAME: &str = "Extension Manager";


Why do we need both?

somewhere in the code keeps modify the name "Extension Manager" to "extensionmanager", and then failing with a Unknown platform extension error. I spent sometime figuring out why that is, and decided it is faster to just add a display name like the built-ins.

yeah, I don't think that's a good reason. having names and display names is in general a recipe for confusion and mismatches, if we can't track them down ourselves that's even worse.

i will track it down

DOsinga · 2025-10-11T15:14:55Z

crates/goose/src/agents/extension_manager_extension.rs

+    OperationFailed { message: String },
+}
+
+// Tool name constants


that's not very informative

DOsinga · 2025-10-11T15:17:48Z

crates/goose/src/agents/extension_manager_extension.rs

+        Use this tool when you're unable to find a specific feature or functionality you need to complete your task, or when standard approaches aren't working.
+        These extensions might provide the exact tools needed to solve your problem.
+        If you find a relevant one, consider using your tools to enable it.".to_string(),
+                object!({


this feels really brittle - we have had issues with wrong json schema here. @jamadeo & @alexhancock is there a better way?

DOsinga · 2025-10-11T15:19:54Z

crates/goose/src/agents/extension_manager_extension.rs

+            SEARCH_AVAILABLE_EXTENSIONS_TOOL_NAME => self
+                .handle_search_available_extensions()
+                .await
+                .map_err(|e| ExtensionManagerToolError::OperationFailed {


does returns a different type of error. any reason for that? if not, I think you could just collapse this thing and have result be future that you then await and map error

DOsinga · 2025-10-11T15:21:24Z

crates/goose/src/permission/permission_inspector.rs

                    }
                    // 4. Special case for extension management
-                    else if tool_name == PLATFORM_MANAGE_EXTENSIONS_TOOL_NAME {
+                    else if tool_name == MANAGE_EXTENSIONS_TOOL_NAME {


ui/desktop/src/components/settings/extensions/subcomponents/ExtensionList.tsx

DOsinga · 2025-10-11T15:27:51Z

crates/goose/src/agents/router_tools.rs

-use super::platform_tools::{
-    PLATFORM_LIST_RESOURCES_TOOL_NAME, PLATFORM_MANAGE_EXTENSIONS_TOOL_NAME,
-    PLATFORM_READ_RESOURCE_TOOL_NAME, PLATFORM_SEARCH_AVAILABLE_EXTENSIONS_TOOL_NAME,
+use crate::agents::extension_manager_extension::{


shouldn't this tool also be part of the extension_manager_extension? if you disable the extension_manager_extension_manager_manager, this will just be confusing to the agent

I will add it.

On second thought, the router tools should be separate from the extension_manager_extension. These tools are used for picking tools from an extension for a user query. And they should continue to work even if user disables the dynamic loading of extensions. So we should make that a separate extension.

DOsinga · 2025-10-11T20:02:23Z

closes #2331

angelahning · 2025-10-16T16:57:43Z

updated system prompt
added unit tests
the router stuff should be its own tool, not migrated in this PR
fixed existing bug in UI where it was mutating the extenstion name

Signed-off-by: Angela Ning <[email protected]>

* 'main' of github.com:block/goose: (22 commits) Rewrite extension management tools (#5057) fix: re-sync package-lock.json (#5235) docs: Hacktoberfest MCP youtube short entry to community-content.json (#5150) feat: add schedule button to recipe entries (#5217) Autocompact threshold UI cleanup (#5232) fix: correct schema for openai tools (#5229) Break compaction back into check_ and do_ compaction (#5212) fix: revert built app name to uppercase Goose (#5206) feat: add Code Documentation Generator recipe (#5121) (#5125) Revert "feat: enhance goose to search sessions for easy recall (#5177)" (#5209) Blog: Best Practices for Prompt Engineering with goose (#5204) force WAL sync after session create (#5202) Feat: goose Apify MCP integration docs (#5047) feat: enhance goose to search sessions for easy recall (#5177) Skip hidden & real format (#5194) docs: Hacktoberfest blog submission - Best Practices for Using Goose in Enterprise Environments by Anudhyan Datta. (#5184) docs: prompt injection detection (#5193) Fix mcp large response race condition (#5065) Compaction overhaul (#5186) fix: #3960 better approach to input schema for dynamic task params (#5189) ...

* main: delete flaky pricing integration tests (block#5207) chore: upgrade most npm packages to latest (block#5185) Release/1.11.0 (block#5224) Rewrite extension management tools (block#5057) fix: re-sync package-lock.json (block#5235) docs: Hacktoberfest MCP youtube short entry to community-content.json (block#5150) feat: add schedule button to recipe entries (block#5217) Autocompact threshold UI cleanup (block#5232) fix: correct schema for openai tools (block#5229) Break compaction back into check_ and do_ compaction (block#5212) fix: revert built app name to uppercase Goose (block#5206) feat: add Code Documentation Generator recipe (block#5121) (block#5125)

This reverts commit bccfa01.

* main: Standardize Session Name Attribute (#5085) Docs: Include step-by-step model configuration instructions for first… (#5239) Delete message visibility filter (#5216) delete flaky pricing integration tests (#5207) chore: upgrade most npm packages to latest (#5185) Release/1.11.0 (#5224) Rewrite extension management tools (#5057) fix: re-sync package-lock.json (#5235) docs: Hacktoberfest MCP youtube short entry to community-content.json (#5150) feat: add schedule button to recipe entries (#5217) Autocompact threshold UI cleanup (#5232) fix: correct schema for openai tools (#5229)

* origin/main: (66 commits) Revert "Rewrite extension management tools" (#5243) Standardize Session Name Attribute (#5085) Docs: Include step-by-step model configuration instructions for first… (#5239) Delete message visibility filter (#5216) delete flaky pricing integration tests (#5207) chore: upgrade most npm packages to latest (#5185) Release/1.11.0 (#5224) Rewrite extension management tools (#5057) fix: re-sync package-lock.json (#5235) docs: Hacktoberfest MCP youtube short entry to community-content.json (#5150) feat: add schedule button to recipe entries (#5217) Autocompact threshold UI cleanup (#5232) fix: correct schema for openai tools (#5229) Break compaction back into check_ and do_ compaction (#5212) fix: revert built app name to uppercase Goose (#5206) feat: add Code Documentation Generator recipe (#5121) (#5125) Revert "feat: enhance goose to search sessions for easy recall (#5177)" (#5209) Blog: Best Practices for Prompt Engineering with goose (#5204) force WAL sync after session create (#5202) Feat: goose Apify MCP integration docs (#5047) ...

* main: (32 commits) turn off WAL (#5203) Skip subagents for gemini (#5257) Revert "Standardize Session Name Attribute" (#5250) improve provider request logging a bit (#5236) Fix OpenAI empty choices panic (#5248) Revert "Rewrite extension management tools" (#5243) Standardize Session Name Attribute (#5085) Docs: Include step-by-step model configuration instructions for first… (#5239) Delete message visibility filter (#5216) delete flaky pricing integration tests (#5207) chore: upgrade most npm packages to latest (#5185) Release/1.11.0 (#5224) Rewrite extension management tools (#5057) fix: re-sync package-lock.json (#5235) docs: Hacktoberfest MCP youtube short entry to community-content.json (#5150) feat: add schedule button to recipe entries (#5217) Autocompact threshold UI cleanup (#5232) fix: correct schema for openai tools (#5229) Break compaction back into check_ and do_ compaction (#5212) fix: revert built app name to uppercase Goose (#5206) ...

* 'main' of github.com:block/goose: Rewrite extension management tools (#5057) fix: re-sync package-lock.json (#5235) docs: Hacktoberfest MCP youtube short entry to community-content.json (#5150) feat: add schedule button to recipe entries (#5217) Autocompact threshold UI cleanup (#5232) fix: correct schema for openai tools (#5229)

Signed-off-by: Angela Ning <[email protected]> Signed-off-by: vietbui99 <[email protected]>

angelahning force-pushed the aning/plat-ext branch from da55282 to a25dc3a Compare October 7, 2025 23:19

DOsinga mentioned this pull request Oct 8, 2025

Surface the platform built in tools as MCP extensions, to support disabling them #5068

Closed

1 task

angelahning marked this pull request as ready for review October 8, 2025 19:29

angelahning requested a review from DOsinga October 8, 2025 20:10

DOsinga approved these changes Oct 11, 2025

View reviewed changes

angelahning force-pushed the aning/plat-ext branch 4 times, most recently from 3980020 to 7078a98 Compare October 16, 2025 14:51

angelahning added 18 commits October 16, 2025 14:44

add extension manager tools

9ec935b

before i fix the Error: Extension manager not available in context

d7815da

fixed the error

a7fd191

seemingly working drsft

6982feb

working

a710bc7

remove extension tools from plat tools

4279e77

cli is working

3dfe773

improve error handling

e4c074b

rebased

9d7616a

share extensions with subagent

0d7706e

fix display name

daf6b4a

address comments

14bce51

add unit tests

5234e4c

fmt

244ee8a

address comments

8d94e5d

create tool params schema

e578c70

fix tests

75c072a

remove platform ext display name

3575b53

angelahning added 3 commits October 16, 2025 14:44

fix tests

9e9c1f1

generate api spec

9b654dc

rebase issueS

e448c2b

angelahning force-pushed the aning/plat-ext branch 2 times, most recently from a73c170 to 92b1dd5 Compare October 17, 2025 18:12

Merge branch 'main' into aning/plat-ext

e00e84e

Signed-off-by: Angela Ning <[email protected]>

angelahning force-pushed the aning/plat-ext branch from 92b1dd5 to e00e84e Compare October 17, 2025 18:13

angelahning merged commit bccfa01 into main Oct 17, 2025
11 checks passed

angelahning deleted the aning/plat-ext branch October 17, 2025 18:22

wpfleger96 added a commit that referenced this pull request Oct 17, 2025

Revert "Rewrite extension management tools (#5057)"

85b32bd

This reverts commit bccfa01.

wpfleger96 mentioned this pull request Oct 17, 2025

Revert "Rewrite extension management tools" #5243

Merged

zanesq mentioned this pull request Oct 27, 2025

Enable/Disable Platform tools #2331

Closed

1 task

vietbui1999ru pushed a commit to vietbui1999ru/goose that referenced this pull request Oct 31, 2025

Rewrite extension management tools (block#5057)

af5c18f

Signed-off-by: Angela Ning <[email protected]> Signed-off-by: vietbui99 <[email protected]>

Conversation

angelahning commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Related Issues

Screenshots/Demos (for UX changes)

Uh oh!

DOsinga commented Oct 8, 2025

Uh oh!

DOsinga left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

angelahning Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DOsinga commented Oct 11, 2025

Uh oh!

angelahning commented Oct 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

angelahning commented Oct 7, 2025 •

edited

Loading

angelahning Oct 15, 2025 •

edited

Loading