Merged
Conversation
Contributor
|
blackgirlbytes
requested changes
Sep 25, 2025
Collaborator
blackgirlbytes
left a comment
There was a problem hiding this comment.
Looks fine except should we be changing the github action workflows? or am i missing information where it's fine to change these?
blackgirlbytes
approved these changes
Sep 25, 2025
angiejones
commented
Sep 25, 2025
f4db203 to
0f58b3c
Compare
angiejones
commented
Sep 26, 2025
66742f2 to
ab62b86
Compare
- Update build configuration (package.json, forge.config.ts) to use lowercase productName and binary names - Update all GitHub CI/CD workflows to use lowercase directory and executable names: - Windows: Goose.exe → goose.exe, Goose-win32-x64 → goose-win32-x64 - macOS: Goose.app → goose.app, Goose-darwin-* → goose-darwin-* - Linux: Goose-linux-x64 → goose-linux-x64 - Update documentation (BUILDING_LINUX.md, README files) with lowercase paths and executable names - Update test files with lowercase path references for Windows and macOS builds - Update API provider headers and user agents to use lowercase 'goose' in: - snowflake.rs, tetrate.rs, openrouter.rs, computercontroller/mod.rs - Update launcher script (goose-gui.sh) with lowercase paths and executable names - Update all user-facing download links and installation instructions This ensures consistent lowercase naming across the entire codebase and build pipeline while maintaining full backward compatibility and functionality.
fix missing quote
removed extra param
ce5479a to
440ed2a
Compare
michaelneale
added a commit
that referenced
this pull request
Sep 29, 2025
This reverts commit 2032c70.
HikaruEgashira
pushed a commit
to HikaruEgashira/goose
that referenced
this pull request
Oct 3, 2025
Signed-off-by: HikaruEgashira <[email protected]>
This was referenced Oct 8, 2025
Closed
zanesq
added a commit
that referenced
this pull request
Oct 16, 2025
PR #4832 lowercased 'Goose' everywhere, but this is causing issues: - Case-sensitive filesystems breaking CI workflows - Shortcuts and integrations expecting uppercase name - Inconsistent with platform conventions (macOS .app bundles) This commit reverts only the built application names to use uppercase 'Goose' while keeping the lowercase branding in documentation and user-facing text. Changes: - ui/desktop/package.json: productName back to 'Goose' - All workflow files: paths and artifact names use Goose-* format - macOS: Goose.app instead of goose.app - Windows: Goose.exe instead of goose.exe - Artifact names: Goose-darwin-arm64, Goose-darwin-x64, Goose-win32-x64, Goose-linux-x64 This ensures compatibility with existing tooling and platform expectations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changing occurrences of Goose to goose - first pass