Skip to content

lowercase g in goose#4832

Merged
angiejones merged 8 commits intomainfrom
lowercase-g
Sep 27, 2025
Merged

lowercase g in goose#4832
angiejones merged 8 commits intomainfrom
lowercase-g

Conversation

@angiejones
Copy link
Copy Markdown
Collaborator

changing occurrences of Goose to goose - first pass

@angiejones angiejones requested a review from a team as a code owner September 25, 2025 19:59
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 25, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-09-27 04:45 UTC

Copy link
Copy Markdown
Collaborator

@blackgirlbytes blackgirlbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine except should we be changing the github action workflows? or am i missing information where it's fine to change these?

@blackgirlbytes blackgirlbytes self-requested a review September 25, 2025 21:26
- Update build configuration (package.json, forge.config.ts) to use lowercase productName and binary names
- Update all GitHub CI/CD workflows to use lowercase directory and executable names:
  - Windows: Goose.exe → goose.exe, Goose-win32-x64 → goose-win32-x64
  - macOS: Goose.app → goose.app, Goose-darwin-* → goose-darwin-*
  - Linux: Goose-linux-x64 → goose-linux-x64
- Update documentation (BUILDING_LINUX.md, README files) with lowercase paths and executable names
- Update test files with lowercase path references for Windows and macOS builds
- Update API provider headers and user agents to use lowercase 'goose' in:
  - snowflake.rs, tetrate.rs, openrouter.rs, computercontroller/mod.rs
- Update launcher script (goose-gui.sh) with lowercase paths and executable names
- Update all user-facing download links and installation instructions

This ensures consistent lowercase naming across the entire codebase and build pipeline
while maintaining full backward compatibility and functionality.
removed extra param
@angiejones angiejones merged commit 2032c70 into main Sep 27, 2025
11 of 12 checks passed
@angiejones angiejones deleted the lowercase-g branch September 27, 2025 04:44
michaelneale added a commit that referenced this pull request Sep 29, 2025
HikaruEgashira pushed a commit to HikaruEgashira/goose that referenced this pull request Oct 3, 2025
zanesq added a commit that referenced this pull request Oct 16, 2025
PR #4832 lowercased 'Goose' everywhere, but this is causing issues:
- Case-sensitive filesystems breaking CI workflows
- Shortcuts and integrations expecting uppercase name
- Inconsistent with platform conventions (macOS .app bundles)

This commit reverts only the built application names to use uppercase 'Goose'
while keeping the lowercase branding in documentation and user-facing text.

Changes:
- ui/desktop/package.json: productName back to 'Goose'
- All workflow files: paths and artifact names use Goose-* format
- macOS: Goose.app instead of goose.app
- Windows: Goose.exe instead of goose.exe
- Artifact names: Goose-darwin-arm64, Goose-darwin-x64, Goose-win32-x64, Goose-linux-x64

This ensures compatibility with existing tooling and platform expectations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants