Fix #4612: Return non-zero exit code when CLI session ends with error#4621
Merged
DOsinga merged 1 commit intoblock:mainfrom Sep 29, 2025
Merged
Fix #4612: Return non-zero exit code when CLI session ends with error#4621DOsinga merged 1 commit intoblock:mainfrom
DOsinga merged 1 commit intoblock:mainfrom
Conversation
When a session fails due to an error (e.g., invalid temperature parameter), the CLI now exits with code 1 instead of 0. This allows scripts and automation tools to properly detect when goose encounters an error. Previously, the error was only printed to stderr but the process would exit successfully with code 0, making it impossible to detect failures in automated environments. Fixes block#4612 Signed-off-by: jalateras <[email protected]>
jalateras
force-pushed
the
fix/cli-exit-code-on-error
branch
from
2eb04a2 to
c4c4dfa
Compare
DOsinga
approved these changes
Sep 12, 2025
zanesq
added a commit
that referenced
this pull request
Sep 30, 2025
…-unification * 'main' of github.com:block/goose: (24 commits) feat(cli): add `path` & `limit` to `session list` command (#4878) Allow better concurrent access (#4896) fix: Windows prompt cursor positioning issue with ANSI escape sequences (#4464) Fix: LiteLLM API key field not showing in UI configuration (#4105) fix: path is duplicated on tool calls causing them to fail (#4658) (#4859) add new prompt to get all available tutorials (#4802) Add filtering for agentVisible: false messages on streaming providers (#4847) alexhancock/mcp-crate-cleanup (#4885) docs: rename sub-recipe to subrecipe (#4886) docs: new multi-model section with autopilot topic (#4864) make agent manager singleton (#4880) Cli web auth token (#4456) fix(token_counter): fix panic with GitHub Copilot (#4632) Revert "Internal MCP Crate Cleanup (#4800)" (#4883) remove 2 redundant comments and one that lies (#4866) Internal MCP Crate Cleanup (#4800) Fix #4612: Return non-zero exit code when CLI session ends with error (#4621) Dead code cleanup (#4873) fix: restoring test data and correcting name (#4875) Add .goosehints file to enforce lowercase branding in documentation (#4870) ...
HikaruEgashira
pushed a commit
to HikaruEgashira/goose
that referenced
this pull request
Oct 3, 2025
…error (block#4621) Signed-off-by: jalateras <[email protected]> Signed-off-by: HikaruEgashira <[email protected]>
This was referenced Oct 8, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the CLI to properly return a non-zero exit code (1) when a session ends with an error, allowing scripts and CI/CD pipelines to detect failures.
Problem
When the goose CLI encounters an error during a session (such as an invalid temperature parameter), it prints the error message to stderr but still exits with code 0. This makes it impossible for automated scripts to detect when goose has failed.
Solution
Added
std::process::exit(1)after printing the error message when a session fails. This ensures the process exits with a non-zero status code that scripts can detect.Changes
crates/goose-cli/src/cli.rsto callstd::process::exit(1)whensession.interactive()returns an errorTesting
cargo build --package goose-clicargo test --package goose-cliExample
Before this fix:
After this fix:
Fixes #4612