Feat: Let providers configure a fast model for summarization#4228
Merged
Feat: Let providers configure a fast model for summarization#4228
Conversation
Kvadratni
reviewed
Aug 20, 2025
DOsinga
approved these changes
Aug 20, 2025
crates/goose/src/providers/openai.rs
Outdated
| let model = get_model(&json_response); | ||
| emit_debug_trace(model_config, &payload, &json_response, &usage); | ||
| Ok((message, ProviderUsage::new(model, usage))) | ||
| } |
Collaborator
There was a problem hiding this comment.
this was previously existing, but now that we pass in the model, no need to fish it out of the json response
Contributor
Author
There was a problem hiding this comment.
Got rid of it, but confused by this one since we already had the model name from before the request?
crates/goose/src/providers/openai.rs
Outdated
| ) -> Result<(Message, ProviderUsage), ProviderError> { | ||
| // Use the fast model (gpt-4o-mini) for fast completions | ||
| let mut fast_config = self.model.clone(); | ||
| fast_config.model_name = OPEN_AI_FAST_MODEL.to_string(); |
Collaborator
There was a problem hiding this comment.
make this a method on config - config.for_fast_model() should return a copy of itself with the model_name swapped out for the smart model if that is available
DOsinga
reviewed
Aug 20, 2025
| config: CustomProviderConfig, | ||
| ) -> Result<Self> { | ||
| // Set the default fast model for Anthropic | ||
| model.fast_model = Some("claude-3-5-haiku-latest".to_string()); |
Collaborator
There was a problem hiding this comment.
you don't want to do this - custom_config means it is a provider that speaks anthropic but isn't. they will not have this model
Contributor
Author
There was a problem hiding this comment.
ack. Done + applied to openAI/google.
| pub fn from_env(model: ModelConfig) -> Result<Self> { | ||
| pub fn from_env(mut model: ModelConfig) -> Result<Self> { | ||
| // Set the default fast model for Anthropic | ||
| model.fast_model = Some("claude-3-5-haiku-latest".to_string()); |
Collaborator
There was a problem hiding this comment.
make that into a constant on top - ideally we'd do this in a more elegant way, but let's do that later. don't make this mutable though, but have something like model = model.with_fast(CONSTANT) - possibly also check whether that is already set and don't overwrite it
Contributor
Author
There was a problem hiding this comment.
done + applied to openAI/google
crates/goose/src/providers/base.rs
Outdated
| /// | ||
| /// # Errors | ||
| /// ProviderError | ||
| /// - It's important to raise ContextLengthExceeded correctly since agent handles it |
Collaborator
There was a problem hiding this comment.
what are these comments? they repeat the existing comments which are now out of date demonstrating why we shouldn't have them in the first place
crates/goose/src/providers/base.rs
Outdated
| /// - It's important to raise ContextLengthExceeded correctly since agent handles it | ||
| async fn complete_with_model( | ||
| &self, | ||
| model: &str, |
Collaborator
There was a problem hiding this comment.
this should be modelConfig, not model. if you pass a string but then you need model config, you're going to create one yourself
| async fn complete( | ||
| async fn complete_with_model( | ||
| &self, | ||
| _model: &str, |
katzdave
changed the title
* 'main' of github.com:block/goose: chore: upgrade rmcp to 0.6.0 (#4243) doc: uvx not npx (#4240) Add PKCE support for Tetrate Agent Router Service (#4165) Read AGENTS.md by default (#4232) docs: configure provider and model (#4235) docs: add figma tutorial (#4231) Add Nix flake for reproducible builds (#4213) Enhanced onboarding page visual design (#4156) feat: adds mtls to all providers (#2794) (#2799) Don't show a confirm dialog for quitting (#4225) Fix: Missing smart_approve in CLI /mode help text and error message (#4132)
lifeizhou-ap
added a commit
that referenced
this pull request
Aug 22, 2025
* main: (108 commits) Remove unused game (#4226) fix issue where app redirects to home after initialization but user has already started a chat (#4260) Feat: Let providers configure a fast model for summarization (#4228) docs: update tool selection strategy (#4258) feat: upgrade `@mcp-ui/client` package and improve UI message handling (#4164) stop replacing chat window when changing working directory (#4200) Only fetch session tokens when chat state is idle to avoid resetting during streaming (#4104) bump timeouts for e2e tests (#4251) docs: custom context files improvements (#4096) chore: upgrade rmcp to 0.6.0 (#4243) doc: uvx not npx (#4240) Add PKCE support for Tetrate Agent Router Service (#4165) Read AGENTS.md by default (#4232) docs: configure provider and model (#4235) docs: add figma tutorial (#4231) Add Nix flake for reproducible builds (#4213) Enhanced onboarding page visual design (#4156) feat: adds mtls to all providers (#2794) (#2799) Don't show a confirm dialog for quitting (#4225) Fix: Missing smart_approve in CLI /mode help text and error message (#4132) ...
michaelneale
added a commit
that referenced
this pull request
Aug 22, 2025
* main: docs: update View/Edit Recipe menu item name (#4267) Remove unused game (#4226) fix issue where app redirects to home after initialization but user has already started a chat (#4260) Feat: Let providers configure a fast model for summarization (#4228) docs: update tool selection strategy (#4258) feat: upgrade `@mcp-ui/client` package and improve UI message handling (#4164) stop replacing chat window when changing working directory (#4200) Only fetch session tokens when chat state is idle to avoid resetting during streaming (#4104) bump timeouts for e2e tests (#4251) docs: custom context files improvements (#4096) chore: upgrade rmcp to 0.6.0 (#4243) doc: uvx not npx (#4240) Add PKCE support for Tetrate Agent Router Service (#4165) Read AGENTS.md by default (#4232) docs: configure provider and model (#4235)
michaelneale
added a commit
that referenced
this pull request
Aug 22, 2025
* main: (42 commits) feat: Add message queue system with interruption handling (#4179) Start extensions concurrently (#4234) Add X-Title and referer headers on exchange to tetrate (#4250) docs: update View/Edit Recipe menu item name (#4267) Remove unused game (#4226) fix issue where app redirects to home after initialization but user has already started a chat (#4260) Feat: Let providers configure a fast model for summarization (#4228) docs: update tool selection strategy (#4258) feat: upgrade `@mcp-ui/client` package and improve UI message handling (#4164) stop replacing chat window when changing working directory (#4200) Only fetch session tokens when chat state is idle to avoid resetting during streaming (#4104) bump timeouts for e2e tests (#4251) docs: custom context files improvements (#4096) chore: upgrade rmcp to 0.6.0 (#4243) doc: uvx not npx (#4240) Add PKCE support for Tetrate Agent Router Service (#4165) Read AGENTS.md by default (#4232) docs: configure provider and model (#4235) docs: add figma tutorial (#4231) Add Nix flake for reproducible builds (#4213) ...
Merged
shellz-n-stuff
pushed a commit
to shellz-n-stuff/goose
that referenced
this pull request
Aug 27, 2025
) Signed-off-by: Alex Rosenzweig <[email protected]>
dorien-koelemeijer
pushed a commit
to dorien-koelemeijer/goose
that referenced
this pull request
Sep 2, 2025
) Signed-off-by: Dorien Koelemeijer <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.