Move To-Do Tool to Session Scope from Agent Scope by tlongwell-block · Pull Request #4157 · block/goose

tlongwell-block · 2025-08-18T15:20:42Z

Overview

Refactors the TODO tool functionality from agent-scoped (shared across all sessions) to session-scoped (isolated per session). This change provides better data isolation, persistence, and user experience by ensuring each session maintains its own independent TODO list.

Key Changes

Architecture

Removed agent-level TODO storage (Arc<Mutex<String>> from Agent struct)
Added session-level TODO storage (todo_content: Option<String> in SessionMetadata)
Implemented session-aware TODO tool dispatch methods with proper error handling

Session Storage

Enhanced SessionMetadata with todo_content field
Added backward-compatible deserializer for existing sessions
TODO content now persists with session data in .jsonl files

Tool Behavior

TODO read/write operations now require active session context
Character limits still enforced via GOOSE_TODO_MAX_CHARS environment variable
Graceful error handling when no session context is available

Benefits

🔒 Data Isolation

Each session maintains its own TODO list, preventing cross-contamination between different conversations or users.

💾 Persistence

TODO lists survive agent restarts and are automatically saved/restored with session data.

🔄 Backward Compatibility

Existing sessions without TODO content continue to work seamlessly with empty TODO lists.

🧪 Robust Testing

Comprehensive integration test suite covering persistence, isolation, concurrency, and edge cases.

Breaking Changes

TODO tools now require session context and will error if called without it
Agent-scoped TODO data is not migrated (sessions start with empty TODO lists)

Files Changed

crates/goose/src/agents/agent.rs - Core TODO dispatch logic
crates/goose/src/session/storage.rs - Session metadata enhancement
crates/goose/tests/todo_session_integration.rs - New integration tests
crates/goose/tests/todo_tools_test.rs - Removed (agent-scoped tests)
Various test files updated for new metadata structure

Testing

✅ Session isolation and persistence
✅ Character limit enforcement
✅ Special character handling
✅ Concurrent access scenarios
✅ Backward compatibility
✅ Error handling edge cases

This change significantly improves the user experience by providing persistent, isolated TODO lists that follow session boundaries rather than being shared across the entire agent lifecycle.

katzdave

Looks good, did some testing! Love that now I can pick up my todo list when resuming a session, can we just reduce the branching.

One other thing I noticed is the TODO: READ tool doesn't return any data, which provides a poor experience when resuming a session. Is that an easy fix? If not can follow up with that later.

Also when you pull in main again, make sure to flip it back on, #4158 disabled it.

crates/goose/src/agents/agent.rs

katzdave

Nice job! Excited to have this back.

katzdave · 2025-08-20T18:21:22Z

crates/goose/src/agents/agent.rs

            // Add task planner tools
-            // TODO: Re-enable after next release
-            // prefixed_tools.extend([todo_read_tool(), todo_write_tool()]);
+            prefixed_tools.extend([todo_read_tool(), todo_write_tool()]);


katzdave · 2025-08-20T18:23:15Z

crates/goose/src/session/storage.rs

            accumulated_input_tokens: Option<i32>,
            accumulated_output_tokens: Option<i32>,
            working_dir: Option<PathBuf>,
+            todo_content: Option<String>, // For backward compatibility


Assuming this lets us load old sessions from before this feature?

github-actions · 2025-08-21T16:25:31Z

PR Preview Action v1.6.0
🚀 View preview at https://block.github.io/goose/pr-preview/pr-4157/
Built to branch `gh-pages` at 2025-08-21 16:24 UTC. Preview will be ready when the GitHub Pages deployment is complete.

dianed-square

Hi @tlongwell-block -- this appears to be overwriting recent /documentation changes that were merged into main

tlongwell-block · 2025-08-21T17:52:28Z

Oh boy. Goose borked this branch something fierce. I'll patch it up. Just a minute

michaelneale · 2025-08-22T01:51:38Z

lending my 👍 my support to this, as I really think we are missing out on this (I think that failure needs to run a just command to update the spec)

crates/goose/src/context_mgmt/auto_compact.rs

* main: docs: Plan tutorial (#4309) Extensions Modal Improvements (#4293) docs: fixed cicd tutorial pipeline in docs (#4223) Read oltp config from config and env (#4292) release/1.6.0 (#4280) docs: fix broken links in Docker tutorial (#4285) Remove half-second wait, rework auto submit (#4282) Block send until extensions are ready (#4271) fix: improve OpenAI-compatible error handling and add test coverage (#4175) Move To-Do Tool to Session Scope from Agent Scope (#4157) fix: recipe params not being replaced all the time (#4207) chore: removing little-used session sharing feature (#4249) Stop auto scrolling when agent responds and let scroll area handle scrolling to bottom (#4257) restore cli projects from accidental removal during cleanup (#4266) Fix: deep link extension installation to show dialog for headers configuration (#4150)

* main: (24 commits) feat: autovisualiser of structured data with mcp-ui (#4153) docs: Plan tutorial (#4309) Extensions Modal Improvements (#4293) docs: fixed cicd tutorial pipeline in docs (#4223) Read oltp config from config and env (#4292) release/1.6.0 (#4280) docs: fix broken links in Docker tutorial (#4285) Remove half-second wait, rework auto submit (#4282) Block send until extensions are ready (#4271) fix: improve OpenAI-compatible error handling and add test coverage (#4175) Move To-Do Tool to Session Scope from Agent Scope (#4157) fix: recipe params not being replaced all the time (#4207) chore: removing little-used session sharing feature (#4249) Stop auto scrolling when agent responds and let scroll area handle scrolling to bottom (#4257) restore cli projects from accidental removal during cleanup (#4266) Fix: deep link extension installation to show dialog for headers configuration (#4150) feat: Add message queue system with interruption handling (#4179) Start extensions concurrently (#4234) Add X-Title and referer headers on exchange to tetrate (#4250) docs: update View/Edit Recipe menu item name (#4267) ...

Signed-off-by: Alex Rosenzweig <[email protected]>

Signed-off-by: Dorien Koelemeijer <[email protected]>

tlongwell-block mentioned this pull request Aug 18, 2025

Clean up agent state between sessions #4126

Closed

tlongwell-block requested a review from katzdave August 18, 2025 17:11

tlongwell-block marked this pull request as ready for review August 18, 2025 17:11

tlongwell-block requested a review from alexhancock August 18, 2025 17:12

tlongwell-block changed the title ~~Session scoped todo~~ Move To-Do Tool to Session Scope from Agent Scope Aug 18, 2025

katzdave reviewed Aug 19, 2025

View reviewed changes

crates/goose/src/agents/agent.rs Outdated Show resolved Hide resolved

crates/goose/src/agents/agent.rs Outdated Show resolved Hide resolved

crates/goose/src/agents/agent.rs Outdated Show resolved Hide resolved

katzdave approved these changes Aug 20, 2025

View reviewed changes

tlongwell-block force-pushed the session_scoped_todo branch from b0bec9b to 9f34d74 Compare August 21, 2025 16:22

tlongwell-block requested a review from a team as a code owner August 21, 2025 16:22

dianed-square suggested changes Aug 21, 2025

View reviewed changes

tlongwell-block force-pushed the session_scoped_todo branch 2 times, most recently from b0bec9b to 31a20e6 Compare August 21, 2025 17:51

tlongwell-block force-pushed the session_scoped_todo branch from 31a20e6 to b0bec9b Compare August 21, 2025 18:29

dianed-square approved these changes Aug 21, 2025

View reviewed changes

DOsinga reviewed Aug 22, 2025

View reviewed changes

crates/goose/src/context_mgmt/auto_compact.rs Outdated Show resolved Hide resolved

fix branch history

eb0f557

tlongwell-block force-pushed the session_scoped_todo branch from 6139bfd to eb0f557 Compare August 22, 2025 14:07

tlongwell-block added 2 commits August 22, 2025 10:21

mock provider

9249206

cleaner comment

cad427b

tlongwell-block merged commit b16741d into main Aug 22, 2025
11 checks passed

tlongwell-block deleted the session_scoped_todo branch August 22, 2025 14:53

shellz-n-stuff pushed a commit to shellz-n-stuff/goose that referenced this pull request Aug 27, 2025

Move To-Do Tool to Session Scope from Agent Scope (block#4157)

6d8d7f8

Signed-off-by: Alex Rosenzweig <[email protected]>

This was referenced Aug 27, 2025

chore(release): release version 1.7.0 #4372

Closed

chore(release): release version 1.7.0 #4391

Merged

dorien-koelemeijer pushed a commit to dorien-koelemeijer/goose that referenced this pull request Sep 2, 2025

Move To-Do Tool to Session Scope from Agent Scope (block#4157)

7db0d49

Signed-off-by: Dorien Koelemeijer <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move To-Do Tool to Session Scope from Agent Scope#4157

Move To-Do Tool to Session Scope from Agent Scope#4157
tlongwell-block merged 3 commits intomainfrom
session_scoped_todo

tlongwell-block commented Aug 18, 2025 •

edited

Loading

Uh oh!

katzdave left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

katzdave left a comment

Uh oh!

katzdave Aug 20, 2025

Uh oh!

katzdave Aug 20, 2025

Uh oh!

tlongwell-block Aug 22, 2025

Uh oh!

github-actions bot commented Aug 21, 2025

Built to branch `gh-pages` at 2025-08-21 16:24 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

dianed-square left a comment

Uh oh!

tlongwell-block commented Aug 21, 2025

Uh oh!

michaelneale commented Aug 22, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

tlongwell-block commented Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Key Changes

Architecture

Session Storage

Tool Behavior

Benefits

🔒 Data Isolation

💾 Persistence

🔄 Backward Compatibility

🧪 Robust Testing

Breaking Changes

Files Changed

Testing

Uh oh!

katzdave left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

katzdave left a comment

Choose a reason for hiding this comment

Uh oh!

katzdave Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

katzdave Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

tlongwell-block Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 21, 2025

Built to branch gh-pages at 2025-08-21 16:24 UTC. Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

dianed-square left a comment

Choose a reason for hiding this comment

Uh oh!

tlongwell-block commented Aug 21, 2025

Uh oh!

michaelneale commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tlongwell-block commented Aug 18, 2025 •

edited

Loading

Built to branch `gh-pages` at 2025-08-21 16:24 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

michaelneale commented Aug 22, 2025 •

edited

Loading