Conversation
Move hardcoded prompts from router_tool_selector.rs and permission_judge.rs
into reusable .md template files using the MiniJinja template system.
Changes:
- Add router_tool_selector.md template with {{tools}} and {{query}} variables
- Add permission_judge.md template for read-only operation detection
- Update router_tool_selector.rs to use render_global_file()
- Update permission_judge.rs to use render_global_file() with fallback
- Add proper error handling for template rendering failures
- All existing tests continue to pass
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
zanesq
reviewed
Aug 18, 2025
| /> | ||
| )); | ||
|
|
||
| if (!isOnboarding) { |
Contributor
There was a problem hiding this comment.
If you click reset providers button in settings it shows the onboarding version of the providers grid.
Why not show custom provider card in onboarding also?
zanesq
reviewed
Aug 18, 2025
Contributor
zanesq
left a comment
zanesq
left a comment
There was a problem hiding this comment.
Overall front end code lgtm. Couple of nits with the UI
- Required dots are not aligned with the label
- Can you vertically center the plus icon and text for add custom provider?
added 2 commits
August 19, 2025 13:43
added 2 commits
August 19, 2025 17:03
angiejones
approved these changes
Aug 19, 2025
zanesq
added a commit
that referenced
this pull request
Aug 19, 2025
…-visual-improvements * 'main' of github.com:block/goose: (21 commits) Custom providers update (#4099) docs: goose_terminal env var (#4205) Desktop alerts when suspicious unicode characters found in Recipe (#4080) chore: remove the google drive built-in extension (#4187) Move out app init (#4185) Remove unused extension stuff (#4166) Added tests for extensions functionality (#3794) chore(release): release version 1.5.0 (#4169) Fix tests from upstream changes and add testing to lint staged and ci (#4127) Unlist figma tutorial (#4186) feat(ui): Implement in-place message editing with re-response (#3798) Retry all 500 codes (#4160) blog: Transforming AI Assistance with Goose Mentor Mode (#4151) upgraded all npm packages and fixed related issues (#4072) Docs: @-mentions in goosehints (#4171) fix: consistent font sizing in ToolCallWithResponse (#4167) Temporarily disable TODO Tool (#4158) docs: add integrated MCP server config to jetbrains tutorial (#4120) docs: remove figma MCP from suggested servers (#4123) Blog: The AI Skeptic’s Guide to Context Windows (#4152) ...
1 task
ayax79
pushed a commit
to ayax79/goose
that referenced
this pull request
Aug 21, 2025
Co-authored-by: developerayo <[email protected]> Co-authored-by: Douwe Osinga <[email protected]> Co-authored-by: Claude <[email protected]> Co-authored-by: Zane Staggs <[email protected]> Signed-off-by: Jack Wright <[email protected]>
michaelneale
added a commit
that referenced
this pull request
Aug 21, 2025
* main: docs: add figma tutorial (#4231) Add Nix flake for reproducible builds (#4213) Enhanced onboarding page visual design (#4156) feat: adds mtls to all providers (#2794) (#2799) Don't show a confirm dialog for quitting (#4225) Fix: Missing smart_approve in CLI /mode help text and error message (#4132) Clean up langfuse docs and scripts (#4220) feat: add remark-breaks plugin to preserve single newlines in markdown (#4217) feat(mcp/developer): accept -1 for insert_line number (#4112) Remove dead code and old settings migration (#4180) removed tests from lint-staged (#4203) docs: openrouter and ollama easy desktop setup (#4195) Custom providers update (#4099) docs: goose_terminal env var (#4205) Desktop alerts when suspicious unicode characters found in Recipe (#4080) chore: remove the google drive built-in extension (#4187) Move out app init (#4185)
Contributor
|
Custom (OpenAI? but maybe also others) provider strips the port from the connection URL, so if you for example want to connect to the problem is at let host = if let Some(port) = url.port() {
format!("{}://{}:{}", url.scheme(), url.host_str().unwrap_or(""), port)
} else {
format!("{}://{}", url.scheme(), url.host_str().unwrap_or(""))
}; |
Merged
Collaborator
Author
|
thanks @vlascik - I see you already provided a fix! the only way to live |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a the combination of a bunch of PRs that allow custom providers