fix: update dictation settings handling and improve user feedback#4034
Closed
par5ul1 wants to merge 0 commit intoblock:mainfrom
Closed
fix: update dictation settings handling and improve user feedback#4034par5ul1 wants to merge 0 commit intoblock:mainfrom
par5ul1 wants to merge 0 commit intoblock:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During @mootrichard's demo today at Weaviate's Hack Night, he encountered a bug where, upon attempting to transcribe, an error toast was thrown and the current chat was locked, thus forcing him to open a new session.
This fixes that issue by stopping the transcription on error, therefore unlocking the UI.
This PR also introduces the concept of a
nullprovider for transcription, as the user is never onboarded, and picking OpenAI by default feels wrong, but so does hiding the feature away under settings without an indicator.