mcp: Move screen/window tools to computercontroller module#3976
mcp: Move screen/window tools to computercontroller module#3976cgwalters wants to merge 1 commit intoblock:mainfrom
Conversation
Move list_windows and screen_capture tools from the developer MCP to computercontroller. This is about making the developer MCP more focused. xref block#2830 Assisted-By: Claude Code Signed-off-by: Colin Walters <[email protected]>
| "text_editor" => this.text_editor(arguments).await, | ||
| "list_windows" => this.list_windows(arguments).await, | ||
| "screen_capture" => this.screen_capture(arguments).await, | ||
| "image_processor" => this.image_processor(arguments).await, |
There was a problem hiding this comment.
I wonder about this one. it seems rather related to screen_capture - refers to it, but I am also not sure about the logic in it. it converts images to PNG and resizes them even though my understanding is LLMs dont really care about screensizes anymore. so leave, move with or delete? maybe leave and improve (adding cropping would be useful or possibly just tell goose about imagemagick
There was a problem hiding this comment.
Yes, I too wondered about this one. Probably best to ping in #1515 ?
or possibly just tell goose about imagemagick
Yeah there's a ton of other tools available in this space.
Maybe in the short term we can just move this one to computercontroller too?
There was a problem hiding this comment.
Let's do it. I had been thinking about scanning for imagemagick, ffmpeg maybe pandoc, what have you and then say, hey these tools are installed go wild
There was a problem hiding this comment.
I took a look at this but it's a lot messier because the image_processor code uses a lot of the "handle .gooseignore" logic that is embedded in the developer MCP code.
It probably makes sense to factor that out into a sharable module, but it's more invasive. So let's get this one in as a preparatory step?
|
kicked of the checks so yeah, let's go for it |
|
are you all not worried about backwards compatibility? there may be existing recipes scheduled and running that only have Developer extension enabled and rely on these tools |
|
@angiejones agree it's a concern. I guess honestly we could get 75% of the value here by just splitting up developer/mod.rs without actually moving where tools are. So I'll look at that instead. |
3 participants
Move list_windows and screen_capture tools from the developer MCP to computercontroller. This is about making the developer MCP more focused.
xref #2830
Assisted-By: Claude Code