Merged
Conversation
alexhancock
approved these changes
Aug 1, 2025
Collaborator
alexhancock
left a comment
alexhancock
left a comment
There was a problem hiding this comment.
Nice. The code LGTM. My only Q would be if there is a test that needs to be/could be updated - or a new one.
Collaborator
Author
|
yeah good question about the testing. this is specific to the api call - we don't do a lot of testing on these routes. this one in particular would be a lot of mocking for little gain |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we were returning a 404 for missing keys in the server which is the not found code, so not unreasonable. except that the client expects null for not found, so made it so. now no more 404s showing up in the developer console.
fixes #3679
fixes #3551