Skip to content

Feature : Updated Langfuse Integration#3401

Closed
bclarkngc wants to merge 16 commits intoblock:mainfrom
bclarkngc:feature/langfuse-settings-and-view
Closed

Feature : Updated Langfuse Integration#3401
bclarkngc wants to merge 16 commits intoblock:mainfrom
bclarkngc:feature/langfuse-settings-and-view

Conversation

@bclarkngc
Copy link
Copy Markdown

@bclarkngc bclarkngc commented Jul 14, 2025

In this MR:

This MR adds a desktop and configuration file process to using Langfuse. You can now enabled/disable Langfuse observability in the desktop application or with configuration file parameters. Option for using self hosted Langfuse deployment. Configuration file parameters can be set for LANGFUSE_SECRET_KEY, LANGFUSE_PUBLIC_KEY and LANGFUSE_URL.

[Added]

  • File: ui/desktop/src/components/settings/langfuse/LangfuseSection.tsx
    Description: Langfuse settings. This can be enabled or disabled with private/secret keys. Optional to enabled use with self deployment of Langfuse.
  • File: ui/desktop/src/components/icons/Langfuse.tsx
    Description: Langfuse svg icon.

[Updated]

  • File: crates/goose/src/tracing/langfuse_layer.rs
    Description: Added additional input from user configuration to current parameter fallbacks.
  • File: ui/desktop/src/components/icons/index.tsx
    Description: Enabled Langfuse icon option.
  • File: ui/desktop/src/components/more_menu/MoreMenu.tsx
    Description: Add Langfuse portal link when Observability is enabled.
  • File: ui/desktop/src/components/settings/SettingsView.tsx
    Description: Add Langfuse Observability settings
  • File: crates/goose/src/tracing/observation_layer.rs
    Description: Add sessionId tracking
  • File: crates/goose/src/tracing/langfuse_layer.rs
    Description: Add name param passthrough to create_langfuse_observer

@webbrandon
Copy link
Copy Markdown

Sharing screenshots of updated interface views when Langfuse Observability is enabled:

Screenshot 2025-07-14 at 10 14 50 AM Screenshot 2025-07-14 at 10 15 07 AM

@bclarkngc bclarkngc force-pushed the feature/langfuse-settings-and-view branch from 2719d74 to a8ecaaf Compare July 16, 2025 16:28
@bclarkngc
Copy link
Copy Markdown
Author

I see you updated the interfaces. I have an update but am on a closed system. Will update commit shortly.

@bclarkngc bclarkngc force-pushed the feature/langfuse-settings-and-view branch from fdb044a to df4e2d9 Compare July 17, 2025 19:18
Signed-off-by: Brandon Clark <[email protected]>
@bclarkngc bclarkngc force-pushed the feature/langfuse-settings-and-view branch from 876f095 to f632038 Compare July 17, 2025 19:23
Signed-off-by: Brandon Clark <[email protected]>
@bclarkngc bclarkngc force-pushed the feature/langfuse-settings-and-view branch from adb0bde to 6946354 Compare July 17, 2025 21:24
@webbrandon
Copy link
Copy Markdown

Updated UI: new images
Screenshot 2025-07-17 at 2 28 12 PM
Screenshot 2025-07-17 at 2 27 45 PM

@angiejones
Copy link
Copy Markdown
Collaborator

Updated UI: new images Screenshot 2025-07-17 at 2 28 12 PM Screenshot 2025-07-17 at 2 27 45 PM

  1. can we remove it from the bottom bar on the main view?
  2. within Settings, when it is disabled, are the fields hidden?

@bclarkngc
Copy link
Copy Markdown
Author

Updated UI: new images Screenshot 2025-07-17 at 2 28 12 PM Screenshot 2025-07-17 at 2 27 45 PM

  1. can we remove it from the bottom bar on the main view?
  2. within Settings, when it is disabled, are the fields hidden?
  1. I can add a toggle to enable disable that.
  2. Yes when the toggle is disabled the fields are hidden.

@bclarkngc bclarkngc force-pushed the feature/langfuse-settings-and-view branch from c6e5d1a to 91e6489 Compare July 23, 2025 02:00
Signed-off-by: Brandon Clark <[email protected]>
@bclarkngc bclarkngc force-pushed the feature/langfuse-settings-and-view branch from c9c0566 to 9716cc5 Compare July 23, 2025 02:05
@bclarkngc bclarkngc force-pushed the feature/langfuse-settings-and-view branch from 9716cc5 to c499243 Compare July 23, 2025 02:16
@bclarkngc
Copy link
Copy Markdown
Author

Updated from main and need to resolve something


let mut session_id = self.name.clone();
session_id.push_str("-");
session_id.push_str(trace_id.clone().as_str());
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate a bit more on why we need 'name'? It appears like its an environment that maybe you are looking to filter on?

What's the problem this is looking to solve?

I'm not that familiar with the langfuse code but I didn't think the trace_id is the same as the session id is it?

I'm concerned about this duplicating 'traceId' which is already being sent in the events.

</Tooltip>
<div className="w-px h-4 bg-border-default mx-2" />
</>
)}
Copy link
Copy Markdown
Contributor

@jsibbison-square jsibbison-square Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be adding this element to the main chat window. Its not something that will be used by the majority of users and that bottom bar is precious space.

I think it would be ok to have an 'open' link in the langfuse settings section you have created.

I understand that its hidden behind the menu icon setting but its more things we need to maintain and we cannot cater for all the possible UI preferences people may desire imo.

@bclarkngc
Copy link
Copy Markdown
Author

bclarkngc commented Aug 5, 2025 via email

@zanesq
Copy link
Copy Markdown
Contributor

zanesq commented Aug 22, 2025

Still in progress?

@DOsinga
Copy link
Copy Markdown
Collaborator

DOsinga commented Sep 19, 2025

closing this for now due to non activity - we can reopen if needed of course

@DOsinga DOsinga closed this Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants