Feature : Updated Langfuse Integration#3401
Conversation
Signed-off-by: bclarkngc <[email protected]>
Signed-off-by: bclarkngc <[email protected]>
2719d74 to
a8ecaaf
Compare
|
I see you updated the interfaces. I have an update but am on a closed system. Will update commit shortly. |
Signed-off-by: Brandon Clark <[email protected]>
fdb044a to
df4e2d9
Compare
Signed-off-by: Brandon Clark <[email protected]>
876f095 to
f632038
Compare
Signed-off-by: Brandon Clark <[email protected]>
adb0bde to
6946354
Compare
Signed-off-by: Brandon Clark <[email protected]>
Signed-off-by: Brandon Clark <[email protected]>
Signed-off-by: Brandon Clark <[email protected]>
c6e5d1a to
91e6489
Compare
Signed-off-by: Brandon Clark <[email protected]>
c9c0566 to
9716cc5
Compare
Signed-off-by: Brandon Clark <[email protected]>
9716cc5 to
c499243
Compare
ui/desktop/src/components/settings/langfuse/LangfuseSection.tsx
Outdated
Show resolved
Hide resolved
|
Updated from main and need to resolve something |
|
|
||
| let mut session_id = self.name.clone(); | ||
| session_id.push_str("-"); | ||
| session_id.push_str(trace_id.clone().as_str()); |
There was a problem hiding this comment.
Can you elaborate a bit more on why we need 'name'? It appears like its an environment that maybe you are looking to filter on?
What's the problem this is looking to solve?
I'm not that familiar with the langfuse code but I didn't think the trace_id is the same as the session id is it?
I'm concerned about this duplicating 'traceId' which is already being sent in the events.
| </Tooltip> | ||
| <div className="w-px h-4 bg-border-default mx-2" /> | ||
| </> | ||
| )} |
There was a problem hiding this comment.
I don't think we should be adding this element to the main chat window. Its not something that will be used by the majority of users and that bottom bar is precious space.
I think it would be ok to have an 'open' link in the langfuse settings section you have created.
I understand that its hidden behind the menu icon setting but its more things we need to maintain and we cannot cater for all the possible UI preferences people may desire imo.
|
[like] Clark, Brandon L [US] (AS) reacted to your message:
________________________________
From: Jarrod Sibbison ***@***.***>
Sent: Tuesday, August 5, 2025 12:12:56 PM
To: block/goose ***@***.***>
Cc: Clark, Brandon L [US] (AS) ***@***.***>; Author ***@***.***>
Subject: EXT :Re: [block/goose] Feature : Updated Langfuse Integration (PR #3401)
@jsibbison-square commented on this pull request.
________________________________
In ui/desktop/src/components/ChatInput.tsx<#3401 (comment)>:
+ <div className="w-px h-4 bg-border-default mx-2" />
+ <Tooltip>
+ <TooltipTrigger asChild>
+ <button
+ type="button"
+ className="flex items-center justify-center text-text-default/70 hover:text-text-default text-xs cursor-pointer transition-colors"
+ onClick={openLangfuse}
+ >
+ <Langfuse className="w-4 h-4" />
+ </button>
+ </TooltipTrigger>
+ <TooltipContent>Observe in Langfuse</TooltipContent>
+ </Tooltip>
+ <div className="w-px h-4 bg-border-default mx-2" />
+ </>
+ )}
I don't think we should be adding this element to the main chat window. Its not something that will be used by the majority of users and that bottom bar is precious space.
I think it would be ok to have an 'open' link in the langfuse settings section you have created.
—
Reply to this email directly, view it on GitHub<#3401 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BEZHIGP4JWTAQ4IILASBLVT3MCNURAVCNFSM6AAAAACBOA5DWKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAOBYGAYTQNJTHE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Still in progress? |
|
closing this for now due to non activity - we can reopen if needed of course |






In this MR:
This MR adds a desktop and configuration file process to using Langfuse. You can now enabled/disable Langfuse observability in the desktop application or with configuration file parameters. Option for using self hosted Langfuse deployment. Configuration file parameters can be set for
LANGFUSE_SECRET_KEY,LANGFUSE_PUBLIC_KEYandLANGFUSE_URL.[Added]
Description: Langfuse settings. This can be enabled or disabled with private/secret keys. Optional to enabled use with self deployment of Langfuse.
Description: Langfuse svg icon.
[Updated]
Description: Added additional input from user configuration to current parameter fallbacks.
Description: Enabled Langfuse icon option.
Description: Add Langfuse portal link when Observability is enabled.
Description: Add Langfuse Observability settings
Description: Add sessionId tracking
Description: Add name param passthrough to create_langfuse_observer