fix: handle mac screenshots with the image tool#1622
Merged
Conversation
ahau-square
approved these changes
Mar 11, 2025
Contributor
ahau-square
left a comment
ahau-square
left a comment
There was a problem hiding this comment.
nice, tried it out and working for me!
kalvinnchau
reviewed
Mar 11, 2025
| .ok_or_else(|| ToolError::InvalidParameters("Missing 'path' parameter".into()))?; | ||
|
|
||
| let path = self.resolve_path(path_str)?; | ||
| let normalized_path = self.normalize_mac_screenshot_path(&path); |
Contributor
There was a problem hiding this comment.
should we do something like
#[cfg(target_os = "macos")]or something that only runs this logic on mac and just skips this step in linux/windows?
Collaborator
Author
There was a problem hiding this comment.
yea, that makes sense
Comment on lines
+838
to
+843
| if path.exists() && path != new_path { | ||
| if let Err(e) = std::fs::rename(path, &new_path) { | ||
| eprintln!("Warning: Failed to normalize Mac screenshot filename: {}", e); | ||
| return path.to_path_buf(); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
don't think we need the rename anymore? or did we change our mind here?
zakiali
force-pushed
the
zaki/fix-screenshot-spacing
branch
3 times, most recently
from
84c4376 to
3627975
Compare
zakiali
force-pushed
the
zaki/fix-screenshot-spacing
branch
from
3627975 to
c49b78a
Compare
Collaborator
|
nice catch! |
michaelneale
added a commit
that referenced
this pull request
Mar 11, 2025
* origin: docs: Persistent Command History (#1627) change to make build work on windows, macos, linux (#1618) chore(release): release version 1.0.13 (#1623) fix: handle mac screenshots with the image tool (#1622) feat: write eval results to eval dir (#1620) [fix] fix model config logging to remove api key (#1619) fix: ensure repeating benches return to initial run-dir (#1617)
ahau-square
pushed a commit
that referenced
this pull request
May 2, 2025
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.