Merged
Conversation
lily-de
commented
Mar 11, 2025
...p/src/components/settings_v2/providers/modal/subcomponents/handlers/DefaultSubmitHandler.tsx
Outdated
Show resolved
Hide resolved
lily-de
force-pushed
the
ldelalande/auto-update-card-upon-config
branch
from
57ce3b2 to
e248167
Compare
lily-de
commented
Mar 11, 2025
| @@ -338,26 +338,50 @@ pub async fn providers( | |||
| fn check_provider_configured(metadata: &ProviderMetadata) -> bool { | |||
Contributor
Author
There was a problem hiding this comment.
would love an eye on this function in particular -- does this make sense for how we consider a provider is configured or not given that the various permutations of key types (required vs not, has a default to fall back to vs doesn't)
lily-de
commented
Mar 11, 2025
...p/src/components/settings_v2/providers/modal/subcomponents/handlers/DefaultSubmitHandler.tsx
Outdated
Show resolved
Hide resolved
yingjiehe-xyz
approved these changes
Mar 11, 2025
michaelneale
approved these changes
Mar 11, 2025
Collaborator
michaelneale
left a comment
michaelneale
left a comment
There was a problem hiding this comment.
nice attention to details, should be much more friendly now.
ahau-square
pushed a commit
that referenced
this pull request
May 2, 2025
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a lag in configuring a new provider getting the green checkmark
before:
now:
also fixed a bug where providers with a combo of required keys with no defaults + required keys with defaults (like openai) weren't being registered as configured)