feat[#1540]: Base changes for cli list sessions by parkeregli · Pull Request #1586 · block/goose

parkeregli · 2025-03-09T15:36:32Z

I just reused what the ui was using to get the session list and then added a subcommand for "goose session". It checks to see if the subcommand is list and if not runs goose session as normal. I also added an example for arguments such as -v.

salman1993 · 2025-03-10T15:43:07Z

crates/goose-cli/src/commands/session.rs

@@ -0,0 +1,33 @@
+use anyhow::Result;
+
+pub fn handle_session(verbose: bool, format: String) -> Result<()> {


rename to handle_session_list

salman1993 · 2025-03-10T15:47:48Z

crates/goose-cli/src/commands/session.rs

+                    } else {
+                        println!("  {}", id);
+                    }
+                }


currently the output looks like this:

❯ goose session list Available sessions: 20250307_121402 20250307_122909 20250307_125332 20250307_125441 20250307_112710 20250307_121343 20250310_112933 20250307_112732 20250307_124641

i think it'd be nicer to do sth similar to what we have in goose-server routes:

goose/crates/goose-server/src/routes/session.rs

Lines 47 to 79 in fa9bb9e

let sessions = match session::list_sessions() {

Ok(sessions) => sessions,

Err(e) => {

tracing::error!("Failed to list sessions: {:?}", e);

return Err(StatusCode::INTERNAL_SERVER_ERROR);

}

};

let session_infos = sessions

.into_iter()

.map(|(id, path)| {

// Get last modified time as string

let modified = path

.metadata()

.and_then(|m| m.modified())

.map(|time| {

chrono::DateTime::<chrono::Utc>::from(time)

.format("%Y-%m-%d %H:%M:%S UTC")

.to_string()

})

.unwrap_or_else(|_| "Unknown".to_string());

// Get session description

let metadata = session::read_metadata(&path).expect("Failed to read session metadata");

SessionInfo {

id,

path: path.to_string_lossy().to_string(),

modified,

metadata,

}

})

.collect();

then we can print sth like this:

[session_name] - [description] - [modified date]

salman1993

thanks for contributing. requested few changes on how sessions get listed

parkeregli · 2025-03-10T16:07:13Z

thanks for contributing. requested few changes on how sessions get listed

Thanks for the review! I tried to keep it simple and figured there would be some changes that needed to be made. I'll get working on the changes ASAP

…o be reused

parkeregli · 2025-03-10T22:25:52Z

I made the requested changes by @salman1993 as well as some code maintainability changes. I held off on the --quiet flag as I want this initial scope to get into main and then we can start adding flags as needed

salman1993

this is great!

* main: feat(google_drive): move credentials into keychain, add optional fallback (#1603) feat: add session list command in cli (#1586)

Base changes for cli list sessions

48e1b51

parkeregli mentioned this pull request Mar 9, 2025

CLI option to list available sessions #1540

Closed

lily-de requested a review from salman1993 March 9, 2025 17:50

salman1993 reviewed Mar 10, 2025

View reviewed changes

salman1993 requested changes Mar 10, 2025

View reviewed changes

Updating CLI output to match UI and making info module for sessions t…

9b2b32c

…o be reused

parkeregli requested a review from salman1993 March 10, 2025 22:27

Resolving merge conflicts

f830814

salman1993 approved these changes Mar 12, 2025

View reviewed changes

salman1993 merged commit d6cb7c6 into block:main Mar 12, 2025
6 checks passed

kalvinnchau added a commit that referenced this pull request Mar 12, 2025

Merge branch 'main' into kalvin/google-drive-pkce

f2ab799

* main: feat(google_drive): move credentials into keychain, add optional fallback (#1603) feat: add session list command in cli (#1586)

ahau-square pushed a commit that referenced this pull request May 2, 2025

feat: add session list command in cli (#1586)

90fec05

cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Jul 20, 2025

feat: add session list command in cli (block#1586)

8615703

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat[#1540]: Base changes for cli list sessions#1586

feat[#1540]: Base changes for cli list sessions#1586
salman1993 merged 3 commits intoblock:mainfrom
parkeregli:1540-CLI_LIST_SESSIONS

parkeregli commented Mar 9, 2025

Uh oh!

salman1993 Mar 10, 2025

Uh oh!

salman1993 Mar 10, 2025

Uh oh!

salman1993 left a comment

Uh oh!

parkeregli commented Mar 10, 2025

Uh oh!

parkeregli commented Mar 10, 2025

Uh oh!

salman1993 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -0,0 +1,33 @@
		use anyhow::Result;

		pub fn handle_session(verbose: bool, format: String) -> Result<()> {

	let sessions = match session::list_sessions() {
	Ok(sessions) => sessions,
	Err(e) => {
	tracing::error!("Failed to list sessions: {:?}", e);
	return Err(StatusCode::INTERNAL_SERVER_ERROR);
	}
	};

	let session_infos = sessions
	.into_iter()
	.map(\|(id, path)\| {
	// Get last modified time as string
	let modified = path
	.metadata()
	.and_then(\|m\| m.modified())
	.map(\|time\| {
	chrono::DateTime::<chrono::Utc>::from(time)
	.format("%Y-%m-%d %H:%M:%S UTC")
	.to_string()
	})
	.unwrap_or_else(\|_\| "Unknown".to_string());

	// Get session description
	let metadata = session::read_metadata(&path).expect("Failed to read session metadata");

	SessionInfo {
	id,
	path: path.to_string_lossy().to_string(),
	modified,
	metadata,
	}
	})
	.collect();

Conversation

parkeregli commented Mar 9, 2025

Uh oh!

salman1993 Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

salman1993 Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

salman1993 left a comment

Choose a reason for hiding this comment

Uh oh!

parkeregli commented Mar 10, 2025

Uh oh!

parkeregli commented Mar 10, 2025

Uh oh!

salman1993 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants