fix: fix summarize agent, use session_id and add provider fn#1552
Merged
kalvinnchau merged 1 commit intomainfrom Mar 6, 2025
Merged
fix: fix summarize agent, use session_id and add provider fn#1552kalvinnchau merged 1 commit intomainfrom
kalvinnchau merged 1 commit intomainfrom
Conversation
| let session_file = session::get_path(session_id); | ||
| let mut metadata = session::read_metadata(&session_file)?; | ||
| metadata.total_tokens = usage.usage.total_tokens; | ||
| // The message count is the number of messages in the session + 1 for the response |
Contributor
There was a problem hiding this comment.
is it always true? right now we may have broken session(it got cancelled before response)
Contributor
Author
There was a problem hiding this comment.
ah that's how the existing truncate agent handles it (this is a copy paste for a new summarize agent)
yingjiehe-xyz
approved these changes
Mar 6, 2025
lily-de
pushed a commit
that referenced
this pull request
Mar 6, 2025
michaelneale
added a commit
that referenced
this pull request
Mar 7, 2025
* main: bugfix: refactor workdirs to be async-safe, and simpler (#1558) feat: split required_extensions in bench to builtin/external (#1547) fix: continue to use resumed session after confirmation is cancelled (#1548) feat: add image tool to developer mcp (#1515) docs: using gooseignore (#1554) ci: use cargo update --workspace to ensure Cargo.lock is updated (#1539) fix: respond to interrupted tool calls with a ToolResponseMessageContent (#1557) fix: get tool def back to chat mode (#1538) ui: add default icon (#1553) fix: fix summarize agent, use session_id and add provider fn (#1552) feat(agent): memory condensation for longer context (#1457) docs: goose tips blog (#1550) docs: update to provider view (#1546) docs: resuming sessions (#1543) feat: goose bench framework for functional and regression testing feat: use refresh_tokens from databricks api (#1517) feat: use Ctrl/Cmd + ↑/↓ to navigate message history (#1501) feat: remove tools from chat mode (#1533) feat: use dropdown for goose selection (#1531) docs: goosehints in desktop (#1529)
lily-de
pushed a commit
that referenced
this pull request
Mar 7, 2025
ahau-square
pushed a commit
that referenced
this pull request
May 2, 2025
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.