feat: work with docs/xls and simple html#1526
Merged
michaelneale merged 11 commits intomainfrom Mar 9, 2025
Merged
Conversation
lily-de
approved these changes
Mar 6, 2025
michaelneale
changed the title
Contributor
There was a problem hiding this comment.
PR Overview
This PR adds support for editing and creating simple presentations along with XLSX file processing by introducing two new tools: one for HTML-based slides and one for Excel spreadsheets.
- Introduces a presentation tool that creates and updates HTML presentations.
- Adds an XLSX tool for working with Excel files including worksheet listing, cell updates, and range querying.
- Updates Cargo.toml to include new dependencies (docx-rs, image, umya-spreadsheet) required for the new features.
Reviewed Changes
| File | Description |
|---|---|
| crates/goose-mcp/src/computercontroller/presentation_tool.rs | Implements presentation creation and slide addition functionalities using an HTML template. |
| crates/goose-mcp/src/computercontroller/xlsx_tool.rs | Provides XLSX file processing utilities such as worksheet info fetching, cell updates, and range extraction. |
| crates/goose-mcp/Cargo.toml | Adds new dependencies required by the presentation and XLSX tools. |
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
crates/goose-mcp/src/computercontroller/presentation_tool.rs:229
- The marker string is defined as a partial comment and may not exactly match the full marker in the HTML template, potentially leading to insertion issues. Consider defining the marker with the complete expected content from the template.
let marker = "<!-- ADD_SLIDES_HERE";
crates/goose-mcp/src/computercontroller/presentation_tool.rs:240
- Using a string replace to update the slide count may inadvertently modify unintended parts of the HTML if similar text exists elsewhere. Consider using a more targeted approach, such as regex matching or a specific template placeholder, to ensure only the intended slide count is updated.
html = html.replace(&format!("--num-slides: {}", current_slides), &format!("--num-slides: {}", new_count));
* main: bugfix: refactor workdirs to be async-safe, and simpler (#1558) feat: split required_extensions in bench to builtin/external (#1547) fix: continue to use resumed session after confirmation is cancelled (#1548) feat: add image tool to developer mcp (#1515) docs: using gooseignore (#1554) ci: use cargo update --workspace to ensure Cargo.lock is updated (#1539) fix: respond to interrupted tool calls with a ToolResponseMessageContent (#1557) fix: get tool def back to chat mode (#1538) ui: add default icon (#1553) fix: fix summarize agent, use session_id and add provider fn (#1552) feat(agent): memory condensation for longer context (#1457) docs: goose tips blog (#1550) docs: update to provider view (#1546) docs: resuming sessions (#1543) feat: goose bench framework for functional and regression testing feat: use refresh_tokens from databricks api (#1517) feat: use Ctrl/Cmd + ↑/↓ to navigate message history (#1501) feat: remove tools from chat mode (#1533) feat: use dropdown for goose selection (#1531) docs: goosehints in desktop (#1529)
salman1993
approved these changes
Mar 7, 2025
Contributor
|
the only awkward thing i noticed was the LLM at the end said: |
* main: feat: parallel processing in approve mode (#1575) Feat: support auto-including dirs in binary/bench-work-dir (#1576) refactor models component (#1535) docs: Add running Goose in CI tutorial (#1426) chore: remove logging of oauth config, just log where we output (#1573) feat: implement a tool permission store (#1516) minor typo (#1569) fix: open new session in working dir when hotkey is pressed (#1570) feat: store working directory for sessions (#1559) docs: extension timeout (#1567) fix: update openrouter referer website to point to github page site (#1566) feat(cli): add --debug flag to goose session / run (#1564)
alicehau
pushed a commit
that referenced
this pull request
Mar 10, 2025
alicehau
pushed a commit
that referenced
this pull request
Mar 10, 2025
ahau-square
pushed a commit
that referenced
this pull request
May 2, 2025
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using small libraries to allow editing of docx/xlxs files when they are referred, in the computer controller MCP
Also includes simple html presentation capability (no library needed)
addresses issue: #1527
this does add a couple of dependencies, a few MB added to goose binary (2-3MB out of 55M) - which will only be used when using CC MCP of course.
docs and spreadsheets:
presentations: