feat:skip read only tool approval#1371
Merged
yingjiehe-xyz merged 6 commits intomainfrom Feb 25, 2025
Merged
Conversation
wendytang
reviewed
Feb 25, 2025
wendytang
reviewed
Feb 25, 2025
| created: Utc::now().timestamp(), | ||
| content: vec![MessageContent::Text(TextContent { | ||
| text: format!( | ||
| "Here are the tool requests: {:?}\n\nDetect and list the tools with read-only operations.", |
There was a problem hiding this comment.
Could be more specific here in the prompt?
- What constitutes a read-only operation
- Examples of read vs write operations
- How to analyze the tool requests
Contributor
Author
There was a problem hiding this comment.
yeah, I tested with a detailed prompt and this simple prompt, right now both of them work, considering the cost, I start use the simple.
Let me revert it to previous one
wendytang
reviewed
Feb 25, 2025
ahau-square
pushed a commit
that referenced
this pull request
May 2, 2025
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We adopt llm as the judge to detect whether the tool call is read only or not. If it is read only, no need to ask for approval.
Test
export GOOSE_MODE=approve && cargo run --bin goose session,in the test case, we ask goose to write a file and then list the file, the write call asks for user approval while read doesn't