Skip to content

deprecate clippy-lint.sh #6271

@baxen

Description

@baxen

I was noticing in my goose sessions that running clippy-lint.sh while working on goose was my largest token user by a lot. I started looking at cleaning it up, and feel like it is mostly tech debt that we can just get rid of

With that in mind, I'm suggesting here that we set the clippy value for too-many-lines-threshold to 250, which leaves the code base only with 11 functions beyond that length.

Assuming no concerns, this issue will track the PRs to break up the largest functions, and once those are done will set the new config limit and remove the script

  • crates/goose-cli/src/cli.rs:953 - cli (557 lines) #6272
  • crates/goose-mcp/src/computercontroller/docx_tool.rs:88 - docx_tool (440 lines) #6273
  • crates/goose-cli/src/session/mod.rs:846 - process_agent_response (415 lines)
  • crates/goose-cli/src/session/builder.rs:243 - build_session (378 lines)
  • crates/goose/src/agents/agent.rs:875 - reply_internal (370 lines)
  • crates/goose-cli/src/commands/configure.rs:683 - configure_extensions_dialog (353 lines) #6277
  • crates/goose-mcp/src/computercontroller/pdf_tool.rs:5 - pdf_tool (313 lines)
  • crates/goose-cli/src/session/mod.rs:442 - interactive (275 lines) #6274
  • crates/goose/src/agents/extension_manager.rs:293 - add_extension (259 lines) #6278
  • crates/goose/src/providers/formats/databricks.rs:31 - format_messages (210 lines) #6275
  • crates/goose-cli/src/commands/configure.rs:32 - handle_configure (203 lines) #6276

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions