-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Desktop: Custom providers with empty API Key considered "not configured" #6047
Description
Describe the bug
CLI and Desktop handle "no auth required" custom providers differently. E.g. when creating an Ollama-compatible custom provider via CLI, users can press Enter to skip the API key prompt, which stores an empty string (""). This provider is then accessible in CLI, but Desktop's is_configured logic checks !s.is_empty(), causing these providers to appear "not configured" in the Desktop UI even though they're fully functional.
To Reproduce
- Run
goose configure - Select
Custom Providers>Add A Custom Provider - Choose
Ollama Compatibleas the API type - Enter provider details, and press
Enterto skip the API key prompt (leaving it empty) - Complete the setup
- Open goose Desktop > Settings > Models > Configure providers
- Observe that the custom provider does not have a green checkmark and appears "not configured", which means it won't show up in the providers list for selection
Expected behavior
Custom providers with empty API keys (valid for local/no-auth endpoints) should show as "configured" in Desktop if they were successfully created via CLI.
Screenshots
N/A
Please provide the following information
- OS & Arch: macOS
- Interface: CLI to create, UI to observe
- Version: v1.16.0
- Extensions enabled: N/A
- Provider & Model: Custom Ollama-compatible provider
Additional context
The issue appears to be in Desktop's is_configured logic, which checks !s.is_empty() for the API key. An empty string ("") is stored in the keychain when the user skips the prompt, which fails this check.
Possible solutions:
- CLI could store a placeholder value (e.g.,
"notrequired"like Desktop does) instead of empty string - Desktop could treat empty string as valid for Ollama-compatible providers
- Align on a convention for "no auth required" across both interfaces