Repository navigation
test(messages): restore + and 1) list-prefix rows - #812
Closed
salman1993 wants to merge 1 commit into
Closed
salman1993 wants to merge 1 commit into
salman1993 wants to merge 1 commit into
Conversation
#800 dropped these rows from the block-prefix table, but composer-blocks.ts PREFIX accepts + and ) and no other test types either form. Removing them from PREFIX now fails exactly these two rows. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Salman Mohammed <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Restore two block-prefix rows that #800 removed:
+(bullet list) and1)(ordered list), inEditableInput.test.tsx"opens a block as the space of %j is typed, with one undo restoring the prefix".Follow-up to this review comment on #800.
composer-blocks.tsPREFIXexplicitly accepts+and), and after #800 no test typed either form, so dropping them from the regex would have passed CI.Non-goals: no production change, and the
•row stays removed (a separate test covers it).Validation
+and)temporarily removed fromPREFIX, exactly these two rows fail. Restoring the regex makes them pass again. The regex change was not committed.No browser cases added or removed. No human testing needed beyond review: this change is test-only.
🤖 Generated with Claude Code