Repository navigation
Conversation
Co-authored-by: Codex <[email protected]> Signed-off-by: Daniel Rouleau <[email protected]>
Co-authored-by: Codex <[email protected]> Signed-off-by: Daniel Rouleau <[email protected]>
Co-authored-by: Codex <[email protected]> Signed-off-by: Daniel Rouleau <[email protected]>
Co-authored-by: Codex <[email protected]> Signed-off-by: Daniel Rouleau <[email protected]>
Co-authored-by: Codex <[email protected]> Signed-off-by: Daniel Rouleau <[email protected]>
Co-authored-by: Codex <[email protected]> Signed-off-by: Daniel Rouleau <[email protected]>
gilgtm
approved these changes
Nov 14, 2026
gilgtm
left a comment
gilgtm
left a comment
Contributor
There was a problem hiding this comment.
🤖 No P0/P1 findings in the deep dual review at 337bfaf689aac46e92b93fdb786437708abaf348.
Posted by duel-review skill [driver: codex(high), mode: deep-dual, review synthesized by codex(high)]
joahg
added a commit
to joahg/buzz-app
that referenced
this pull request
Nov 14, 2026
* origin/main: (133 commits) Expose ordinary chats without workspace headings (block#3530) [2/2] feat(agents): offer Automatic (Recommended) in Create agent and Identity (block#3345) fix(solo): preserve and resume unsent chat drafts (block#3525) fix(builderlab): give refused app sign-ins and Identity links a route to Organization sign-in (block#3078) fix(agents): say why Import an agent can't import here, and link Manage plugins (block#3073) [1/2] feat(agents): add a recommended agent setup (core) (block#3344) test(browser): survive the live-stream restart a page-clock jump causes (block#3442) chore(renovate): hold rusqlite below 0.41 for mesh-llm (block#3438) test(browser): serve the diffs and CLI reload fixtures outside the navigation budget (block#3445) test(browser): play the draft clip at rate 0 instead of looping it before the Play click (block#3446) fix(status): reopen a status whose preset deadlines coincide as Today (block#3449) fix(messages): tolerate a cancelled reaction-name chunk load (block#3450) fix(pairing): tolerate /proc/net/tcp rows printed twice or missed (block#3451) test(browser): wait on the signal each test asserts in local-agent-activity and message-navigation (block#3444) Expose native channel headings to Solo sources (block#3523) test(browser-host): run the 100,000-channel broker scale check alone in the measurements lane (block#3447) fix(solo): keep every contributed destination action (block#3516) fix(identity): report an issuer that keeps rate-limiting an agent as a limit (block#2365) fix(identity): let a stuck at-launch sign-in copy its link (block#2453) fix(profiles): open avatar previews on hover in compact density (block#3510) ... Signed-off-by: Joah Gerstenberg <[email protected]> # Conflicts: # src/bundled/codex/prompt.test.ts # src/bundled/goose/runtime.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A Solo region plugin can include ordinary chats with
ui.Chats, but including chats from named workspaces also adds their workspace headings and frames. A source that groups its own content by status or time cannot show those chats as a plain list without losing access to filed chats.What
Add optional
ui.ChatListfor sources that compose workspaces. It shows filed and unfiled ordinary chats without workspace chrome. Menus, rename editors, pending saves, saved assignments, workspace order, and per-workspace pagination stay with the host.How
Reuse the existing row portals. Focus recovery uses the row’s current layout, then surviving list rows and the region heading. The list ignores saved collapse state for display and preserves that state when the source returns to workspaces. Existing
ui.Chatsbehavior is unchanged. Plugins can detectui.ChatListand useui.Chats({ all: true })on older hosts.Risk
The new API is inert unless a source uses it. Row focus and neighbor selection now account for the plain-list placement. The feature adds no relay reads or persistence writes.
Testing
The final head was checked in the actual shell with simulated data, using headless Chromium on macOS. Chromium checks cover filed and unfiled chats, Show more/Show less, row menus, rename/save, row identity across layouts, saved collapse state, and the older-host fallback. Visual inspection covers light and dark themes, narrow and wide widths, and 200% interface size.
The shipping review ran. The focus regression fails on the prior implementation and passes after the repair. The author approved the shown preview with “LGTM”. No separate hands-on human run was reported. The final browser check also covers keyboard row menus and Escape focus recovery. It reported no page errors. Native and real-relay validation are outside this presentation-only change. Browser cases added/removed: none; mounted component coverage owns the membership, pagination, and editor lifecycle contracts.
ui.Chats({ all: true })ui.ChatListbuzz-review-completed
Generated with Codex