Skip to content

perf(toast): scope docked clearance to the toast host - #3489

Merged
kalvinnchau merged 1 commit into
mainfrom
perf/channel-switch
Nov 13, 2026
Merged

perf(toast): scope docked clearance to the toast host#3489
kalvinnchau merged 1 commit into
mainfrom
perf/channel-switch

Conversation

@kalvinnchau

@kalvinnchau kalvinnchau commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Summary

useToastClearance published --buzz-toast-clearance on <html> from layout effects. Every channel switch unmounts and remounts the composer, so the variable changed about three times per switch. In WebKit a custom property change on the root restyles the whole document, and the next layout read in that commit (toast measurement, timeline position reads, composer mount focus) paid for a full recalculation. Rapid switching queued clicks behind ~400–700 ms main-thread blocks.

Changes

  • Toast.tsx: the clearance is written to Sonner's always-mounted <section> through the Toaster ref, which the toast stack inherits. Writes are coalesced into one microtask per commit and skipped when the value is unchanged, so a composer replaced by one of the same height writes nothing.
  • Toast.test.tsx: covers the host-scoped write, no write on same-height replacement, and reset to 0px when the docked surface leaves.
  • focus-navigation.spec.mjs: the clearance pin targets the toast host instead of :root.

Evidence

Headless WebKit against the app fixture, 20 warm channel switches, click to next frame:

median p90 root variable writes
before 301 ms 315 ms 60
after 57–68 ms 61–79 ms 0

Toast stack placement above the composer is unchanged (computed bottom matches before and after). Toast unit tests and the focus-navigation browser spec pass in Chromium and WebKit; pnpm check is clean.

🤖 Generated with Claude Code

@kalvinnchau @claude
perf(toast): scope docked clearance to the toast host
0a67b4b 
publish --buzz-toast-clearance on sonner's section via the toaster ref
instead of the document root, coalesce writes to one microtask per commit
and skip unchanged values. a root custom property restyled the whole
document on every composer mount and unmount, and the next layout read in
the same commit (toast measurement, timeline reads, composer focus) paid
for it. focus-navigation pins the variable on the toast host.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@kalvinnchau
kalvinnchau requested a review from a team as a code owner November 13, 2026 18:13
kazemek21
kazemek21 approved these changes Nov 13, 2026
View reviewed changes

@kazemek21 kazemek21 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the PR and went through the Nexus review-tracker notes. I didn't see any P2-or-higher issues in this change.

Posted by Codex (gpt-6.1-sol) on behalf of kylez

@kalvinnchau
kalvinnchau merged commit 6aa9271 into main Nov 13, 2026
66 checks passed
@kalvinnchau
kalvinnchau deleted the perf/channel-switch branch November 13, 2026 20:00
joshfriend added a commit that referenced this pull request Nov 13, 2026
@joshfriend
Merge remote-tracking branch 'origin/main' into plugins-panel-tab-title
ae2b7a0 
* origin/main: (153 commits)
  feat(agents): preview where interrupted agents were working before resume (#3494)
  perf(messages): close the editor and delete dialog on submit (#3493)
  feat(messages): quote selected message text into the composer (#2392)
  perf(toast): scope docked clearance to the toast host (#3489)
  fix(unread): undo exact captured ordinary reads conditionally (#3473)
  fix(solo): keep navigation responsive during chat deletion (#3488)
  fix(channels): keep custom thread tab names until the tab closes (#3458)
  perf(relay): verify cached history in the native host (#3426)
  fix(settings): refine claude and typesafe key setup dialogs (#3391)
  Update bundled help for Bestie and agent settings (#3194)
  feat(profiles): share and show a local time zone (#3332)
  Revert "feat(link-previews): unfurl web links below messages by default" (#3480)
  Show disabled plugin chats in Solo (#3456)
  perf(messages): host one context menu per message list (#3465)
  test(claude): keep the quit-release test copy above the minimum version (#3477)
  fix(profiles): restore verified names from the device cache (#3382)
  fix(mentions): show addressed agents first in Solo audience picker (#2856)
  perf: count member access once and scope find highlights to painting (#3464)
  perf(messages): prepare a message once for its renderer and link previews (#3466)
  fix(composer): speed up long pastes and paste office text as text (#3441)
  ...

# Conflicts:
#	docs/plugin-authoring-guide.md
joshfriend added a commit that referenced this pull request Nov 13, 2026
@joshfriend
Merge remote-tracking branch 'origin/main' into jfriend/github-merge-…
ab041fd 
…when-ready

* origin/main: (21 commits)
  fix(agents): report a conversation wake that fails before its turn starts (#2192)
  fix(usage): read Claude transcripts over 50 MB a page at a time (#3498)
  feat(agents): preview where interrupted agents were working before resume (#3494)
  perf(messages): close the editor and delete dialog on submit (#3493)
  feat(messages): quote selected message text into the composer (#2392)
  perf(toast): scope docked clearance to the toast host (#3489)
  fix(unread): undo exact captured ordinary reads conditionally (#3473)
  fix(solo): keep navigation responsive during chat deletion (#3488)
  fix(channels): keep custom thread tab names until the tab closes (#3458)
  perf(relay): verify cached history in the native host (#3426)
  fix(settings): refine claude and typesafe key setup dialogs (#3391)
  Update bundled help for Bestie and agent settings (#3194)
  feat(profiles): share and show a local time zone (#3332)
  Revert "feat(link-previews): unfurl web links below messages by default" (#3480)
  Show disabled plugin chats in Solo (#3456)
  perf(messages): host one context menu per message list (#3465)
  test(claude): keep the quit-release test copy above the minimum version (#3477)
  fix(profiles): restore verified names from the device cache (#3382)
  fix(mentions): show addressed agents first in Solo audience picker (#2856)
  perf: count member access once and scope find highlights to painting (#3464)
  ...
joshfriend added a commit that referenced this pull request Nov 13, 2026
@joshfriend
Merge remote-tracking branch 'origin/main' into jfriend/github-pr-ope…
1cc40d6 
…n-on-github

* origin/main: (21 commits)
  fix(agents): report a conversation wake that fails before its turn starts (#2192)
  fix(usage): read Claude transcripts over 50 MB a page at a time (#3498)
  feat(agents): preview where interrupted agents were working before resume (#3494)
  perf(messages): close the editor and delete dialog on submit (#3493)
  feat(messages): quote selected message text into the composer (#2392)
  perf(toast): scope docked clearance to the toast host (#3489)
  fix(unread): undo exact captured ordinary reads conditionally (#3473)
  fix(solo): keep navigation responsive during chat deletion (#3488)
  fix(channels): keep custom thread tab names until the tab closes (#3458)
  perf(relay): verify cached history in the native host (#3426)
  fix(settings): refine claude and typesafe key setup dialogs (#3391)
  Update bundled help for Bestie and agent settings (#3194)
  feat(profiles): share and show a local time zone (#3332)
  Revert "feat(link-previews): unfurl web links below messages by default" (#3480)
  Show disabled plugin chats in Solo (#3456)
  perf(messages): host one context menu per message list (#3465)
  test(claude): keep the quit-release test copy above the minimum version (#3477)
  fix(profiles): restore verified names from the device cache (#3382)
  fix(mentions): show addressed agents first in Solo audience picker (#2856)
  perf: count member access once and scope find highlights to painting (#3464)
  ...
joshfriend added a commit that referenced this pull request Nov 13, 2026
@joshfriend
Merge remote-tracking branch 'origin/main' into composer-focus-on-click
7b4e498 
* origin/main: (31 commits)
  Let plugin panels name their tab with panels.useTabTitle (#3251)
  fix(agents): report a conversation wake that fails before its turn starts (#2192)
  fix(usage): read Claude transcripts over 50 MB a page at a time (#3498)
  feat(agents): preview where interrupted agents were working before resume (#3494)
  perf(messages): close the editor and delete dialog on submit (#3493)
  feat(messages): quote selected message text into the composer (#2392)
  perf(toast): scope docked clearance to the toast host (#3489)
  fix(unread): undo exact captured ordinary reads conditionally (#3473)
  fix(solo): keep navigation responsive during chat deletion (#3488)
  fix(channels): keep custom thread tab names until the tab closes (#3458)
  perf(relay): verify cached history in the native host (#3426)
  fix(settings): refine claude and typesafe key setup dialogs (#3391)
  Update bundled help for Bestie and agent settings (#3194)
  feat(profiles): share and show a local time zone (#3332)
  Revert "feat(link-previews): unfurl web links below messages by default" (#3480)
  Show disabled plugin chats in Solo (#3456)
  perf(messages): host one context menu per message list (#3465)
  test(claude): keep the quit-release test copy above the minimum version (#3477)
  fix(profiles): restore verified names from the device cache (#3382)
  fix(mentions): show addressed agents first in Solo audience picker (#2856)
  ...
philazar added a commit that referenced this pull request Nov 13, 2026
@philazar
Merge remote-tracking branch 'origin/main' into coder3/identity-archi…
98159c5 
…ve-client

* origin/main:
  feat(solo): smooth chat recency reordering (#3502)
  Reject self-mentions that cannot wake another session (#3513)
  feat(status): offer don't clear for every status (#3515)
  Let plugin panels name their tab with panels.useTabTitle (#3251)
  fix(agents): report a conversation wake that fails before its turn starts (#2192)
  fix(usage): read Claude transcripts over 50 MB a page at a time (#3498)
  feat(agents): preview where interrupted agents were working before resume (#3494)
  perf(messages): close the editor and delete dialog on submit (#3493)
  feat(messages): quote selected message text into the composer (#2392)
  perf(toast): scope docked clearance to the toast host (#3489)
  fix(unread): undo exact captured ordinary reads conditionally (#3473)

Signed-off-by: Philip Azar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kazemek21 kazemek21 kazemek21 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kalvinnchau @kazemek21