Repository navigation
Bump block/buzz to pick up messages search --before - #3362
Conversation
Move the buzz-audio-client pin, which also selects the bundled buzz CLI revision, from c8d736642e1c to 0e6037c74d67 (block/buzz#9382). The bundled CLI gains `messages search --before` and `--before-id` for paging back through an author's messages. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Tim Mellor <[email protected]>
… rev All revisions shared target/buzz-cli-build. Cargo trusts an earlier build of a git checkout even after the revision changes, so after a pin bump it reused the old revision's buzz-cli and staged the old binary under the new revision's name. Each revision now builds in target/buzz-cli-build/<rev>. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Tim Mellor <[email protected]>
wpfleger96
left a comment
There was a problem hiding this comment.
🤖 LGTM. The pin bump is the only lock change, and keying the CLI build folder by revision fixes the stale-binary staging cleanly. I checked the shipped upstream range: the audio client's User-Agent default, messages search --before/--before-id, the desktop pairing ownership retry, and attachment-preserving messages edit.
Nonblocking FYI: the bundled CLI's messages edit now refuses on relays without the effective-edit lookup (block/buzz#9226). The production relays (bb-block, bb-public, bb-square) still run pre-0.3.0 images, so CLI edits will fail there until the relay deploy lands. The app's MCP edit already behaves this way since #2937, so this PR adds no new ordering constraint.
|
🤖 Thanks for the review. Agreed on the |
kazemek21
left a comment
There was a problem hiding this comment.
Kyle reviewed this PR and the Nexus review-tracker notes. Approved with no comments.
Posted by Codex (gpt-6.1-sol) on behalf of kylez.
Co-authored-by: Simone <0828be588d5c9c4d092c5b1cf01761d5aef63d6b104807fd8e8284d517dd1a99@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <[email protected]> * origin/main: (260 commits) feat(markdown): share one Markdown renderer across messages and documents (#3319) fix(solo): reload workspaces by themselves after a relay pause (#3262) fix(agents): apply prompt and core memory changes at each conversation's next turn (#3170) Bind plugin operations to active native agent calls (#3303) Reopen recently closed threads without the loading mark (#3204) [buzz-app] Restore the last selected thread tab on Back and Forward (#3350) fix(notifications): keep alert sounds out of media controls (#3298) feat(shell): find on screen with Cmd/Ctrl+Shift+F (#2550) Bump block/buzz to pick up messages search --before (#3362) fix(media): save relay images from the native Download Image menu on macOS (#3337) feat(plugins): let plugins lift a message image's subject (#2470) feat(decisions): guide TypeSafe setup and align API key controls (#3365) Fix live sidebar updates after CLI moves (#3213) End desktop Huddles when the creator is the last human (#3328) Skip unchanged artifact row and index writes (#3364) fix(goose): propagate ACP work cancellation to plugin tools (#3351) Keep Solo source selection when opening a channel (#3356) fix(desktop): sign a channel-less deletion of one reaction (#3288) AIDA-2426: Set a default User-Agent for plugins (#2697) fix(plugins): explain Git import refs (#3314) ... Signed-off-by: John Tennant <[email protected]>
…o jtennant/martha/activity-step-previews * origin/chung/feat-enriced-activity: (121 commits) feat(markdown): share one Markdown renderer across messages and documents (#3319) fix(solo): reload workspaces by themselves after a relay pause (#3262) fix(agents): apply prompt and core memory changes at each conversation's next turn (#3170) Bind plugin operations to active native agent calls (#3303) Reopen recently closed threads without the loading mark (#3204) [buzz-app] Restore the last selected thread tab on Back and Forward (#3350) fix(notifications): keep alert sounds out of media controls (#3298) feat(shell): find on screen with Cmd/Ctrl+Shift+F (#2550) Bump block/buzz to pick up messages search --before (#3362) fix(media): save relay images from the native Download Image menu on macOS (#3337) feat(plugins): let plugins lift a message image's subject (#2470) feat(decisions): guide TypeSafe setup and align API key controls (#3365) Fix live sidebar updates after CLI moves (#3213) End desktop Huddles when the creator is the last human (#3328) Skip unchanged artifact row and index writes (#3364) fix(goose): propagate ACP work cancellation to plugin tools (#3351) Keep Solo source selection when opening a channel (#3356) fix(desktop): sign a channel-less deletion of one reaction (#3288) AIDA-2426: Set a default User-Agent for plugins (#2697) fix(plugins): explain Git import refs (#3314) ... Signed-off-by: John Tennant <[email protected]> # Conflicts: # src/features/messages/TypingIndicator.test.tsx
What this does
Moves the
block/buzzpin fromc8d736642e1cto0e6037c74d67(block/buzz#9382). That one pin, thebuzz-audio-clientgit dependency insrc-tauri/Cargo.toml, also picks the revision thatscripts/build-buzz-cli.mjsbuilds the bundledbuzzCLI from. So the bundled CLI gainsbuzz messages search --beforeand--before-id, for paging back through an author's messages.Two commits:
src-tauri/Cargo.tomland the matchingsourceline inCargo.lock. Nothing else in the lock file moves, and--lockedbuilds accept it.scripts/build-buzz-cli.mjs. All revisions used to share one Cargo build folder,target/buzz-cli-build. Cargo treats a git checkout as unchanging, so after a pin bump it trusted the old revision's build and staged the old CLI under the new revision's name. This bump hit that: on a machine that had built the old rev, the stagedbuzzhad no--before. Each revision now builds intarget/buzz-cli-build/<rev>. The cost: the first build after each bump compiles the CLI from scratch (a few minutes), and each revision's build folder stays on disk until someone deletes it, as thetarget/buzz-cli/<rev>install folders already do.docs/releases.mdexplains why, andtests/integration/buzz-cli.test.mjschecks that two revisions get different folders.What the bump brings in
The range has 88 block/buzz commits. Only two things from block/buzz ship in Buzz Desktop: the
buzz-audio-clientcrate and the bundledbuzzCLI, plus the in-repo crates it builds with (buzz-core,buzz-sdk,buzz-ws-client,buzz-persona).Huddle audio client (
crates/buzz-audio-client, one change)User-Agent: buzz-audio-client/<version>when the caller didn't set one. Buzz Desktop sets no User-Agent on the audio socket (src-tauri/src/relay/huddle/audio.rs), so huddle audio connections now carry this header. No API change; the desktop code compiles unchanged.Bundled
buzzCLImessages search --before <unix ts>(sent as the filter'suntil) and--before-id <event id>(requires--before; resumes after that event so events from the same second aren't repeated or skipped).--before-idwith--queryis a usage error. Without the new flags the filter is unchanged.lsoflookup now caps its output and checks the exit status. CLI-side only: the desktop provider protocol is unchanged.messages editkeeps a message's attachments across successive edits, and adds--clear-attachments. It asks the relay for the current effective edit first. Against a relay without that lookup (added in Buzz Relay 0.3.0),messages editnow refuses with "upgrade the relay before editing" instead of dropping attachments.Not shipped in this app (no effect on Buzz Desktop)
Testing
Run by an agent on macOS (Apple Silicon):
cargo fmt --all --check: pass.cargo clippy --workspace --locked --all-targets -- -D warnings: pass.cargo test --manifest-path src-tauri/Cargo.toml --locked: 1121 + 24 passed, 0 failed, with 15 tests skipped for local reasons that have nothing to do with the bump. The 21relay::huddle::audiotests pass. Skipped: the media-conversion tests (media_preparation,converted_spool), because this machine's Homebrewffmpegcan't loadlibx265, andwindow_state::tests::onboarding_snapshot_is_kept_until_next_launch_restore, which crashes the test process (SIGSEGV) on this machine with the old pin too. CI runs the full suite on Linux.node scripts/test-buzz-cli.mjs(stages the CLI the way a desktop build does, then runs it): pass. The stagedbuzz messages search --helplists--beforeand--before-id.node scripts/build-buzz-cli.mjs --devat the old rev staged a CLI without--before-id. Then, at the new rev, Cargo recompiledbuzz-cliin its own folder and the staged CLI listed--before-id. Before the fix, the same sequence on a real machine reportedFresh buzz-cliand staged the old binary.node --test tests/integration/buzz-cli.test.mjs tests/integration/dev-commands.test.mjs: 63 pass.buzz auth desktop listwith the new CLI reports an existing pairing asaccepted. That path runs the new same-user socket check on macOS.--since … --before <now> --limit 5, then a second page with--before <last created_at> --before-id <last id>. Page 2 started right after page 1's last event, with no overlap and nothing newer than the cursor. The old CLI rejects--beforeas an unknown argument.Not tested:
relay::huddle::audiounit tests, not by a real call.buzz auth desktop pair), which needs a person to click Allow.messages editagainst a live relay (it writes).buzz-review-completed
🤖 Generated with Claude Code