[2/2] feat(agents): offer Automatic (Recommended) in Create agent and Identity - #3345

…r check

The create-time Thinking test focuses the Thinking combobox and asserts
that its bottom edge clears the dialog's sticky footer. AgentCreateDialog's
reveal() scrolls the focused control so that bottom − footerTop is exactly
0, and the dialog enters with transform: translateY(var(--space-3)) → none
over 220 ms (overlays.css). The check ran about 150 ms into that
transition in the failing CI trace. With the scroll already at rest, WebKit
reports bottom − footerTop between +0.0006 and +0.0085 px at fractional
translate values, so the <= comparison failed; it is exactly 0 whenever
transform is none. The triage ruled out scrollTop truncation, static
fractional transforms, layout shifts and web fonts.

Wait with settleDialogMotion from navigation.mjs — the helper
dialog-footer, hosted-create-join, layout, message-overlays and
plugin-import already use — right after the dialog is visible, then also
poll for the computed transform to be none, since locally the transition's
finished promise could resolve while the animation was still attached. No
tolerance, timeout or assertion change.

Verified with `bin/pnpm test:browser:ci --project webkit --no-deps
--workers=1 --repeat-each=8 tests/browser/agent-library.spec.mjs -g
"create-time Thinking" --reporter=list`: 8/8 passed locally (12.1–12.3 s
each, 2.4 m). The triage did not reproduce the failure naturally on an idle
host (baseline 8/8 and 10/10 on two pinned CPUs) and only showed it with
the transition stretched to 3 s, so this run guards against regression
rather than reproducing CI timing. Biome is clean on the file.

Not addressed here: the Chromium sighting on PR #3345 was a fixture missing
`recommended` and was fixed by that PR's later push; the similar footer
reads in solo-sharing.spec.mjs, profiles.spec.mjs and the agent-share-card
checks are left for their own change.

Co-Authored-By: Claude Fable 5.1 <[email protected]>
Signed-off-by: mtoohey <[email protected]>
Signed-off-by: Matt Toohey <[email protected]>

## Stack

1. **→ [1/2] feat(agents): add a recommended agent setup (core)**
(#3344) ← this PR
2. [2/2] feat(agents): offer Automatic (Recommended) in Create agent and
Identity (#3345)

## What this adds

A way for a build to ship a recommended agent setup: which harness,
model and thinking level a new agent should use. This PR is the non-UI
part. It adds no screens. [2/2] adds the screens that use it.

If the setting is unset, as in every open-source build, nothing changes.

## How it works

- **The candidate list.** Packagers set `BUZZ_RECOMMENDED_AGENT` at
build time. It is a JSON list of candidates, best first. Each one names
a harness (`goose`, `codex` or `claude-code`), a model, a thinking level
and a display label. goose candidates also name a provider. Vite checks
the list and compiles it in. A bad value fails the build and names the
field at fault without printing the value. A launch can also swap in its
own list (`setRuntimeCandidates`).
- **Readiness checks.** `useRecommendedPick` picks a setup for a new
agent. It walks the list and asks each harness whether it is installed,
signed in or set up, and whether it offers that model now. Each check
has a time limit. A check that fails or runs out of time skips that
candidate. It reports `checking`, `none` or `found`, plus which better
candidates were skipped.
- **Following it at run time.** An agent on the recommendation saves
only a mark (`preset: "recommended"`) and no model of its own. At run
time, goose, Codex and Claude Code each use the first candidate for
their own harness that they still offer. They check once per launch and
look again a minute or more later, so a harness set up since then gets
picked up. If none fits, the agent runs on the harness's own default
instead of failing. Its harness never changes for it. A model or
thinking pick that reaches a run for one of these agents is ignored,
such as one saved in a Solo chat before the switch.
- **The synced mark.** On a config channel the mark syncs next to the
agent's settings, not inside them. Older versions ignore it and keep it
when they edit. A synced revision that names a model, provider or
thinking level takes the agent off the recommendation on every device.
- **Docs.** `docs/configuration.md` documents the setting with
placeholder values.

## Testing

CI runs the suite. `tsc --noEmit` is clean locally.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Signed-off-by: Tim Mellor <[email protected]>
Co-authored-by: Claude Opus 5.5 <[email protected]>

* origin/main: (27 commits)
  [2/2] feat(agents): offer Automatic (Recommended) in Create agent and Identity (#3345)
  fix(solo): preserve and resume unsent chat drafts (#3525)
  fix(builderlab): give refused app sign-ins and Identity links a route to Organization sign-in (#3078)
  fix(agents): say why Import an agent can't import here, and link Manage plugins (#3073)
  [1/2] feat(agents): add a recommended agent setup (core) (#3344)
  test(browser): survive the live-stream restart a page-clock jump causes (#3442)
  chore(renovate): hold rusqlite below 0.41 for mesh-llm (#3438)
  test(browser): serve the diffs and CLI reload fixtures outside the navigation budget (#3445)
  test(browser): play the draft clip at rate 0 instead of looping it before the Play click (#3446)
  fix(status): reopen a status whose preset deadlines coincide as Today (#3449)
  fix(messages): tolerate a cancelled reaction-name chunk load (#3450)
  fix(pairing): tolerate /proc/net/tcp rows printed twice or missed (#3451)
  test(browser): wait on the signal each test asserts in local-agent-activity and message-navigation (#3444)
  Expose native channel headings to Solo sources (#3523)
  test(browser-host): run the 100,000-channel broker scale check alone in the measurements lane (#3447)
  fix(solo): keep every contributed destination action (#3516)
  fix(identity): report an issuer that keeps rate-limiting an agent as a limit (#2365)
  fix(identity): let a stuck at-launch sign-in copy its link (#2453)
  fix(profiles): open avatar previews on hover in compact density (#3510)
  feat(solo): smooth chat recency reordering (#3502)
  ...

# Conflicts:
#	src-tauri/src/federated_identity/agent/tests.rs
#	src-tauri/src/federated_identity/mod.rs
#	src-tauri/src/federated_identity/protocol.rs

* origin/main: (133 commits)
  Expose ordinary chats without workspace headings (block#3530)
  [2/2] feat(agents): offer Automatic (Recommended) in Create agent and Identity (block#3345)
  fix(solo): preserve and resume unsent chat drafts (block#3525)
  fix(builderlab): give refused app sign-ins and Identity links a route to Organization sign-in (block#3078)
  fix(agents): say why Import an agent can't import here, and link Manage plugins (block#3073)
  [1/2] feat(agents): add a recommended agent setup (core) (block#3344)
  test(browser): survive the live-stream restart a page-clock jump causes (block#3442)
  chore(renovate): hold rusqlite below 0.41 for mesh-llm (block#3438)
  test(browser): serve the diffs and CLI reload fixtures outside the navigation budget (block#3445)
  test(browser): play the draft clip at rate 0 instead of looping it before the Play click (block#3446)
  fix(status): reopen a status whose preset deadlines coincide as Today (block#3449)
  fix(messages): tolerate a cancelled reaction-name chunk load (block#3450)
  fix(pairing): tolerate /proc/net/tcp rows printed twice or missed (block#3451)
  test(browser): wait on the signal each test asserts in local-agent-activity and message-navigation (block#3444)
  Expose native channel headings to Solo sources (block#3523)
  test(browser-host): run the 100,000-channel broker scale check alone in the measurements lane (block#3447)
  fix(solo): keep every contributed destination action (block#3516)
  fix(identity): report an issuer that keeps rate-limiting an agent as a limit (block#2365)
  fix(identity): let a stuck at-launch sign-in copy its link (block#2453)
  fix(profiles): open avatar previews on hover in compact density (block#3510)
  ...

Signed-off-by: Joah Gerstenberg <[email protected]>

# Conflicts:
#	src/bundled/codex/prompt.test.ts
#	src/bundled/goose/runtime.ts