Repository navigation
fix: expose proven non-delivery for artifacts - #3300
Merged
Merged
Conversation
Co-authored-by: Codex <[email protected]> Signed-off-by: Daniel Rouleau <[email protected]>
gilgtm
approved these changes
Nov 11, 2026
gilgtm
left a comment
gilgtm
left a comment
Contributor
There was a problem hiding this comment.
🤖 No P0/P1 findings from the deep dual review of this PR. Reviewed head 0e3b605 against main@a42ef62e8e631e179ff810322518d6c8a174b8b7.
Posted by duel-review skill [driver: codex(high), mode: deep-dual, review synthesized by codex(high)]
kazemek21
approved these changes
Nov 11, 2026
kazemek21
left a comment
kazemek21
left a comment
Contributor
There was a problem hiding this comment.
Kyle reviewed this PR and the Nexus review-tracker notes and approved with no comments.
Posted by Codex (gpt-6.1-sol) on behalf of kylez
joahg
added a commit
to joahg/buzz-app
that referenced
this pull request
Nov 12, 2026
* origin/main: (38 commits) Fix reminder counts with compact dock corner tabs (block#3126) Add conditional undo for explicit reads (block#3291) fix(composer): edit channel links as atomic chips (block#3312) fix(agents): show remote instruction limit (block#3325) NEXUS-4033: Offer session skills in the core task composer (block#2790) feat(github): name pasted repository and commit links (block#3268) Let plugins give standing instructions to every agent turn (block#3285) fix(relay): read a channel's creation once, not per metadata version (block#3244) fix(messages): remove unconfirmed sends from this device (block#3317) fix: expose proven non-delivery for artifacts (block#3300) feat(plugins): let plugins mark a person's name in @mention suggestions (block#3260) fix(mcp): strip metadata from images agents attach (block#3311) fix(identity): name a linked key that isn't here, and keep Restore after a failed backup check (block#3238) feat(changesets): show the files a local agent changed on its reply (block#3214) fix(identity): show a backed-up key as backed up, and drop dead retries (block#3223) fix(browser): open Builderlab account connections in the system browser (block#3287) Expose exact captured-message reads (block#3264) docs(agents): keep internal discussion out of public repo content (block#3258) fix(identity): clear a copied private key, name restore failures, fix storage copy (block#3236) fix(channels): list workspaces that load after `#` opens (block#3277) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A plugin can keep an artifact write on disk before it sends the write. If the relay refuses that send, the plugin needs proof that it can retry safely. The current writer does not expose that proof.
What
Add optional
RelayWriter.isNotSent(error)for native and broker artifact writers.How
The host checks its private
PublishNotSenttype. Other errors return false. Callers must treat a missing classifier or false result as an uncertain send.Risk
The method is optional. Existing callers keep their current behavior. The method does not grant access or send an event.
Testing
Native and broker behavior has focused regression coverage. The operator explicitly waives the agent app check and human manual test for this change. Neither test is claimed as passed.
Generated with Codex