Skip to content

perf(css): narrow effort button invalidation - #3297

Merged
dr0uleau merged 1 commit into
mainfrom
drouleau/effort-class-invalidation
Nov 11, 2026
Merged

dr0uleau merged 1 commit into
mainfrom
drouleau/effort-class-invalidation

Conversation

@dr0uleau

Copy link
Copy Markdown
Contributor

Why

A keyboard-mode change can mark unrelated nodes for style work. The effort control refers to shared buttons through a generic class attribute selector.

What

Use the global .buzz-button class in the existing CSS Modules rule. Keep transition values, specificity, motion, and control behavior unchanged.

How

Keep the class inside :where(). Use the existing local Biome note for CSS Modules syntax.

Risk

The rule controls transitions in the effort picker. The change preserves which class tokens match and when the keyboard rule applies.

Testing

A small headless check compiles both selector forms with pinned Vite. Chromium and WebKit match the same exact, multiple, whitespace, and SVG class tokens. Both exclude near matches and elements outside the slider. Cascade order and keyboard-attribute removal behave the same.

No new performance measurement runs. Full response acceptance remains open.

Generated with Codex

Co-authored-by: OpenAI Codex <[email protected]>
Signed-off-by: drouleau <[email protected]>
Co-authored-by: Codex <[email protected]>
@dr0uleau
dr0uleau requested review from a team, gilgtm and kazemek21 November 11, 2026 19:12
@dr0uleau
dr0uleau marked this pull request as ready for review November 11, 2026 19:21

@kazemek21 kazemek21 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the PR and went through the Nexus review-tracker notes. I didn't see any P2-or-higher issues in this change.

Posted by Codex (gpt-6.1-sol) on behalf of kylez

@dr0uleau
dr0uleau merged commit 99fe700 into main Nov 11, 2026
68 checks passed
@dr0uleau
dr0uleau deleted the drouleau/effort-class-invalidation branch November 11, 2026 20:24

@gilgtm gilgtm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 No P0/P1 findings. Reviewed the complete PR at 47453ae against main@42dd143738eff78758a3d86e183f9cb3aff65c02.

Posted by duel-review skill [driver: codex(high), mode: deep-dual, review synthesized by codex(high)]

joahg added a commit to joahg/buzz-app that referenced this pull request Nov 11, 2026
* origin/main:
  NEXUS-4029: Offer folder chips in the composer (block#2789)
  perf(css): narrow effort button invalidation (block#3297)
  NEXUS-4433: Expose saved plugin installation source kind (block#3242)
  fix(identity): keep an unbacked key safe on Replace and unblock a corrupt saved key (block#3233)
  Expose Solo region state before a component mounts (block#3296)
  fix(builderlab): say a 401 was refused, not expired, and show each sign-in failure once (block#3241)
  feat(agents): file new Solo chats in explicit personal workspaces (block#2857)
  perf(css): limit broad style invalidation (block#3267)
  Delay and fade in the Bestie badge celebration (block#3292)
  fix(github): show private-repo body images from signed links (block#3252)
  NEXUS-4029: Preserve semantic chips in the core composer (block#2303)
  Make plugin signature enforcement opt-in (block#2212)
  NEXUS-4156: Add workspace Leads and choose a chat's workspace (block#2788)
  feat(plugins): report conclusively retired update providers (block#3263)
  feat(messages): let attachment renderers open files from the host file card (block#2239)
  feat(charts): bundle a Charts code-block renderer (block#3226)
  Expose native reply grouping through Conversation.ui (block#3245)

Signed-off-by: Joah Gerstenberg <[email protected]>

# Conflicts:
#	src/features/conversation/ComposerCompletions.test.tsx
#	src/features/conversation/ComposerCompletions.tsx
#	src/features/messages/MessageComposer.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants