Skip to content

fix(goose): enable deferred tool loading for goose agents - #3227

Merged
salman1993 merged 4 commits into
mainfrom
sm/goose-tool-deferral-config-main
Nov 10, 2026
Merged

salman1993 merged 4 commits into
mainfrom
sm/goose-tool-deferral-config-main

Conversation

@salman1993

@salman1993 salman1993 commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Replaces #3143 (by @jamadeo), with the latest main merged in and squashed into one commit.

What

  • Turns on goose's lookup tool deferral (feat: minimal deferred MCP tools in ToolExecutionOperation aaif-goose/goose#13378): GOOSE_TOOL_DEFERRAL=lookup plus GOOSE_TOOL_DEFERRAL_ALWAYS_LOAD, so Buzz tools load only when they're needed.
  • Pins goose-acp to v1.59.0, the first release that includes it.
  • Leaves mesh sessions out: meshGooseEnv unsets both settings, with a TODO, since mesh hasn't been tested with deferral.
  • Adds a live test, enables a deferred Buzz tool before executing it, that checks the recorded provider requests.

Notes

Testing

  • tsc and biome pass.
  • The src/bundled/goose and src/buzz-mcp tests pass (750).
  • Before the main merge, the live tests passed against the real 1.59.0 binary. They haven't been rerun since.

salman1993 and others added 2 commits November 10, 2026 14:26
Turn on goose's lookup tool deferral (aaif-goose/goose#13378) so Buzz
tools load on demand, and pin goose-acp to v1.59.0, the first release
with it. A live test checks that a deferred Buzz tool is enabled
before it runs.

Co-authored-by: Jack Amadeo <[email protected]>
Co-authored-by: gus <09b93b3b4074c080c50c23964a0cd36f95bdf1446c55342394f1ac8386fae44a@buzz.block.builderlab.xyz>
Signed-off-by: Salman Mohammed <[email protected]>
Mesh deferral is untested, so unset the goose deferral settings for
mesh turns until it is.

Co-authored-by: gus <09b93b3b4074c080c50c23964a0cd36f95bdf1446c55342394f1ac8386fae44a@buzz.block.builderlab.xyz>
Signed-off-by: Salman Mohammed <[email protected]>
@salman1993 salman1993 changed the title Enable lookup-based tool deferral for goose agents fix(goose): enable deferred tool loading for goose agents Nov 10, 2026
@salman1993
salman1993 marked this pull request as ready for review November 10, 2026 19:29
@salman1993
salman1993 requested a review from a team as a code owner November 10, 2026 19:29
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T19:31:12.236220Z d021f69 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@salman1993 salman1993 reopened this Nov 10, 2026

@kazemek21 kazemek21 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kyle reviewed this PR and the Nexus review-tracker notes and approves.

Posted by Codex (gpt-6.1-sol) on behalf of kylez

@salman1993
salman1993 merged commit 7f35bb1 into main Nov 10, 2026
64 checks passed
@salman1993
salman1993 deleted the sm/goose-tool-deferral-config-main branch November 10, 2026 23:25
bostonaholic added a commit that referenced this pull request Nov 11, 2026
…y-untagged-reactions

* origin/main: (324 commits)
  fix(github): show private-repo body images from signed links (#3252)
  NEXUS-4029: Preserve semantic chips in the core composer (#2303)
  Make plugin signature enforcement opt-in (#2212)
  NEXUS-4156: Add workspace Leads and choose a chat's workspace (#2788)
  feat(plugins): report conclusively retired update providers (#3263)
  feat(messages): let attachment renderers open files from the host file card (#2239)
  feat(charts): bundle a Charts code-block renderer (#3226)
  Expose native reply grouping through Conversation.ui (#3245)
  NEXUS-4163: Keep plugin-owned chat deletion in Solo (#2787)
  NEXUS-4156: Expose Solo Workspaces to plugin regions (#2786)
  NEXUS-4022: Start region chats in the New Chat editor (#2784)
  feat(link-previews): unfurl web links below messages by default (#3225)
  fix(messages): keep names in literal Markdown as written when editing (#2834)
  feat(plugins): fetch a packaged managed plugin policy from a URL (#2504)
  fix(goose): enable deferred tool loading for goose agents (#3227)
  fix(unread): preserve manual intent in captured explicit reads (#3228)
  NEXUS-4337: Expose retained plugin update reviews (#3075)
  feat(conversation): add a link preview slot below messages (#3219)
  feat(plugins): let link previews read a public page's preview fields (#3217)
  Let sidebar row plugins decorate ordinary Solo chats (#3222)
  ...
tlongwell-block added a commit that referenced this pull request Nov 11, 2026
* origin/main: (121 commits)
  Expose Solo region state before a component mounts (#3296)
  fix(builderlab): say a 401 was refused, not expired, and show each sign-in failure once (#3241)
  feat(agents): file new Solo chats in explicit personal workspaces (#2857)
  perf(css): limit broad style invalidation (#3267)
  Delay and fade in the Bestie badge celebration (#3292)
  fix(github): show private-repo body images from signed links (#3252)
  NEXUS-4029: Preserve semantic chips in the core composer (#2303)
  Make plugin signature enforcement opt-in (#2212)
  NEXUS-4156: Add workspace Leads and choose a chat's workspace (#2788)
  feat(plugins): report conclusively retired update providers (#3263)
  feat(messages): let attachment renderers open files from the host file card (#2239)
  feat(charts): bundle a Charts code-block renderer (#3226)
  Expose native reply grouping through Conversation.ui (#3245)
  NEXUS-4163: Keep plugin-owned chat deletion in Solo (#2787)
  NEXUS-4156: Expose Solo Workspaces to plugin regions (#2786)
  NEXUS-4022: Start region chats in the New Chat editor (#2784)
  feat(link-previews): unfurl web links below messages by default (#3225)
  fix(messages): keep names in literal Markdown as written when editing (#2834)
  feat(plugins): fetch a packaged managed plugin policy from a URL (#2504)
  fix(goose): enable deferred tool loading for goose agents (#3227)
  ...

Signed-off-by: Tyler Longwell <[email protected]>
Co-authored-by: Eva <011987e296fd5006292d2f930b574be47c7801048d1983c46c425d3c95f0cffd@buzz.block.builderlab.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants